Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CoreBundle optional #1173

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Make CoreBundle optional #1173

merged 1 commit into from
Jun 8, 2020

Conversation

wbloszyk
Copy link
Member

@wbloszyk wbloszyk commented May 20, 2020 •
edited

Subject

I am targeting this branch, because this changes are BC.

Part of sonata-project/dev-kit#697

Changelog

### Removed
- remove SonataCoreBundle dependencies

@wbloszyk wbloszyk mentioned this pull request May 20, 2020
Closed
31 tasks
@wbloszyk wbloszyk closed this Jun 4, 2020
@wbloszyk wbloszyk reopened this Jun 4, 2020
@wbloszyk wbloszyk marked this pull request as ready for review June 4, 2020 22:59
core23
core23 previously approved these changes Jun 5, 2020
View reviewed changes
jordisala1991
jordisala1991 previously approved these changes Jun 5, 2020
View reviewed changes
@wbloszyk wbloszyk dismissed stale reviews from jordisala1991 and core23 via 1f8e13b June 5, 2020 16:21
@jordisala1991 jordisala1991 requested review from core23 and a team June 8, 2020 20:16
@core23 core23 merged commit 0c622be into sonata-project:4.x Jun 8, 2020
@core23
Copy link
Member

core23 commented Jun 8, 2020

Thanks @wbloszyk 🚀

@wbloszyk wbloszyk deleted the drop_core_in_3 branch June 8, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991 jordisala1991 approved these changes

@core23 core23 core23 approved these changes

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wbloszyk @core23 @jordisala1991 @VincentLanglet