Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Remove duplicate translation on nl #1288

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Conversation

elyanory
Copy link
Contributor

@elyanory elyanory commented Nov 24, 2020

Subject

Upon installation, an error is triggered (when composer tries to clear the cache). This error is caused by a duplicate key in a translation file.

I am targeting this branch, because there is a duplicate key in one of the translations.

Closes #1287 .

Changelog

### Fixed
- Duplicate translation in `src/Resources/translations/SonataUserBundle.nl.xliff`

@phansys phansys added the patch label Nov 24, 2020
Copy link
Member

@phansys phansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @elyanory.

Could you please use the PR template in order to make clear the reason for this change?

I'm not a Dutch speaker, so I'd expect for the approval of some other contributors.

@elyanory
Copy link
Contributor Author

Hey @phansys,

Sorry I went a bit fast. I corrected 😄

@OskarStark OskarStark merged commit 70c03d0 into sonata-project:4.x Nov 24, 2020
@SonataCI
Copy link
Collaborator

Ok @phansys,

I requested a new release for SonataUserBundle via Slack in #releases channel 👍

If you want to get notified about new releases, make sure to follow SonataNews on Twitter!

@sonata-project sonata-project deleted a comment from phansys Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation key "sonata.user" is duplicated at SonataUserBundle.nl.xliff
5 participants