Fix compatibility with doctrine/persistence 2.0

[jordisala1991]

Subject

Class aliases need to be created on a place that it is always executed,
previous code was only executed on an empty cache. Next request were
always broken. Moving to the bundle class ensures the code is always
executed.

I am targeting this branch, because this is a bugfix and BC.

Closes #1331
Closes #1336

Changelog

### Fixed
- Fix compatibility with doctrine/persistence 2.0

[jordisala1991]

Well, it works on a project, but not on the test suite, any ideas?

Maybe adding the alias on the classes that needs them?

[phansys]

IMO, these aliases are not really required by this package, but by "friendsofsymfony/user-bundle". Maybe we should just move them to tests/bootstrap.php in order to allow our test suite to pass the build.
The final users should declare these aliases in their own bootstrapping, since the issue around them is not actually under our responsibility.

[VincentLanglet]

IMO, these aliases are not really required by this package, but by "friendsofsymfony/user-bundle". Maybe we should just move them to tests/bootstrap.php in order to allow our test suite to pass the build.
The final users should declare these aliases in their own bootstrapping, since the issue around them is not actually under our responsibility.

It should be in custom_boostrap then.
https://github.com/sonata-project/SonataUserBundle/blob/4.x/tests/bootstrap.php#L27

[jordisala1991]

IMO, these aliases are not really required by this package, but by "friendsofsymfony/user-bundle". Maybe we should just move them to tests/bootstrap.php in order to allow our test suite to pass the build.
The final users should declare these aliases in their own bootstrapping, since the issue around them is not actually under our responsibility.

Well, you are declaring this package as compatible with doctrine/persistence 2.0, but this package has a dependency that is not compatible. IMHO we either fix this with code like this one, or we can't do this. Someone just updates this packages and then code stops working.

Agree on adding it to tests/bootstrap.php if that fixes the issue, but as I explained before I don't think that is the responsability of each user to know what we did here and add some alias so have the bundle working again.

[VincentLanglet]

We could declare the BC method as a static one and call it every where we need the BC layer

[phansys]

I think using SonataUserBundle::boot() for projects and tests/custom_bootstrap.php for the test suite is the best approach.

[phansys]

@jordisala1991, do you have time to finish this PR?

[jordisala1991]

I will try tomorrow, yes

[VincentLanglet]

What about making this method public static in order to call it in the custom_boostrap ?

[jordisala1991]

Then it would be bc break to remove it, IMO not a good idea.

[phansys]

Thank you @jordisala1991.

[SonataCI]

Ok @phansys,

I requested a new release for SonataUserBundle via Slack in #releases channel 👍

If you want to get notified about new releases, make sure to follow SonataNews on Twitter!