Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Add symfonycasts/reset-password-bundle #1455

Closed
wants to merge 1 commit into from

Conversation

wbloszyk
Copy link
Member

Subject

POC for replace FOSUser resetting password into symfonycasts resetting password.

I am targeting this branch, because {reason}.

Closes #{put_issue_number_here}.

Changelog

### Added
- Added some `Class::newMethod()` to do great stuff.

### Changed

### Deprecated

### Removed

### Fixed

### Security

@wbloszyk wbloszyk mentioned this pull request Dec 17, 2021
@jordisala1991
Copy link
Member

jordisala1991 commented Dec 17, 2021

This has several problems that I solved already on RunroomUserBundle. We can go into details if you want, but I recommend you to go to that bundle, check the code and see the problem we faced on that integration (It is not suported to reset password for more of 1 entity, if you want to make it optional you have to deal with the entities without using the interface directly ).

But again , why is that Pr related to the FOSUser removal? It can and should be handled separately because of the mentioned issues and because it is NOT needed to remove FOSUser.

@Hanmac
Copy link
Contributor

Hanmac commented Dec 19, 2021

This has several problems that I solved already on RunroomUserBundle. We can go into details if you want, but I recommend you to go to that bundle, check the code and see the problem we faced on that integration (It is not suported to reset password for more of 1 entity, if you want to make it optional you have to deal with the entities without using the interface directly ).

yeah i noticed that too, (my newest project needs password reset for multiple user entities)
so i made an Issue there: SymfonyCasts/reset-password-bundle#203

i mean you can make it possible if you have the Reset Provider branch for different User and ResetToken classes and delegate that stuff.

@wbloszyk
Copy link
Member Author

I use it in multiple user project but i use BaseUser and discriminator for it.

@VincentLanglet
Copy link
Member

Closing since we're gonna release the RC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants