Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user admin #1500

Merged
merged 3 commits into from
Feb 17, 2022

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Feb 16, 2022

Subject

I am targeting this branch, because this is BC break.

Part of #1465 .

Maybe before it had sense to have multiple tabs because all the fields we had about social integrations, now that the admin is simplified IMO we should simplify the form show.

Also I changed the default form type for the roles. IMO we should deprecate the older one. Not sure if deprecate right away, because that would mean an unavoidable deprecation (because changing the form type is probably BC break for those doing integration tests on the form page) or removing directly here. Wdyt @VincentLanglet ?

Before:
image
image

After:
image

Changelog

### Fixed
- Simplified User admin to show all fields in a single page.
- Fixed User admin translation for group fields.

### Removed
- Removed `SecurityRolesType` to render roles on the User edit form.

@jordisala1991
Copy link
Member Author

I added the removal of the old type for rendering roles. I can move to another PR if needed.

@jordisala1991 jordisala1991 force-pushed the hotfix/fix-user-admin branch 2 times, most recently from 64af412 to 6d425a5 Compare February 16, 2022 07:59
VincentLanglet
VincentLanglet previously approved these changes Feb 17, 2022
@VincentLanglet
Copy link
Member

I added the removal of the old type for rendering roles. I can move to another PR if needed.

Seems ok to me like this. But maybe we could add a line in the Changelog file

@jordisala1991 jordisala1991 merged commit 85aa2dc into sonata-project:5.x Feb 17, 2022
@jordisala1991 jordisala1991 deleted the hotfix/fix-user-admin branch February 17, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants