-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SonataAdminBundle dependency optional #1503
Make SonataAdminBundle dependency optional #1503
Conversation
Failing tests are not caused by the changes in this PR. See #1504 |
617d948
to
58bd111
Compare
Disregard my last comment. It appears that some Symfony FrameworkBundle configs are cleverly applied depending on whether a certain dependency is expected to be available in non-dev install. I had to add |
Thanks @supersmile2009 ! |
Subject
This PR makes SonataAdminBundle dependency optional.
I am targeting 5.x branch, because v5 hasn't got to a final release yet and BC breaks can potentially be still accepted and there were no objections to that in the referenced issue.
Closes #1499
Changelog
To do
Notes:
GlobalVariables
is OK or it would be better to conditionally register pool as another Twig variable (e. g.sonata_user_admin
)?