Roles matrix group by admin and admin group #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @piddubnij, sorry for the delay ; do you have a screenshot of the result ? |
VincentLanglet
requested changes
Jan 1, 2023
There was a problem hiding this comment.
I thought the proposal in #1583 (comment) was "just" to change
List
List
Media
...
to
Article - List
Menu - List
sonata_media - Media
...
Wasn't the implementation proposed possible ?
Because the one proposed in the issue seemed BC when this one is introducing BC-break
|
admin roles sort by admin config and group config admin_label set admin translation domain
piddubnij
force-pushed
the
5.x-roles-matrix-group
branch
from
0f3e6f2
to
fd95b18
Compare
piddubnij
commented
Jan 3, 2023
piddubnij
commented
Jan 3, 2023
VincentLanglet
force-pushed
the
5.x-roles-matrix-group
branch
from
c473f64
to
fb6023b
Compare
VincentLanglet
approved these changes
Jan 7, 2023
|
@VincentLanglet Thank you 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Admin roles attribute "admin_label" set admin translation domain
Roles matrix group by admin and admin group
Admin roles sort by admin config and group config
I am targeting this branch, because this is BC.
Closes #1583.
Changelog