Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserListener: use event_listener instead of subscriber #1651

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Jun 13, 2023

Subject

I am targeting this branch, because it should be without BC break?

Closes #1650.

Changelog

### Fixed
- Deprecation of Event Subscribers on Symfony 6.3. The UserListener now uses Event Listeners

From Coverage testing, it seems that current phpunit test doesn't check the same for ODM too.
Do we need more Unit tests, that explicit test ODM?

  • doctrine.orm.entity_listener would be more specific for ORM, but it seems something like that doesn't exist for ODM.

@jordisala1991 jordisala1991 merged commit 4049188 into sonata-project:5.x Jun 13, 2023
24 checks passed
@jordisala1991
Copy link
Member

Thanks @Hanmac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation: UserListener needs to be done as listener instead of subscriber
3 participants