Remove FOSUser controllers for FOSUser2 #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordisala1991
changed the title
greg0ire
approved these changes
Mar 25, 2017
|
I removed those templates that are useles now because we have less controllers. And fixed a bug when editing and showing user profile (id parameter was incorrect) |
This was referenced Mar 28, 2017
|
Please review @sonata-project/contributors |
core23
approved these changes
Mar 29, 2017
|
Do we still need this template? https://github.com/sonata-project/SonataUserBundle/blob/add_support_for_fos_user2/Resources/views/layout.html.twig |
|
😱 not sure! I will have to test |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because I want to remove them on master after upgrade to 2.0 (that's why first here) It will need a deprecation on 3.x.
Subject
Having those controllers here only creates more maintenance issues... They are not required for the bundle to work.
Also having to define a Parent bundle it is not required