Drop php5 #225
Merged
Drop php5 #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be a good occasion to add php |
|
@soullivaneuh Your job :) |
|
Even I quite personally agree with that, PHP 5.6 still have security update. In my very personal opinion, I would also like to remove the support of this kind of version. But Sonata packages are also used by @rande company and it's a quite important change that make lot of debates on each open-source project. I would like the "Go" of @rande before doing this. |
|
Hello, New majors are there to move forward, so I will be happy to drop php 5 on the next major. |
|
Thanks @rande ! @soullivaneuh , please merge and apply, this blocks #216 |
soullivaneuh
approved these changes
Jan 31, 2017
|
Thank you @core23 |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the twitter vote, we could drop PHP5 completly for the next majors.