Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Missing profile part #627

Closed
wants to merge 1 commit into from
Closed

Conversation

wbloszyk
Copy link
Member

@wbloszyk wbloszyk commented Dec 4, 2019

Reference to #614 #547

Subject

I add SonataProfileBundle - copy of missing part when update SonataUserBundle 3.x to 4.x.

I am targeting this branch, because it is feature with BC.

Changelog

### Added
- Added missing profile part when using SonataUserBundle > 3.x

src/ProfileBundle/Block/AccountBlockService.php Outdated Show resolved Hide resolved
src/ProfileBundle/Block/AccountBlockService.php Outdated Show resolved Hide resolved
src/ProfileBundle/Block/AccountBlockService.php Outdated Show resolved Hide resolved
src/ProfileBundle/Controller/ProfileController.php Outdated Show resolved Hide resolved
@wbloszyk wbloszyk force-pushed the profile_feature branch 3 times, most recently from 2d6abce to 90b7e52 Compare December 17, 2019 11:35
@wbloszyk wbloszyk requested a review from core23 December 17, 2019 12:58
src/ProfileBundle/Block/ProfileMenuBlockService.php Outdated Show resolved Hide resolved
src/ProfileBundle/Block/ProfileMenuBlockService.php Outdated Show resolved Hide resolved
src/ProfileBundle/Controller/ProfileController.php Outdated Show resolved Hide resolved
src/ProfileBundle/Controller/ProfileController.php Outdated Show resolved Hide resolved
@wbloszyk
Copy link
Member Author

wbloszyk commented Dec 21, 2019

For now ProfileBundle is copy of missing profile from SonataUserBunde < 4.0. Base on #1121 SonataUserBundle should only integrate User to Admin, without frontend. Also ProfileBundle is not required in ecommerce bundle(but nice to have in sandbox).

This bundle have:

  • simple user block
  • menu block
  • profile component

Lets make new secound tier bundle with predefined block, components, tools etc., which is "Nice to have" in sandbox and other system, but is not required. By default should be disabled.

List what it can have:

  • simple user block,
  • menus tools with menu block (to define many menus)
  • breadcrumb tools (simmilar to menu, also can be generated from menu)
  • profiles components
  • newsletter (block to display, controller to handler and events where developer can add what to do)
  • newsletter in admin (to send email to subscibers)
  • and many others

@core23 @greg0ire
Mybe SonataToolsBundle? Or I should close this PR and replace this code to sandbox?

@wbloszyk wbloszyk force-pushed the profile_feature branch 3 times, most recently from 42feffa to d78cfcb Compare December 23, 2019 11:47
Copy link
Member

@core23 core23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the whole profile stuff is not related to the ecommerce bundle at all? We'll create a new repo for this the next days

@wbloszyk
Copy link
Member Author

wbloszyk commented Dec 23, 2019

@core23
before ecommerce used profile from UserBundle. Now they should have own minimal profile(not editable) which can be override by seperate profile bundle.

@wbloszyk wbloszyk closed this Dec 23, 2019
@wbloszyk wbloszyk changed the title Add ProfileBundle Missing profile part after update SonataUserBundle Dec 25, 2019
@wbloszyk wbloszyk changed the title Missing profile part after update SonataUserBundle Missing profile part Dec 25, 2019
@wbloszyk wbloszyk reopened this Dec 25, 2019
@wbloszyk wbloszyk closed this Dec 25, 2019
@wbloszyk wbloszyk reopened this Dec 25, 2019
@wbloszyk
Copy link
Member Author

So the whole profile stuff is not related to the ecommerce bundle at all? We'll create a new repo for this the next days

@core23 new repo or bundle for one feature is not enought. I resolve profile(dashboard) issue by add template and menu_builder variable to configuration. Now ecommerce have own profile, like UserBundle should have. Also profiles can be easy merge by change menu_builder options.

@wbloszyk wbloszyk closed this Dec 25, 2019
@wbloszyk wbloszyk reopened this Dec 25, 2019
@wbloszyk wbloszyk requested a review from core23 December 25, 2019 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants