Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Drop support for Symfony < 4.3 #674

Merged
merged 1 commit into from Jun 12, 2020

Conversation

wbloszyk
Copy link
Member

@wbloszyk wbloszyk commented Jun 2, 2020

Subject

Drop support for Symfony < 4.3.

I am targeting this branch, because this change respect BC.

Changelog

### Removed
- Remove support for Symfony <4.3 and php <7.2
### Fixed
- Deprecations for event dispatching

@wbloszyk wbloszyk force-pushed the drop_symfony_3 branch 2 times, most recently from e21b684 to c223578 Compare June 2, 2020 18:03
@wbloszyk wbloszyk marked this pull request as ready for review June 2, 2020 18:15
@jordisala1991
Copy link
Member

Can you fill the PR template?

@wbloszyk
Copy link
Member Author

wbloszyk commented Jun 3, 2020

Should i drop symfony 4.3 too?

@jordisala1991
Copy link
Member

Is it worth it?

@wbloszyk
Copy link
Member Author

wbloszyk commented Jun 3, 2020

Symfony 4.3 is not maintained. I think we can keep support for 4.3 and drop in in master.

@jordisala1991
Copy link
Member

That would be good I think. Make all BC changes on 3.x. Upgrade to 4.4 and bc break on master

jordisala1991
jordisala1991 previously approved these changes Jun 4, 2020
There is another LTS we support (4.4)
@jordisala1991 jordisala1991 requested a review from a team June 12, 2020 14:29
Copy link
Member

@core23 core23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO you can bump this to 4.4, as the 4.3 support will end in a few weeks:
https://symfony.com/releases/4.3

@jordisala1991 jordisala1991 merged commit f859369 into sonata-project:3.x Jun 12, 2020
@jordisala1991
Copy link
Member

Thank you @wbloszyk

@wbloszyk
Copy link
Member Author

@core23 I know but diffrence is not do much. Also all sonata 3 bundles support it. It will be good idea to keep minimum require symfony 4.3 in whole sonata 3.

@core23
Copy link
Member

core23 commented Jun 12, 2020

What I wanted to say is that our release cycle is very slow for this bundle. IMHO you can already create a new PR to drop 4.3.

@wbloszyk
Copy link
Member Author

I will focus on sandbox and PageBundle now. I needed in to my 3 commerce project. I have many improve in my roadmap for this bundle too. I will update some issue on next week like sonata 4, blocks upgrade, sandbox 3 and 4 roadmap, ecommerce.

@wbloszyk wbloszyk deleted the drop_symfony_3 branch June 16, 2020 11:39
@greg0ire
Copy link
Contributor

Should this be patch or minor?

@wbloszyk
Copy link
Member Author

Next release should be minor and should include #678. This PR is RTM. Will be awesome release it with drop CoreBundle (both drop twig/extensions).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants