This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
Replace truncate filter with u filter #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
|
RTM |
core23
reviewed
Jun 22, 2020
| private function configureStringExtension(ContainerBuilder $container): void | ||
| { | ||
| if (!$container->hasDefinition('twig.extension.string') || !is_a($container->getDefinition('twig.extension.string')->getClass(), StringExtension::class)) { | ||
| $definition = new Definition(StringExtension::class); |
There was a problem hiding this comment.
Will this work if our other bundles will register the same StringExtension::class service?
There was a problem hiding this comment.
It should work, becouse result will be the same.
jordisala1991
approved these changes
Jun 22, 2020
core23
approved these changes
Jun 22, 2020
phansys
approved these changes
Jun 22, 2020
|
Thank you @wbloszyk! |
|
Thank you @franmomu |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
This bundle was using
truncatefilter without explicitly requiretwig/extensions, with this PR it usesufilter.I added
twig/extra-bundleto autoload the Twig extension and a fallback in case Flex is not used.Ref: sonata-project/SonataAdminBundle#6132
I am targeting this branch, because these changes are BC.
Changelog