DevKit updates for 1.x branch #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core23
previously approved these changes
Nov 5, 2017
|
@greg0ire Can you have a look at this? |
|
@core23 you mean can I have a look at the ODM build, which I asked for help about on Slack? Uuuuh sure 😅 |
|
Oh, sorry. I'm not that active on slack 😅 Thought the bug was introduced by the |
|
No worries ;) I'm trying things I see here: https://github.com/doctrine/mongodb/blob/master/.travis.yml |
greg0ire
force-pushed
the
1.x-dev-kit
branch
4 times, most recently
from
0cc46e8
to
5554b88
Compare
|
Tried many things, to no avail... halp! |
greg0ire
force-pushed
the
1.x-dev-kit
branch
4 times, most recently
from
0ae44be
to
af37a19
Compare
|
Tried moar things, looks good :) |
greg0ire
force-pushed
the
1.x-dev-kit
branch
2 times, most recently
from
be6e432
to
40c5bb3
Compare
jordisala1991
force-pushed
the
1.x-dev-kit
branch
from
bee3fd1
to
cad808c
Compare
core23
approved these changes
Nov 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog