Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate sonata_urlsafeid in favor of SonataAdminBundle #225

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Jul 19, 2021

Subject

I am targeting this branch, because BC.

Closes sonata-project/SonataAdminBundle#7068.

Changelog

### Deprecated
- `sonata_urlsafeid` filter

phansys
phansys previously approved these changes Jul 19, 2021
Comment on lines 68 to 69
'Method "%s()" is deprecated since sonata-project/twig-extension 1.7 and will be removed in version 2.0'
.' in favor of the "sonata_urlsafeid" method of the SonataAdminBundle.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Method "%s()" is deprecated since sonata-project/twig-extension 1.7 and will be removed in version 2.0'
.' in favor of the "sonata_urlsafeid" method of the SonataAdminBundle.'
'Method "%s()" is deprecated since sonata-project/twig-extension 1.7 in favor of the "sonata_urlsafeid"'
.' Twig filter defined by SonataAdminBundle and will be removed in version 2.0.'

@trigger_error(sprintf(
'Method "%s()" is deprecated since sonata-project/twig-extension 1.7 and will be removed in version 2.0'
.' in favor of the "sonata_urlsafeid" method of the SonataAdminBundle.'
.' You might solve this deprecation by declaring this bundle before the SonataAdminBundle one.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.' You might solve this deprecation by declaring this bundle before the SonataAdminBundle one.',
.' You can solve this deprecation by enabling this bundle before SonataAdminBundle.',

phansys
phansys previously approved these changes Jul 19, 2021
@phansys phansys requested a review from a team July 19, 2021 23:14
core23
core23 previously approved these changes Jul 20, 2021
Copy link
Member

@franmomu franmomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In TemplateExtension there is also this:

public function getTokenParsers(): array
{
return [
new TemplateBoxTokenParser($this->debug),
];
}

is it ok to deprecate it?

@VincentLanglet
Copy link
Member Author

In TemplateExtension there is also this:

public function getTokenParsers(): array
{
return [
new TemplateBoxTokenParser($this->debug),
];
}

is it ok to deprecate it?

I don't know what it's used for, so I changed the deprecation to only deprecating the filter.

Copy link
Member

@franmomu franmomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franmomu franmomu merged commit 26804f6 into sonata-project:1.x Jul 20, 2021
@franmomu
Copy link
Member

Thanks @VincentLanglet !

@VincentLanglet VincentLanglet deleted the deprecate branch July 20, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate or not sonata_urlsafeid
4 participants