Add nancy dependency checking #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zendern
approved these changes
Oct 2, 2020
|
FYI it looks like they changed hacktoberfest requirements...good intent of preventing spam, but more work to participate. More proof spam ruins lives. 😞 |
bhamail
approved these changes
Oct 14, 2020
There was a problem hiding this comment.
+1 I'm gonna merge this puppy shortly.
Just as a heads-up, I saw the following error when trying to run a local CircleCI build. I'm guessing it is some sort of macos/docker thang:
docker_test.go:47: >>>>>>>>>>>>>> yum using autodetect: yum-autodetect/Dockerfile
Error: exit status 1
Output 1: 1
=== CONT TestDockerIntegration/docker/dnf
docker_test.go:49: >>>>>>>>>>>>>> dnf: Got permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Post http://%2Fvar%2Frun%2Fdocker.sock/v1.40/build?buildargs=%7B%7D&cachefrom=%5B%5D&cgroupparent=&cpuperiod=0&cpuquota=0&cpusetcpus=&cpusetmems=&cpushares=0&dockerfile=dnf%2FDockerfile&labels=%7B%7D&memory=0&memswap=0&networkmode=default&nocache=1&rm=1&session=sh3zhq9b7r48s0fermd2mbok6&shmsize=0&target=&ulimits=null&version=1: dial unix /var/run/docker.sock: connect: permission denied
I also thought I saw some similar related discussion elsewhere. Just mentioning in case you need a labrat to try stuff on macos - I can try stuff out as needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated CI config to dogfood nancy.
This pull request makes the following changes:
It relates to the following issue #s:
cc @bhamail / @DarthHater