fix CVE-2021-28965 via rubocop (direct dependency) upgrade. document it #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bhamail I sent this to @lomky and @colinxfleming, who are both Ruby veterans and awesome people (who I think you remember), you might get some feedback from them! |
|
@lomky I made the big long bundle output text collapsed by default. Hopefully that is better (I kinda wanted to keep the details of the different approaches available for the morbidly curious).
|
|
Good explanation of the moving pieces here I think, and covers viable approaches - looks good to my eyes, whatever that's worth! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IQ Server discovered a vulnerability in one of our components.
I upgraded the vulnerable component, and left a trail of bread crumbs through the forest.
Please holler if I've suggested anything horrific.
cc @bhamail / @DarthHater / @brittanybelle / @gmohre