Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update circleci config.yml #148

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Update circleci config.yml #148

merged 1 commit into from
Dec 8, 2023
+5 −3

Conversation

cshaley
Copy link
Contributor

@cshaley cshaley commented Dec 7, 2023

See #147

This pull request makes the following changes:

It relates to the following issue #s:

cc @bhamail / @DarthHater

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

bhamail
bhamail approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@bhamail bhamail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! (see PR #147 for background)

@bhamail bhamail merged commit 1385908 into sonatype-nexus-community:main Dec 8, 2023
11 checks passed
@bhamail
Copy link
Contributor

bhamail commented Dec 8, 2023 •
edited
Loading

@cshaley Thanks so much for you work on this!
The tenth time's the charm ;)
I had to also add twine credentials to get that step happy.
I'm still not certain semantic-release is incrementing the version in pyproject.toml (which I thought it used to do).

@cshaley cshaley mentioned this pull request Dec 8, 2023
Merged
@cshaley
Copy link
Contributor Author

cshaley commented Dec 8, 2023

Of course! Happy to contribute. See #149 to see if that gets it done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhamail bhamail bhamail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cshaley @bhamail