handle IQ policy Warning. #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarthHater
reviewed
Sep 22, 2020
DarthHater
reviewed
Sep 22, 2020
Makefile
Outdated
| @@ -43,8 +43,14 @@ test: build | |||
| $(GOTEST) -v ./... 2>&1 | |||
|
|
|||
| integration-test: build | |||
| # temporary workaround, remove next line when x/net false positive is fixed | |||
| echo 'CVE-2018-17142\nCVE-2018-17846\nCVE-2018-17143\nCVE-2018-17847\nCVE-2018-17848' > packages/testdata/.nancy-ignore | |||
There was a problem hiding this comment.
I would add a CVN-111 until=2021-01-01 type thing to this, so they are only ever ignored for like a week or two. We really don't want to have these ignored forever if they become applicable.
DarthHater
requested changes
Sep 22, 2020
DarthHater
approved these changes
Sep 22, 2020
zendern
pushed a commit
to zendern/nancy
that referenced
this pull request
Apr 16, 2021
* handle IQ policy Warning. * workaround x/net false positive
zendern
pushed a commit
to zendern/nancy
that referenced
this pull request
Mar 7, 2022
* handle IQ policy Warning. * workaround x/net false positive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print a message with a hint about policy Warnings from IQ.
Discovered while setting up IQ dog-fooding
cc @bhamail / @DarthHater