Fix parsing of CLI flags when using stdIn invocation. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zendern you mind taking a gander here? The config stuff was largely your ball court, I think you'll have the best eye! |
|
@bhamail @DarthHater Found it and my bad!! 😢 Apparently this does no assertion. Working on trying to switch it over to an method that does an assert but having issues with the logurus formatters since they are pointers. |
|
Now you should see a failing test for the standard in and quiet scenario in 38f8e29. Had to fiddle all the formatters. |
|
Excellent. I'm off and running again. Thanks @zendern ! |
bhamail
changed the title
zendern
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support passing in CLI flags when invoking Nancy using the standard-input pipe approach.
e.g.
Fixes Issue #88
cc @bhamail / @DarthHater