This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
Some improvements to the core NX.* js bits #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use NX.isobj to determine if we need to requireSuper. Add $className to defined class types. Throw meaningful exception in NX.obj() when object is not defined
Add NX.log.forceDebug to allow flipping on debug logging w/o the ?debug flag, which is causing me problems atm (and is really slow)
Add <Class>.$log helper.
| } | ||
|
|
||
| getLogger().debug("Subject '{}' is missing required permissions; rejecting", subject.getPrincipal()); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Eh, not JS related but snuck into the pull... I'll weed it out.
Add to requiredClasses instead of requiredModules where possible. Sanity check required classes exists.
Add LogAwareMixin class. Add more detail to why strings.js exists.
….toString. Use array syntax for NX.log.debug so we get better formatting of array data in the console (though better is in the eye of the beholder). Minor updates to NX.log
Add more features to LogAwareMixin, can now show/hide the name show/hide level, and supports passing argument back to NX.log.*
Sanity check levels based on NX.log.levels configuration. Require at least one user argument to log.
Use NX.assert Clean up logging.
Moved $log support into LegacyLogMixin
Add more jsdoc muck.
|
+1 |
…eady defined icon /w <name> under new name (instead of making a new one).
jdillon
added a commit
that referenced
this pull request
Feb 14, 2013
Some improvements to the core NX.* js bits
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for mixins.
Fixes issue with NX.define in a complex hierarchy.
Class and class prototype are now $className and $simpleClassName aware.
Objects get a slightly better toString()
Re-implemented NX.log, has better control over how levels are filtered.
Added LogAwareMixin which provides log{Debug|Warn|Info|Error} functions to objects to replace the $log usage.
LogAwareMixin has some runtime control over the format includeName, includeLevel, simpleName, etc.