-
Notifications
You must be signed in to change notification settings - Fork 0
INTC-109 Post a zipped file of the supplied GitHub Action files to the NVS Cloud Scanner #2
Conversation
package.json
Outdated
"author": "Sonatype", | ||
"license": "Copyright (c) 2019-present Sonatype, Inc", | ||
"dependencies": { | ||
"@actions/core": "^1.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use fixed versions as before in azure plugin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to add a link to github "Actions" instead of Jenkins build for this project?
zip files part of INTC-109
…that they are evaluatable (#5)
…-files-to-the-nvs-cloud-scanner' of github.com:sonatype/nvs-github-actions into intc-109-post-zipped-file-of-the-supplied-github-action-files-to-the-nvs-cloud-scanner
…-supplied-github-action-files-to-the-nvs-cloud-scanner' into intc-109-post-zipped-file-of-the-supplied-github-action-files-to-the-nvs-cloud-scanner
…-files-to-the-nvs-cloud-scanner' of github.com:sonatype/nvs-github-actions into intc-109-post-zipped-file-of-the-supplied-github-action-files-to-the-nvs-cloud-scanner
…-supplied-github-action-files-to-the-nvs-cloud-scanner' into intc-109-post-zipped-file-of-the-supplied-github-action-files-to-the-nvs-cloud-scanner
@@ -0,0 +1,38 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can a license header be added here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
private static readonly ASCII64 = './0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz'; | ||
private static readonly CHRSZ = 8; | ||
|
||
static guid() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the orignal source of this hash function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is one of the internal repo in sonatype, will send you in slack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
GitHub Cloud Scanner extension
Links
JIRA:
Build:
Screencast
N/A