Skip to content
This repository has been archived by the owner on Jan 11, 2020. It is now read-only.

INTC-109 Post a zipped file of the supplied GitHub Action files to the NVS Cloud Scanner #2

Conversation

Mykyta
Copy link
Contributor

@Mykyta Mykyta commented Oct 30, 2019

package.json Outdated
"author": "Sonatype",
"license": "Copyright (c) 2019-present Sonatype, Inc",
"dependencies": {
"@actions/core": "^1.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use fixed versions as before in azure plugin?

Copy link
Contributor

@parkhomenko parkhomenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to add a link to github "Actions" instead of Jenkins build for this project?

Mykyta and others added 12 commits October 31, 2019 16:42
…-files-to-the-nvs-cloud-scanner' of github.com:sonatype/nvs-github-actions into intc-109-post-zipped-file-of-the-supplied-github-action-files-to-the-nvs-cloud-scanner
…-supplied-github-action-files-to-the-nvs-cloud-scanner' into intc-109-post-zipped-file-of-the-supplied-github-action-files-to-the-nvs-cloud-scanner
…-files-to-the-nvs-cloud-scanner' of github.com:sonatype/nvs-github-actions into intc-109-post-zipped-file-of-the-supplied-github-action-files-to-the-nvs-cloud-scanner
…-supplied-github-action-files-to-the-nvs-cloud-scanner' into intc-109-post-zipped-file-of-the-supplied-github-action-files-to-the-nvs-cloud-scanner
@@ -0,0 +1,38 @@

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can a license header be added here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

private static readonly ASCII64 = './0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz';
private static readonly CHRSZ = 8;

static guid() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the orignal source of this hash function?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is one of the internal repo in sonatype, will send you in slack

@parkhomenko parkhomenko changed the base branch from master to develop November 4, 2019 19:01
Copy link

@fernau fernau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mykyta Mykyta merged commit a1cf54b into develop Nov 5, 2019
@Mykyta Mykyta deleted the intc-109-post-zipped-file-of-the-supplied-github-action-files-to-the-nvs-cloud-scanner branch November 5, 2019 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants