Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dot files supported by jekyll not supported in generator config #141

Closed
placenamehere opened this issue Jul 8, 2016 · 10 comments
Closed

Comments

@placenamehere
Copy link

While the jekyll default config has support for some dot files (such as .htaccess) they were not being moved from src to tmp on the copy steps that precede the jekyll processing, so any build or deploy I was doing was not inclusive of these files.

Locally, I fixed this by adding ,{dot: true} to the appropriate gulp.src() calls in my gulpfile.js.

@placenamehere
Copy link
Author

digging into how gulpfile.js is being generated it looks like the fix would be needed to both the move to tmp task in generator-jekyllized as well as the deploy task which is inherited from generator-statisk:

https://github.com/sondr3/generator-jekyllized/blob/master/generators/jekyll/templates/build.js#L10
https://github.com/sondr3/generator-statisk/blob/master/generators/gulp/templates/tasks/uploading.js#L50

@sondr3
Copy link
Owner

sondr3 commented Jul 11, 2016

Thanks! Didn't think about this as I don't use Apache or anything requiring dotfiles, I'll fix this one as well as soon as I can!

sondr3 added a commit that referenced this issue Jul 28, 2016
@sondr3
Copy link
Owner

sondr3 commented Jul 28, 2016

Okay, so I'm fixing this one right now but do we need to add support for dotfiles to both GitHub Pages and Amazon AWS? As far as I know neither of those have any files that are dotfiles, whereas for rsync you might need them for Apache and such. Any feedback?

sondr3 added a commit to sondr3/generator-statisk that referenced this issue Jul 28, 2016
@placenamehere
Copy link
Author

I tend to always lean towards predictability -- if part of the process copies files into a staging location (dist) I'd expect the second half of the process to always be configured to work against all those files.

Yes, probably not needed for github or aws (that I know of) but if a developer using this has one in their project it should probably be deployed (and then ignored by the 'server')

I'd say that because this choice/config is buried in a dependent package I'd also lean towards being more accepting in that package by default.

@sondr3
Copy link
Owner

sondr3 commented Jul 28, 2016

Alright, sounds good to me, I'll update them and push a new version pretty soon.

@sondr3
Copy link
Owner

sondr3 commented Jul 28, 2016

And done! I accidentally tagged the wrong commit so I'll have to close it myself, I'll create a new release of both generators ASAP.

@sondr3 sondr3 closed this as completed Jul 28, 2016
@sackwort
Copy link

My .htaccess file is not being copied into 'dist' when I run 'gulp build'. I'm using latest RC. I've also tried adding as an include in _config.

@sondr3
Copy link
Owner

sondr3 commented Aug 16, 2016

Crap, I can see why, when updating your app it only looks at what has changed from generator-statisk and not from this generator, I'll fix this as soon as I can, but it might take a few days, in the mean time the second comment here includes a fix.

@sackwort
Copy link

There's no rush. Thanks for your great work.

sondr3 added a commit that referenced this issue Aug 23, 2016
Now it will correctly update all the gulp task files and not just the ones used
in `generator-statisk`. Also fixed a small issue with a typo in a test.

Should be the final fix needed for #141. Closes #141.
@sondr3
Copy link
Owner

sondr3 commented Aug 23, 2016

I just pushed a new version to Github, you can update to it with npm install -g generator-jekyllized and then run yo jekyllized:update in your project root folder so it correctly updates all your gulp tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants