Add ST route type #308
Add ST route type #308
Conversation
Signed-off-by: Marian Pritsak <marianp@mellanox.com>
marian-pritsak
force-pushed
the
service_tunnel
branch
from
6c767b6
to
a54cbe7
Compare
|
TODO: generate SAI API |
|
SAI API will be generated into master branch, pending opencomputeproject/SAI#1590 |
|
@marian-pritsak , does it match this #309 ? |
Signed-off-by: Marian Pritsak <marianp@mellanox.com>
Signed-off-by: Marian Pritsak <marianp@mellanox.com>
Yes it does |
|
Companion SAI API change opencomputeproject/SAI#1729 |
Signed-off-by: Marian Pritsak <marianp@mellanox.com>
| /* encapsulation will be done in apply block based on encap_type */ | ||
| meta.encap_data.underlay_dip = underlay_dip == 0 ? meta.encap_data.original_overlay_dip : (IPv4Address)underlay_dip; | ||
| meta.encap_data.underlay_sip = underlay_sip == 0 ? meta.encap_data.original_overlay_sip : (IPv4Address)underlay_sip; | ||
| meta.encap_data.overlay_dmac = hdr.ethernet.dst_addr; |
There was a problem hiding this comment.
Current assumption is to use original's packet dmac.
There was a problem hiding this comment.
Yes - it is copying the same value from original header
dash-pipeline/bmv2/dash_outbound.p4
Outdated
| meta.encap_data.underlay_dip, | ||
| meta.encap_data.underlay_sip, | ||
| meta.encap_data.overlay_dmac, | ||
| meta.encap_data.service_tunnel_id); |
There was a problem hiding this comment.
can we rename to encap_key?
Signed-off-by: Marian Pritsak <marianp@mellanox.com>
|
@marian-pritsak with 2c2531b it seems like we're going further down the path to complex special-case code in sai_api_gen.py. Is there anyway to use P4Info in the codegen to handle the enums, and therefore take a step in that direction? |
Signed-off-by: Marian Pritsak <marianp@mellanox.com>
I have SAI generation moving to annotations in P4 in my backlog |
| in IPv6Address st_dst, | ||
| in IPv6Address st_dst_mask, | ||
| in IPv6Address st_src, | ||
| in IPv6Address st_src_mask) { | ||
| hdr.ipv6.setValid(); | ||
| hdr.ipv6.version = 6; | ||
| hdr.ipv6.traffic_class = 0; |
dash-pipeline/bmv2/dash_conntrack.p4
Outdated
| @@ -46,12 +49,16 @@ control ConntrackIn(inout headers_t hdr, | |||
| } | |||
| restart_expire_timer(); // reset expiration timer for entry | |||
| meta.conntrack_data.allow_in = true; | |||
| meta.encap_data.original_overly_sip = original_overly_sip.read(get_rule_prio(); | |||
| meta.encap_data.original_overly_dip = original_overly_dip.read(get_rule_prio(); | |||
There was a problem hiding this comment.
Compilation error - missing parenthesis.
|
@marian-pritsak , could you please resolve conflict? |
|
@prsunny fixed the conflicts |
Signed-off-by: Marian Pritsak marianp@mellanox.com