Add Private Link mapping

[marian-pritsak]

Signed-off-by: Marian Pritsak marianp@mellanox.com

[marian-pritsak]

Pending NVGRE from #308

[marian-pritsak]

Should be unchanged

[prsunny]

@marian-pritsak , could you please check the build failure?

[chrispsommers]

@marian-pritsak , could you please check the build failure?

Probably the new table attributes for ENI P4 code require them to be set in any test case calling sai_create_eni(). If you look at the P4 code in the PR, some action parameters were added, e.g. see https://github.com/sonic-net/DASH/blob/fa7b1496912b54743d5c85e034924b5b08c53c37/dash-pipeline/bmv2/dash_pipeline.p4#LL116C1-L118C54

                         IPv6Address pl_sip,
                         IPv6Address pl_sip_mask,
                         IPv4Address pl_underlay_sip,

The c++ libsai test case calls sai_create_eni() but it wasn't updated to add the new parameters, yet the library enforces the number of parameters.

DASH/dash-pipeline/tests/libsai/vnet_out/vnet_out.cpp

Line 172 in 778eb99

status = sai_create_eni(&eni_id, switch_id, attrs.size(), attrs.data());

[marian-pritsak]

@chrispsommers where is this test that's failing? I can't find it in the tests directory.

+ ptf --test-dir ./functional/ptf --pypath /SAI/ptf --interface 0@veth1 --interface 1@veth3 --test-case-timeout=1800 '--test-params=connection='\''tcp'\'';target='\''bmv2'\'';traffic_check='\''bidir'\'';'
/usr/local/lib/python3.8/dist-packages/ptf-0.9.3-py3.8.egg/EGG-INFO/scripts/ptf:19: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
  import imp
saidashacl.SaiThriftDashAclTest ... FAIL

======================================================================
FAIL: saidashacl.SaiThriftDashAclTest
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./functional/ptf/saidashacl.py", line 344, in setUp
    raise ae
  File "./functional/ptf/saidashacl.py", line 3[40](https://github.com/sonic-net/DASH/actions/runs/5548748391/jobs/10132077510?pr=327#step:17:41), in setUp
    self.setUpSwitch()
  File "./functional/ptf/saidashacl.py", line 205, in setUpSwitch
    self.eni = self.create_obj(sai_thrift_create_eni, sai_thrift_remove_eni, cps=10000,
  File "./functional/ptf/saidashacl.py", line 1[43](https://github.com/sonic-net/DASH/actions/runs/5548748391/jobs/10132077510?pr=327#step:17:44), in create_obj
    assert (obj != SAI_NULL_OBJECT_ID)
AssertionError

----------------------------------------------------------------------
Ran 1 test in 100.189s

FAILED (failures=1)
saidasheni.CreateDeleteEniTest ... ERROR

[chrispsommers]

@marian-pritsak I see you found the test case

[marian-pritsak]

@marian-pritsak I see you found the test case

Yes, I forgot there are two locations.

[marian-pritsak]

SAI PR opencomputeproject/SAI#1907

[chrispsommers]

@marian-pritsak do you want to request review of this and move forward?

[KrisNey-MSFT]

Notes from 9/27/2023 DASH Community Call.
We seem to have a clean CI run, and PR1907 in the SAI repo (for SAI repo headers, with contents of PL objects).
Checking to see if this is now on hold, or need a review (see Chris' comment above).
Just making extended comments for the next call.

[KrisNey-MSFT]

Adding Prince & Riff to review