Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design doc for portable console switch for multiple vendors #1012

Merged

Conversation

lizhijianrd
Copy link
Contributor

In this design document, we provide the standard for adapting console devices to SONiC. If a vendor's console device implementation conforms to this standard, it will work on any switch with SONiC installed.

@zhangyanzhao
Copy link
Collaborator

zhangyanzhao commented Nov 8, 2022

@lizhijianrd several things need be updated:

  1. Please define YANG table for the new config_DB table
  2. Please add the new CLIs to https://github.com/sonic-net/sonic-utilities/blob/master/doc/Command-Reference.md
  3. Please add the code PRs into this HLD by referring to PR#806
  4. Please make sure to have the UT defined

"""
Retrieves the infomation of all console lines on portable console devices.

:return: A dict, the key is console line number (integer, same as portable console device designed),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you daisy-chain 2 same console devices, and this model have 8ports. How the port name of 2nd console devices aligned with physical port name?

@lizhijianrd
Copy link
Contributor Author

@lizhijianrd several things need be updated:

  1. Please define YANG table for the new config_DB table
  2. Please add the new CLIs to https://github.com/sonic-net/sonic-utilities/blob/master/doc/Command-Reference.md
  3. Please add the code PRs into this HLD by referring to PR#806
  4. Please make sure to have the UT defined

Thanks @zhangyanzhao! Currently we are still in the design phase, so I'll update these points when I begin to implementation.

@lizhijianrd lizhijianrd merged commit cabaceb into sonic-net:master Dec 15, 2022
@lizhijianrd lizhijianrd deleted the portable_console_switch_design branch October 31, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants