Create ACL table fails due to incorrect check for supported ACL actions

[rck-innovium]

The recent change to add mandatory ACL actions has a bug when checking whether the ACL action is supported or not.

Steps to reproduce:

CLI:
config acl add table DATA_EGRESS_IPV4_TEST L3 -s egress

Error:
Jun 23 02:23:09.467384 sonic-dut ERR swss#orchagent: :- validate: Action SAI_ACL_ACTION_TYPE_REDIRECT is not supported on table DATA_EGRESS_IPV4_TEST
Jun 23 02:23:09.467384 sonic-dut ERR swss#orchagent: :- doAclTableTask: Failed to create ACL table DATA_EGRESS_IPV4_TEST, invalid configuration

Root-cause:

Refer: https://github.com/Azure/sonic-swss/blob/ec57bf101651b838156780b93d3300bf16bb7f74/orchagent/aclorch.cpp#L2048

The code is wrongly checking counter_action instead of checking each of the actions in defaultAclActionList.

The right fix is:

diff --git a/orchagent/aclorch.cpp b/orchagent/aclorch.cpp
index c865a7f..9c47b6e 100644
--- a/orchagent/aclorch.cpp
+++ b/orchagent/aclorch.cpp
@@ -2016,7 +2016,7 @@ bool AclTable::addMandatoryActions()
         // Add the default action list
         for (auto action : defaultAclActionList[type.getName()][stage])
         {
-            if (m_pAclOrch->isAclActionSupported(stage, acl_action))
+            if (m_pAclOrch->isAclActionSupported(stage, action))
             {
                 SWSS_LOG_INFO("Added default action for table type %s stage %s",
                                     type.getName().c_str(),

Version

SONiC Software Version: SONiC.202111.Innovium.0-dirty-20220602.094004
Distribution: Debian 11.3
Kernel: 5.10.0-8-2-amd64
Build commit: ca284a1
Build date: Thu Jun 2 18:08:13 UTC 2022
Built by: builder@sonic-xxx
Platform: x86_64-wistron_sw_to3200k-r0
HwSKU: Wistron_sw_to3200k_32x100
ASIC: innovium
ASIC Count: 1
Serial Number: N/A
Model Number: N/A
Hardware Revision: N/A
Uptime: 10:40:32 up 10:26, 2 users, load average: 0.76, 0.55, 0.65