[multi-asic] ERR python3: :- initializeGlobalConfig: SonicDBConfig Global config is already initialized

[abdosi]

Issue:
Run any show command on mutli-asic-platform and we see this message getting printed for each asic.

ERR python3: :- initializeGlobalConfig: SonicDBConfig Global config is already initialized

On debugging looks like swsscommon.SonicDBConfig.isGlobalInit is always false and thus we see the message.
However same logic works fine for single asic where swsscommon.SonicDBConfig.isInit() return True.

def load_db_config():
    '''
    Load the correct database config file:
     - database_global.json for multi asic
     - database_config.json for single asic
    '''
    if is_multi_asic():
        if not swsscommon.SonicDBConfig.isGlobalInit():
            swsscommon.SonicDBConfig.load_sonic_global_db_config()
    else:
        if not swsscommon.SonicDBConfig.isInit():
            swsscommon.SonicDBConfig.load_sonic_db_config()

Because of this ERR message we see failure when sonic-mgmt test case is run with log-analyzer enable.

[abdosi]

@SuvarnaMeenakshi please follow up on this.

@arlakshm and @judyjoseph for viz.

[abdosi]

cc @anamehra for viz.

[deepak-singhal0408]

The Error Message comes when SonicDBConfig::initializeGlobalConfig gets called and GlobalConfig is already initialized.

The above gets invoked from load_db_config.

For "show interface status" on a multi-asic Card, load_db_config gets called multiple times(4 times on a 2-asic linecard)
First at the entrypoint of show command. sonic-utilities/show/main.py
Second during creation of IntfStatus Object: sonic-utilities/scripts/intfutil
Next 2 are called from get_port_config() :(once for each asic), which again tries to invoke GlobalConfigInit.

In this case, for first 2 iteration, we do check if its already initilaized, but the get_port_config() doesnt check this.

There are other places as well in the code, where we call the aboveAPI without checking if already initialized.

This message is harmless. If the Config is already initilaized, it just returns and if not, it initializes it. Hence, Instead of adding validation at multiple places, will remove the error message.