Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker dhcp build failed. #1669

Closed
jeromesun14 opened this issue May 2, 2018 · 6 comments · Fixed by #1666
Closed

docker dhcp build failed. #1669

jeromesun14 opened this issue May 2, 2018 · 6 comments · Fixed by #1666
Labels
Question ❓

Comments

@jeromesun14
Copy link
Contributor

jeromesun14 commented May 2, 2018 •
edited
Loading

Description

docker-dhcp-relay build failed.

Steps to reproduce the issue:

  1. make target/sonic-broadcom.bin

Describe the results you received:
docker image build failed.

Describe the results you expected:

docker image build successfully.

Additional information you deem important (e.g. issue happens only occasionally):

**Output of `show version`:**

branch 201803, commit id 8572f84ea0f6054f1c0440511db6501d6f465cfd

**Attach debug file `sudo generate_dump`:**

Fetched 19.5 MB in 4s (4643 kB/s)
Reading package lists...
 ---> caaea7089f2d
Removing intermediate container 733d5b53e400
Step 4/12 : COPY debs/isc-dhcp-common_4.3.3-6_amd64.deb debs/
 ---> c04c819133ba
Removing intermediate container 53842895daae
Step 5/12 : COPY debs/isc-dhcp-relay_4.3.3-6_amd64.deb debs/
 ---> 013b381c2ffa
Removing intermediate container 8c684f9c9e07
Step 6/12 : RUN dpkg_apt() { [ -f $1 ] && { dpkg -i $1 || apt-get -y install -f; } || return 1; }; dpkg_apt debs/isc-dhcp-common_4.3.3-6_amd64.deb
 ---> Running in d3e4f7a09ac2
(Reading database ... 14581 files and directories currently installed.)
Preparing to unpack .../isc-dhcp-common_4.3.3-6_amd64.deb ...
Unpacking isc-dhcp-common (4.3.3-6) over (4.3.1-6+deb8u3) ...
Setting up isc-dhcp-common (4.3.3-6) ...
 ---> 86452f7b49f4
Removing intermediate container d3e4f7a09ac2
Step 7/12 : RUN dpkg_apt() { [ -f $1 ] && { dpkg -i $1 || apt-get -y install -f; } || return 1; }; dpkg_apt debs/isc-dhcp-relay_4.3.3-6_amd64.deb
 ---> Running in a90fc03b05ca
Selecting previously unselected package isc-dhcp-relay.
(Reading database ... 14581 files and directories currently installed.)
Preparing to unpack .../isc-dhcp-relay_4.3.3-6_amd64.deb ...
Unpacking isc-dhcp-relay (4.3.3-6) ...
Setting up isc-dhcp-relay (4.3.3-6) ...
Generating /etc/default/isc-dhcp-relay...
invoke-rc.d: policy-rc.d denied execution of start.
Processing triggers for systemd (215-17+deb8u7) ...
 ---> d874498b6bf3
Removing intermediate container a90fc03b05ca
Step 8/12 : RUN apt-get clean -y; apt-get autoclean -y; apt-get autoremove -y
 ---> Running in beede5550618
Reading package lists...
Building dependency tree...
Reading state information...
Reading package lists...
Building dependency tree...
Reading state information...
You might want to run 'apt-get -f install' to correct these.
The following packages have unmet dependencies:
 isc-dhcp-client : Depends: isc-dhcp-common (= 4.3.1-6+deb8u3) but 4.3.3-6 is installed
E: Unmet dependencies. Try using -f.
The command '/bin/sh -c apt-get clean -y; apt-get autoclean -y; apt-get autoremove -y' returned a non-zero code: 100
[  FAIL LOG END  ] [ target/docker-dhcp-relay.gz ]
slave.mk:377: recipe for target 'target/docker-dhcp-relay.gz' failed
make: *** [target/docker-dhcp-relay.gz] Error 1
make: *** Waiting for unfinished jobs....
Makefile:82: recipe for target 'target/sonic-broadcom.bin' failed
make: *** [target/sonic-broadcom.bin] Error 2
@jeromesun14
Copy link
Contributor Author

Why not using isc-dhcp-client from compile output debian package?

@fgggid
Copy link

fgggid commented May 2, 2018

see #1659

@yangbashuang
Copy link
Contributor

maybe same as below:
#1659
#1666

@jeromesun14
Copy link
Contributor Author

jeromesun14 commented May 2, 2018 •
edited
Loading

@yangbashuang @fgggid Thanks!

I have searched issue with "dhcp docker" before commit the new one. But no issues found. It's a pitty that issues search engine are not related to PR.

@jeromesun14
Copy link
Contributor Author

#1659 has a new issue.

There's a mistake in rules/isc-dhcp.mk。

error log

$ cat target/debs/isc-dhcp-client_4.3.3-6_amd64.deb.log 
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
make[1]: Entering directory '/sonic/src/isc-dhcp'
# Remove any stale files
rm -rf ./isc-dhcp
# Clone isc-dhcp repo
git clone https://anonscm.debian.org/cgit/pkg-dhcp/isc-dhcp.git
pushd ./isc-dhcp
# Reset HEAD to the commit of the proper tag
# NOTE: Using "git checkout <tag_name>" here detaches our HEAD,
# which stg doesn't like, so we use this method instead
git reset --hard debian/4.3.3-6
# Apply patches
stg init
stg import -s ../patch/series
# Build source and Debian packages
dpkg-buildpackage -rfakeroot -b -us -uc -j24
popd
# Move the newly-built .deb packages to the destination directory
mv isc-dhcp-common_4.3.3-6_amd64.deb isc-dhcp-relay_4.3.3-6_amd64.deb isc-dhcp-client_4.3.3-6_amd64.deb /sonic/target/debs/
Cloning into 'isc-dhcp'...
warning: Duplicated ref: refs/remotes/origin/experimental
warning: Duplicated ref: refs/remotes/origin/master
warning: Duplicated ref: refs/remotes/origin/pristine-tar
warning: Duplicated ref: refs/remotes/origin/upstream
warning: Duplicated ref: refs/tags/debian/4.1.0-1
warning: Duplicated ref: refs/tags/debian/4.1.1-1
warning: Duplicated ref: refs/tags/debian/4.1.1-2
warning: Duplicated ref: refs/tags/debian/4.1.1-P1-10
warning: Duplicated ref: refs/tags/debian/4.1.1-P1-11
warning: Duplicated ref: refs/tags/debian/4.1.1-P1-12
warning: Duplicated ref: refs/tags/debian/4.1.1-P1-13
warning: Duplicated ref: refs/tags/debian/4.1.1-P1-14
warning: Duplicated ref: refs/tags/debian/4.1.1-P1-15
warning: Duplicated ref: refs/tags/debian/4.1.1-P1-16
warning: Duplicated ref: refs/tags/debian/4.1.1-P1-16.1
warning: Duplicated ref: refs/tags/debian/4.1.1-P1-17
warning: Duplicated ref: refs/tags/debian/4.1.1-P1-4
warning: Duplicated ref: refs/tags/debian/4.1.1-P1-5
warning: Duplicated ref: refs/tags/debian/4.1.1-P1-6
warning: Duplicated ref: refs/tags/debian/4.1.1-P1-7
warning: Duplicated ref: refs/tags/debian/4.1.1-P1-8
warning: Duplicated ref: refs/tags/debian/4.1.1-P1-9
warning: Duplicated ref: refs/tags/debian/4.2.2-1
warning: Duplicated ref: refs/tags/debian/4.2.2-2
warning: Duplicated ref: refs/tags/debian/4.2.2.dfsg.1-3
warning: Duplicated ref: refs/tags/debian/4.2.2.dfsg.1-4
warning: Duplicated ref: refs/tags/debian/4.2.2.dfsg.1-5
warning: Duplicated ref: refs/tags/debian/4.2.4-1
warning: Duplicated ref: refs/tags/debian/4.2.4-2
warning: Duplicated ref: refs/tags/debian/4.2.4-3
warning: Duplicated ref: refs/tags/debian/4.2.4-4
warning: Duplicated ref: refs/tags/debian/4.2.4-5
warning: Duplicated ref: refs/tags/debian/4.2.4-6
warning: Duplicated ref: refs/tags/debian/4.2.4-7
warning: Duplicated ref: refs/tags/debian/4.3.0+dfsg-1
warning: Duplicated ref: refs/tags/debian/4.3.0+dfsg-2
warning: Duplicated ref: refs/tags/debian/4.3.0a1-1
warning: Duplicated ref: refs/tags/debian/4.3.0a1-2
warning: Duplicated ref: refs/tags/debian/4.3.1-1
warning: Duplicated ref: refs/tags/debian/4.3.1-2
warning: Duplicated ref: refs/tags/debian/4.3.1-3
warning: Duplicated ref: refs/tags/debian/4.3.1-4
warning: Duplicated ref: refs/tags/debian/4.3.1-5
warning: Duplicated ref: refs/tags/debian/4.3.1-6
warning: Duplicated ref: refs/tags/debian/4.3.1_b1
warning: Duplicated ref: refs/tags/debian/4.3.2-1
warning: Duplicated ref: refs/tags/debian/4.3.3-1
warning: Duplicated ref: refs/tags/debian/4.3.3-2
warning: Duplicated ref: refs/tags/debian/4.3.3-3
warning: Duplicated ref: refs/tags/debian/4.3.3-5
warning: Duplicated ref: refs/tags/debian/4.3.3-6
warning: Duplicated ref: refs/tags/debian/4.3.3-7
warning: Duplicated ref: refs/tags/debian/4.3.3-8
warning: Duplicated ref: refs/tags/debian/4.3.3-9
warning: Duplicated ref: refs/tags/debian/4.3.4-1
warning: Duplicated ref: refs/tags/debian/4.3.5-1
warning: Duplicated ref: refs/tags/debian/4.3.5-2
warning: Duplicated ref: refs/tags/debian/4.3.5-3
warning: Duplicated ref: refs/tags/debian/4.3.5_b1-1
warning: Duplicated ref: refs/tags/debin/4.2.2.dfsg.1-4
warning: Duplicated ref: refs/tags/upstream/4.1.0
warning: Duplicated ref: refs/tags/upstream/4.1.1
warning: Duplicated ref: refs/tags/upstream/4.1.1-P1
warning: Duplicated ref: refs/tags/upstream/4.2.2
warning: Duplicated ref: refs/tags/upstream/4.2.4
warning: Duplicated ref: refs/tags/upstream/4.2.5-P1
warning: Duplicated ref: refs/tags/upstream/4.3.0
warning: Duplicated ref: refs/tags/upstream/4.3.0a1
warning: Duplicated ref: refs/tags/upstream/4.3.1
warning: Duplicated ref: refs/tags/upstream/4.3.2
warning: Duplicated ref: refs/tags/upstream/4.3.3
warning: Duplicated ref: refs/tags/upstream/4.3.4
warning: Duplicated ref: refs/tags/upstream/4.3.4_b1
warning: Duplicated ref: refs/tags/upstream/4.3.5
warning: Duplicated ref: refs/tags/upstream/4.3.5_b1
error: Untracked working tree file 'LICENSE' would be overwritten by merge.
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry the checkout with 'git checkout -f HEAD'

Makefile:10: recipe for target '/sonic/target/debs/isc-dhcp-common_4.3.3-6_amd64.deb' failed
make[1]: *** [/sonic/target/debs/isc-dhcp-common_4.3.3-6_amd64.deb] Error 128
make[1]: Leaving directory '/sonic/src/isc-dhcp'

error reason

ISC_DHCP_COMMON and ISC_DHCP_CLIENT are added to SONIC_MAKE_DEBS. However ISC_DHCP_CLIENT must be a derived package, and we cannot run src/isc-dhcp/Makefile twice.

# isc-dhcp packages

ISC_DHCP_VERSION = 4.3.3-6

export ISC_DHCP_VERSION

ISC_DHCP_COMMON = isc-dhcp-common_$(ISC_DHCP_VERSION)_amd64.deb
$(ISC_DHCP_COMMON)_SRC_PATH = $(SRC_PATH)/isc-dhcp
SONIC_MAKE_DEBS += $(ISC_DHCP_COMMON)

ISC_DHCP_CLIENT = isc-dhcp-client_$(ISC_DHCP_VERSION)_amd64.deb
$(ISC_DHCP_CLIENT)_SRC_PATH = $(SRC_PATH)/isc-dhcp
SONIC_MAKE_DEBS += $(ISC_DHCP_CLIENT)

ISC_DHCP_RELAY = isc-dhcp-relay_$(ISC_DHCP_VERSION)_amd64.deb
$(eval $(call add_derived_package,$(ISC_DHCP_COMMON),$(ISC_DHCP_RELAY),$(ISC_DHCP_CLIENT)))

Solution

patch:

From 8e06f1a3082c3adb20e39e334301d1d32463ffd5 Mon Sep 17 00:00:00 2001
From: jeromesun <jeromesun@tencent.com>
Date: Wed, 2 May 2018 15:26:39 +0800
Subject: [PATCH] [ISC-DHCP] fix isc-dhcp-client compile issue

---
 rules/isc-dhcp.mk | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/rules/isc-dhcp.mk b/rules/isc-dhcp.mk
index 37c775d..a8d684f 100644
--- a/rules/isc-dhcp.mk
+++ b/rules/isc-dhcp.mk
@@ -9,8 +9,9 @@ $(ISC_DHCP_COMMON)_SRC_PATH = $(SRC_PATH)/isc-dhcp
 SONIC_MAKE_DEBS += $(ISC_DHCP_COMMON)
 
 ISC_DHCP_CLIENT = isc-dhcp-client_$(ISC_DHCP_VERSION)_amd64.deb
-$(ISC_DHCP_CLIENT)_SRC_PATH = $(SRC_PATH)/isc-dhcp
-SONIC_MAKE_DEBS += $(ISC_DHCP_CLIENT)
+#$(ISC_DHCP_CLIENT)_SRC_PATH = $(SRC_PATH)/isc-dhcp
+#SONIC_MAKE_DEBS += $(ISC_DHCP_CLIENT)
+$(eval $(call add_derived_package,$(ISC_DHCP_COMMON),$(ISC_DHCP_CLIENT)))
 
 ISC_DHCP_RELAY = isc-dhcp-relay_$(ISC_DHCP_VERSION)_amd64.deb
-$(eval $(call add_derived_package,$(ISC_DHCP_COMMON),$(ISC_DHCP_RELAY),$(ISC_DHCP_CLIENT)))
+$(eval $(call add_derived_package,$(ISC_DHCP_COMMON),$(ISC_DHCP_RELAY)))
-- 
2.7.4

@jleveque jleveque mentioned this issue May 2, 2018
Merged
@jleveque
Copy link
Contributor

jleveque commented May 2, 2018 •
edited
Loading

@sunnogo: I encountered the same error you posted above. This led me to track down the root cause which I have fixed in #1666.

After we merge that PR, I will immediately revert #1659, and this will no longer be an issue.

@jleveque jleveque mentioned this issue Mar 22, 2021
Merged
jleveque added a commit that referenced this issue Mar 26, 2021
@jleveque
[sonic-sairedis][sonic-swss] Update submodules (#7089)
bf43dd3 
Update sonic-sairedis submodule and also update sonic-swss submodule as there are interdependent changes.

* src/sonic-sairedis 13474d1...bc58b0f (12):
  > Add gbsyncdmgrd; deprecate gbsyncd_startup.py (#809)
  > Remove gbsyncd_start.sh (#808)
  > [gbsyncd] Fix shebang in gbsyncd_startup.py; Make script executable (#807)
  > [saiasiccmp] Add saiasiccmp tool to compare 2 asic views (#791)
  > [configure] Add -Wno-psabi to remove "passing argument changed in GCC 7.1" (#799)
  > Update FlexCounter.cpp, use m_pollInterval in MUTEX lock (#797)
  > [vs] Add special warm boot logic to populate default attributes (#796)
  > [ci]: add vstest (#795)
  > [tests] Add macsec unittest (#782)
  > [debian/control] libsairedis-dev depends on libzmq5-dev (#794)
  > [ci]: use build template (#793)
  > Rename duplicate file name (#773)

* src/sonic-swss 0b0d24c...5adb73e (47):
  > Initialize system port type variable (#1681)
  > [Dynamic Buffer Calc] Enhance the field checking in table handling (#1680)
  > Handle the clear request for 'Q_SHARED_ALL' (#1653)
  > [MuxOrch] FDB ageout safety check (#1674)
  > Deactivate mirror session only when session status is true in updateLagMember (#1666)
  > Revert "[buffermgr] Support maximum port headroom checking (#1607)" (#1675)
  > reduce severity of log to info in case of flush on non-existing member (#1669)
  > Revert "[Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (#1652)" (#1676)
  > [Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (#1652)
  > [acl] Move ACL table constants to acltable.h (#1671)
  > [nbrmgrd] added function to parse IP address from APP_DB (#1672)
  > [MUX/PFCWD] Use in_ports for acls instead of seperate ACL table (#1670)
  > [vog/systemlag] Voq lagid allocator (#1603)
  > Add table descriptions for dynamic buffer calculation to the documents (#1664)
  > [vstest/subintf] Add vs test case to validate processing sequence of APPL DB keys (#1663)
  > Remove vxlanmgrd dependency on orchagent (#1647)
  > Keep attribute order in bulk mode (#1659)
  > [mux] VS test for neigh, route and fdb (#1656)
  > [linksync] Netdev oper status determination using IFF_RUNNING (#1568)
  > [portorch] parse on/off value from autoneg (#1658)
  > [intfsorch] Create subport with the entry contains necessary attributes (#1650)
  > [ci]: Purge swss before install (#1654)
  > Update StateDB with error if state change failed, Update APP_DB in all state chg req (#1662)
  > Added changes to handle dependency check in FdbSyncd and FpmSyncd for warm-boot (#1556)
  > [synchronous mode] Add failure notification for SAI failures in synchronous mode (#1596)
  > [acl] Enable VLAN ID qualifier for ACL rules (#1648)
  > Updated PFCWD to use single ACL table for PFCWD and MUX (#1620)
  > [orchagent] Increase SAI REDIS response timeout to support FW upgrade during init (Mellanox only). (#1637)
  > [vstest/nhg]: use dvs_route fixture to make test_nhg more robust
  > [vstest]: add dvs_route fixture
  > [vstest/subintf] Update vs tests to validate physical port host interface vlan tag attribute (#1634)
  > Remove useless header  in macsecorch (#1628)
  > Add SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter, create new FlexCounter group (#1600)
  > fixed unsupported resource issue (#1641)
  > [test_virtual_chassis]: use wait_for to make test more robust (#1640)
  > spell check fixes (#1630)
  > [bufferorch] Handle NOT IMPLEMENTED status returned during set attr operation (#1639)
  > [ci]: run vstest
  > [test_virtual_chassis]: use wait_for function to improve test robustness
  > [Mux] Neighbor handling based on FDB entry (#1631)
  > [ci]: use build template (#1633)
  > Log level change from ERR to INFO for fetch systemports issue (#1632)
  > Migrate serdes programming to port serdes object (#1611)
  > [tests] Remove legacy saiattributelist.h dependency (#1608)
  > [buffermgr] Support maximum port headroom checking (#1607)
  > Support shared headroom pool on top of dynamic buffer calculation (#1581)
  > Fix the compiling errors in gcc9 (#1621)
yxieca added a commit to yxieca/sonic-buildimage that referenced this issue Mar 26, 2021
@yxieca
[202012][swss][utilities] advance submodule heads
9e09a92 
utilities:
* 83f068b 2021-03-22 | Handling error scenario of adding port to Vlan which is part of LAG (sonic-net#1516) (HEAD -> 202012) [Sudharsan Dhamal Gopalarathnam]
* 470e8ce 2021-03-24 | Enable PFCWD only on ports where PFC is enabled (sonic-net#1508) [Andriy Yurkiv]
* 09ef2e0 2021-03-22 | [show][config] add support for setting and displaying switching modes on Y cable (sonic-net#1501) [vdahiya12]
* 0d17d37 2021-03-24 | Warmboot script improvements - timeout exec, disable swss autorestart, remove trap (sonic-net#1495) [Vaibhav Hemant Dixit]
* 2718cd8 2021-03-24 | [show] Fix int status of LAGs, configured as Vlan members (sonic-net#1478) [maksymbelei95]
* cc168fb 2021-03-22 | Fix bug: show vlan config for vlan with no members (sonic-net#1503) [allas-nvidia]

swss:
* 5d8d1fb 2021-03-26 | Revert "Revert "[buffermgr] Support maximum port headroom checking (sonic-net#1607)" (sonic-net#1675)" (sonic-net#1682) (HEAD -> 202012) [Prince Sunny]
* f8df1f8 2021-03-26 | [Dynamic Buffer Calc] Enhance the field checking in table handling (sonic-net#1680) [Stephen Sun]
* 6328c9f 2021-03-22 | [MuxOrch] FDB ageout safety check (sonic-net#1674) [Prince Sunny]
* e1d733e 2021-03-21 | reduce severity of log to info in case of flush on non-existing member (sonic-net#1669) [allas-nvidia]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca mentioned this issue Mar 26, 2021
Merged
lguohan pushed a commit that referenced this issue Mar 27, 2021
@yxieca
[202012][swss][utilities] advance submodule heads (#7165)
7dc0ae5 
utilities:
* 83f068b 2021-03-22 | Handling error scenario of adding port to Vlan which is part of LAG (#1516) (HEAD -> 202012) [Sudharsan Dhamal Gopalarathnam]
* 470e8ce 2021-03-24 | Enable PFCWD only on ports where PFC is enabled (#1508) [Andriy Yurkiv]
* 09ef2e0 2021-03-22 | [show][config] add support for setting and displaying switching modes on Y cable (#1501) [vdahiya12]
* 0d17d37 2021-03-24 | Warmboot script improvements - timeout exec, disable swss autorestart, remove trap (#1495) [Vaibhav Hemant Dixit]
* 2718cd8 2021-03-24 | [show] Fix int status of LAGs, configured as Vlan members (#1478) [maksymbelei95]
* cc168fb 2021-03-22 | Fix bug: show vlan config for vlan with no members (#1503) [allas-nvidia]

swss:
* 5d8d1fb 2021-03-26 | Revert "Revert "[buffermgr] Support maximum port headroom checking (#1607)" (#1675)" (#1682) (HEAD -> 202012) [Prince Sunny]
* f8df1f8 2021-03-26 | [Dynamic Buffer Calc] Enhance the field checking in table handling (#1680) [Stephen Sun]
* 6328c9f 2021-03-22 | [MuxOrch] FDB ageout safety check (#1674) [Prince Sunny]
* e1d733e 2021-03-21 | reduce severity of log to info in case of flush on non-existing member (#1669) [allas-nvidia]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this issue May 23, 2021
@jleveque @raphaelt-nvidia
[sonic-sairedis][sonic-swss] Update submodules (sonic-net#7089)
203e17e 
Update sonic-sairedis submodule and also update sonic-swss submodule as there are interdependent changes.

* src/sonic-sairedis 13474d1...bc58b0f (12):
  > Add gbsyncdmgrd; deprecate gbsyncd_startup.py (sonic-net#809)
  > Remove gbsyncd_start.sh (sonic-net#808)
  > [gbsyncd] Fix shebang in gbsyncd_startup.py; Make script executable (sonic-net#807)
  > [saiasiccmp] Add saiasiccmp tool to compare 2 asic views (sonic-net#791)
  > [configure] Add -Wno-psabi to remove "passing argument changed in GCC 7.1" (sonic-net#799)
  > Update FlexCounter.cpp, use m_pollInterval in MUTEX lock (sonic-net#797)
  > [vs] Add special warm boot logic to populate default attributes (sonic-net#796)
  > [ci]: add vstest (sonic-net#795)
  > [tests] Add macsec unittest (sonic-net#782)
  > [debian/control] libsairedis-dev depends on libzmq5-dev (sonic-net#794)
  > [ci]: use build template (sonic-net#793)
  > Rename duplicate file name (sonic-net#773)

* src/sonic-swss 0b0d24c...5adb73e (47):
  > Initialize system port type variable (sonic-net#1681)
  > [Dynamic Buffer Calc] Enhance the field checking in table handling (sonic-net#1680)
  > Handle the clear request for 'Q_SHARED_ALL' (sonic-net#1653)
  > [MuxOrch] FDB ageout safety check (sonic-net#1674)
  > Deactivate mirror session only when session status is true in updateLagMember (sonic-net#1666)
  > Revert "[buffermgr] Support maximum port headroom checking (sonic-net#1607)" (sonic-net#1675)
  > reduce severity of log to info in case of flush on non-existing member (sonic-net#1669)
  > Revert "[Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (sonic-net#1652)" (sonic-net#1676)
  > [Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (sonic-net#1652)
  > [acl] Move ACL table constants to acltable.h (sonic-net#1671)
  > [nbrmgrd] added function to parse IP address from APP_DB (sonic-net#1672)
  > [MUX/PFCWD] Use in_ports for acls instead of seperate ACL table (sonic-net#1670)
  > [vog/systemlag] Voq lagid allocator (sonic-net#1603)
  > Add table descriptions for dynamic buffer calculation to the documents (sonic-net#1664)
  > [vstest/subintf] Add vs test case to validate processing sequence of APPL DB keys (sonic-net#1663)
  > Remove vxlanmgrd dependency on orchagent (sonic-net#1647)
  > Keep attribute order in bulk mode (sonic-net#1659)
  > [mux] VS test for neigh, route and fdb (sonic-net#1656)
  > [linksync] Netdev oper status determination using IFF_RUNNING (sonic-net#1568)
  > [portorch] parse on/off value from autoneg (sonic-net#1658)
  > [intfsorch] Create subport with the entry contains necessary attributes (sonic-net#1650)
  > [ci]: Purge swss before install (sonic-net#1654)
  > Update StateDB with error if state change failed, Update APP_DB in all state chg req (sonic-net#1662)
  > Added changes to handle dependency check in FdbSyncd and FpmSyncd for warm-boot (sonic-net#1556)
  > [synchronous mode] Add failure notification for SAI failures in synchronous mode (sonic-net#1596)
  > [acl] Enable VLAN ID qualifier for ACL rules (sonic-net#1648)
  > Updated PFCWD to use single ACL table for PFCWD and MUX (sonic-net#1620)
  > [orchagent] Increase SAI REDIS response timeout to support FW upgrade during init (Mellanox only). (sonic-net#1637)
  > [vstest/nhg]: use dvs_route fixture to make test_nhg more robust
  > [vstest]: add dvs_route fixture
  > [vstest/subintf] Update vs tests to validate physical port host interface vlan tag attribute (sonic-net#1634)
  > Remove useless header  in macsecorch (sonic-net#1628)
  > Add SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter, create new FlexCounter group (sonic-net#1600)
  > fixed unsupported resource issue (sonic-net#1641)
  > [test_virtual_chassis]: use wait_for to make test more robust (sonic-net#1640)
  > spell check fixes (sonic-net#1630)
  > [bufferorch] Handle NOT IMPLEMENTED status returned during set attr operation (sonic-net#1639)
  > [ci]: run vstest
  > [test_virtual_chassis]: use wait_for function to improve test robustness
  > [Mux] Neighbor handling based on FDB entry (sonic-net#1631)
  > [ci]: use build template (sonic-net#1633)
  > Log level change from ERR to INFO for fetch systemports issue (sonic-net#1632)
  > Migrate serdes programming to port serdes object (sonic-net#1611)
  > [tests] Remove legacy saiattributelist.h dependency (sonic-net#1608)
  > [buffermgr] Support maximum port headroom checking (sonic-net#1607)
  > Support shared headroom pool on top of dynamic buffer calculation (sonic-net#1581)
  > Fix the compiling errors in gcc9 (sonic-net#1621)
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this issue Aug 7, 2021
@jleveque
[sonic-sairedis][sonic-swss] Update submodules (sonic-net#7089)
2deb742 
Update sonic-sairedis submodule and also update sonic-swss submodule as there are interdependent changes.

* src/sonic-sairedis 13474d1...bc58b0f (12):
  > Add gbsyncdmgrd; deprecate gbsyncd_startup.py (sonic-net#809)
  > Remove gbsyncd_start.sh (sonic-net#808)
  > [gbsyncd] Fix shebang in gbsyncd_startup.py; Make script executable (sonic-net#807)
  > [saiasiccmp] Add saiasiccmp tool to compare 2 asic views (sonic-net#791)
  > [configure] Add -Wno-psabi to remove "passing argument changed in GCC 7.1" (sonic-net#799)
  > Update FlexCounter.cpp, use m_pollInterval in MUTEX lock (sonic-net#797)
  > [vs] Add special warm boot logic to populate default attributes (sonic-net#796)
  > [ci]: add vstest (sonic-net#795)
  > [tests] Add macsec unittest (sonic-net#782)
  > [debian/control] libsairedis-dev depends on libzmq5-dev (sonic-net#794)
  > [ci]: use build template (sonic-net#793)
  > Rename duplicate file name (sonic-net#773)

* src/sonic-swss 0b0d24c...5adb73e (47):
  > Initialize system port type variable (sonic-net#1681)
  > [Dynamic Buffer Calc] Enhance the field checking in table handling (sonic-net#1680)
  > Handle the clear request for 'Q_SHARED_ALL' (sonic-net#1653)
  > [MuxOrch] FDB ageout safety check (sonic-net#1674)
  > Deactivate mirror session only when session status is true in updateLagMember (sonic-net#1666)
  > Revert "[buffermgr] Support maximum port headroom checking (sonic-net#1607)" (sonic-net#1675)
  > reduce severity of log to info in case of flush on non-existing member (sonic-net#1669)
  > Revert "[Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (sonic-net#1652)" (sonic-net#1676)
  > [Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (sonic-net#1652)
  > [acl] Move ACL table constants to acltable.h (sonic-net#1671)
  > [nbrmgrd] added function to parse IP address from APP_DB (sonic-net#1672)
  > [MUX/PFCWD] Use in_ports for acls instead of seperate ACL table (sonic-net#1670)
  > [vog/systemlag] Voq lagid allocator (sonic-net#1603)
  > Add table descriptions for dynamic buffer calculation to the documents (sonic-net#1664)
  > [vstest/subintf] Add vs test case to validate processing sequence of APPL DB keys (sonic-net#1663)
  > Remove vxlanmgrd dependency on orchagent (sonic-net#1647)
  > Keep attribute order in bulk mode (sonic-net#1659)
  > [mux] VS test for neigh, route and fdb (sonic-net#1656)
  > [linksync] Netdev oper status determination using IFF_RUNNING (sonic-net#1568)
  > [portorch] parse on/off value from autoneg (sonic-net#1658)
  > [intfsorch] Create subport with the entry contains necessary attributes (sonic-net#1650)
  > [ci]: Purge swss before install (sonic-net#1654)
  > Update StateDB with error if state change failed, Update APP_DB in all state chg req (sonic-net#1662)
  > Added changes to handle dependency check in FdbSyncd and FpmSyncd for warm-boot (sonic-net#1556)
  > [synchronous mode] Add failure notification for SAI failures in synchronous mode (sonic-net#1596)
  > [acl] Enable VLAN ID qualifier for ACL rules (sonic-net#1648)
  > Updated PFCWD to use single ACL table for PFCWD and MUX (sonic-net#1620)
  > [orchagent] Increase SAI REDIS response timeout to support FW upgrade during init (Mellanox only). (sonic-net#1637)
  > [vstest/nhg]: use dvs_route fixture to make test_nhg more robust
  > [vstest]: add dvs_route fixture
  > [vstest/subintf] Update vs tests to validate physical port host interface vlan tag attribute (sonic-net#1634)
  > Remove useless header  in macsecorch (sonic-net#1628)
  > Add SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter, create new FlexCounter group (sonic-net#1600)
  > fixed unsupported resource issue (sonic-net#1641)
  > [test_virtual_chassis]: use wait_for to make test more robust (sonic-net#1640)
  > spell check fixes (sonic-net#1630)
  > [bufferorch] Handle NOT IMPLEMENTED status returned during set attr operation (sonic-net#1639)
  > [ci]: run vstest
  > [test_virtual_chassis]: use wait_for function to improve test robustness
  > [Mux] Neighbor handling based on FDB entry (sonic-net#1631)
  > [ci]: use build template (sonic-net#1633)
  > Log level change from ERR to INFO for fetch systemports issue (sonic-net#1632)
  > Migrate serdes programming to port serdes object (sonic-net#1611)
  > [tests] Remove legacy saiattributelist.h dependency (sonic-net#1608)
  > [buffermgr] Support maximum port headroom checking (sonic-net#1607)
  > Support shared headroom pool on top of dynamic buffer calculation (sonic-net#1581)
  > Fix the compiling errors in gcc9 (sonic-net#1621)
vivekrnv added a commit to vivekrnv/sonic-buildimage that referenced this issue Sep 13, 2021
@vivekrnv
Update submodule sonic-utilities
4ad2756 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

2416175 [config reload] Fix config reload failure due to sonic.target job cancellation (sonic-net#1814)
2b12aad [portstat, intfstat] added rates and utilization (sonic-net#1750)
26e700a [debug dump util] Techsupport addition (sonic-net#1669)
9f2326e [debug dump util] Base Skeleton and Click Class added (sonic-net#1668)
@Junchao-Mellanox Junchao-Mellanox mentioned this issue Sep 14, 2021
Merged
5 tasks
qiluo-msft pushed a commit that referenced this issue Sep 28, 2021
@Junchao-Mellanox
[submodule] Update submodule for sonic-utilities (#8752)
c770375 
0d538d3 [ci]: Support code diff coverage (#1834)
48887d1 [config] support for configuring muxcable to standby mode of operation (#1837)
2088a9a Provide support to install platform extensions (#1578)
c97fe54 Add check_db_integrity script to setup.py (#1828)
c0b9917 [debug dump util] COPP Module Added (#1670)
826311c [techsupport] Removed interactive option for docker commands and Improved Error Reporting (#1723)
ce11545 [config reload] Removed job-mode for sonic.target restart (#1820)
f76f672 [fdbshow]: Fix typo in comment (#1809)
17208a0 [ci]: Support PR coverage (#1806)
c2c2354 fix wrong code indent in sfputil (#1808)
47a9a0f [portconfig] Validate duplicate speed value and interface type value (#1745)
f1086ee [sonic_installer]Add --skip-platform-check option for sonic_installer when image mismatch (#1791)
c007d65 [warm-reboot] Add new preboot health check: verify database integrity (#1785)
41e31e8 Fix PatchApplier init order (#1762)
2416175 [config reload] Fix config reload failure due to sonic.target job cancellation (#1814)
2b12aad [portstat, intfstat] added rates and utilization (#1750)
26e700a [debug dump util] Techsupport addition (#1669)
9f2326e [debug dump util] Base Skeleton and Click Class added (#1668)
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this issue Feb 5, 2022
@allas-nvidia
reduce severity of log to info in case of flush on non-existing member (
cd6ffd2 
sonic-net#1669)

- What I did
Reduced severity of log to info in case of flush on non-existing member.

- Why I did it
There is a race in the infra which can cause the scenario: FDB FLUSH notification is received on port which was already removed.

- How I verified it
> sudo config vlan add 3
> sudo config vlan member add 3 Ethernet8
> sudo config vlan member del 3 Ethernet8

Signed-off-by: allas <allas@nvidia.com>
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this issue Apr 28, 2022
@vivekrnv
[debug dump util] Techsupport addition (sonic-net#1669)
26e700a 
What I did
HLD for Dump Utility: HLD.
For More info on Tech Support Addition: TechSupport

How I did it
Module Names are retrieved by parsing the output of dump state --show command.
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this issue Apr 28, 2022
@raphaelt-nvidia
[debug dump util] Vlan Module Added (sonic-net#1877)
5e95fc3 
What I did
Implemented vlan and vlan_member modules for debug dump utility.

How I did it
Used infrastructure and followed examples in
sonic-net#1666
sonic-net#1667
sonic-net#1668
sonic-net#1669
sonic-net#1670

How to verify it
On switch: dump state vlan <vlan_name>
dump state vlan_member '<vlan_name|<member_name>'
Unit test: pytest-3 dump_tests/module_tests/vlan_test.py (same test file covers both vlan and vlan_member)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Question ❓
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[dockers] Prevent apt-get from installing suggested and recommended packages by default
5 participants
@stcheng @jleveque @jeromesun14 @fgggid @yangbashuang