Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"sonic ERR swss#orchagent: :- removeVlan: Failed to remove non-empty VLAN Vlan1002" in case of deleting a Vlan that contains members. #6360

Closed
Hedgehog-Guru opened this issue Jan 5, 2021 · 1 comment
Closed

"sonic ERR swss#orchagent: :- removeVlan: Failed to remove non-empty VLAN Vlan1002" in case of deleting a Vlan that contains members. #6360

Hedgehog-Guru opened this issue Jan 5, 2021 · 1 comment

Comments

@Hedgehog-Guru
Copy link

Description
There is no validation, so it’s acceptable to delete a particular Vlan in case of several ports are members of this vlan.
But doing this an error appears in syslog:
sonic ERR swss#orchagent: :- removeVlan: Failed to remove non-empty VLAN Vlan1002

Steps to reproduce the issue
Add a vlan
config vlan add 1002
Assign members to created Vlan
config vlan member add 1002 Ethernet32 config vlan member add 1002 Ethernet44
Remove created Vlan
config vlan del 1002

Describe the results you received
Errors in syslog:

Jan  2 18:17:24.139406 sonic NOTICE swss#orchagent: :- removeVlanMember: Remove member Ethernet44 from VLAN Vlan1002 lid:3ea vmid:270000000002e6
Jan  2 18:17:24.139491 sonic NOTICE swss#orchagent: :- setHostIntfsStripTag: Set SAI_HOSTIF_VLAN_TAG_STRIP to host interface: Ethernet44
Jan  2 18:17:24.139535 sonic NOTICE swss#orchagent: :- removeBridgePort: Remove bridge port Ethernet44 from default 1Q bridge
Jan  2 18:17:24.142492 sonic INFO syncd#supervisord: syncd Jan 02 18:17:24 NOTICE  SAI_VLAN: mlnx_sai_vlan.c[1329]- mlnx_remove_vlan_member: Remove vlan member interface Vlan member port 12900 vlan 1002
Jan  2 18:17:24.146621 sonic INFO lldp#lldpd[28]: removal request for address of fe80::268a:7ff:fe7e:4f80%41, but no knowledge of it
Jan  2 18:17:24.147346 r-ethernet-sw230 INFO kernel: [ 1227.099847] device Bridge left promiscuous mode
Jan  2 18:17:24.148819 sonic INFO lldp#supervisord: lldpd 2020-01-02T18:17:24 [INFO/netlink] removal request for address of fe80::268a:7ff:fe7e:4f80%41, but no knowledge of it
Jan  2 18:17:24.166604 sonic ERR swss#orchagent: :- removeVlan: Failed to remove non-empty VLAN Vlan1002
Jan  2 18:17:24.172260 sonic ERR swss#orchagent: :- removeVlan: Failed to remove non-empty VLAN Vlan1002
Jan  2 18:17:24.172339 sonic NOTICE swss#orchagent: :- removeVlanMember: Remove member Ethernet32 from VLAN Vlan1002 lid:3ea vmid:270000000002e4
Jan  2 18:17:24.172392 sonic NOTICE swss#orchagent: :- setHostIntfsStripTag: Set SAI_HOSTIF_VLAN_TAG_STRIP to host interface: Ethernet32
Jan  2 18:17:24.172435 sonic NOTICE swss#orchagent: :- removeBridgePort: Remove bridge port Ethernet32 from default 1Q bridge
Jan  2 18:17:24.172476 sonic NOTICE swss#orchagent: :- removeVlan: Remove VLAN Vlan1002 vid:1002
Jan  2 18:17:24.172566 sonic INFO syncd#supervisord: syncd Jan 02 18:17:24 NOTICE  SAI_UTILS: mlnx_sai_utils.c[2336]- set_dispatch_attrib_handler: Set ADMIN_STATE, key:bridge port idx 1, val:false
Jan  2 18:17:24.174353 sonic INFO syncd#supervisord: syncd Jan 02 18:17:24 NOTICE  SAI_SWITCH: mlnx_sai_switch.c[3741]- event_thread_func: Port 12900 changed state to down
Jan  2 18:17:24.175330 r-ethernet-sw230 WARNING kernel: [ 1227.127513] sx_netdev_handle_pude_event: Called for logical port - 12900 status DOWN
Jan  2 18:17:24.175948 sonic INFO syncd#supervisord: syncd Jan 02 18:17:24 NOTICE  SAI_UTILS: mlnx_sai_utils.c[2336]- set_dispatch_attrib_handler: Set VLAN_TAG, key:host interface 11, val:STRIP
Jan  2 18:17:24.176039 sonic INFO syncd#supervisord: syncd Jan 02 18:17:24 NOTICE  SAI_BRIDGE: mlnx_sai_bridge.c[2984]- mlnx_remove_bridge_port: Remove bridge port idx 1
Jan  2 18:17:24.177587 sonic INFO syncd#supervisord: syncd Jan 02 18:17:24 NOTICE  SAI_VLAN: mlnx_sai_vlan.c[1329]- mlnx_remove_vlan_member: Remove vlan member interface Vlan member port 12500 vlan 1002
Jan  2 18:17:24.190275 sonic INFO syncd#supervisord: syncd Jan 02 18:17:24 NOTICE  SAI_UTILS: mlnx_sai_utils.c[2336]- set_dispatch_attrib_handler: Set ADMIN_STATE, key:bridge port idx 0, val:false
Jan  2 18:17:24.194779 sonic INFO syncd#supervisord: syncd Jan 02 18:17:24 NOTICE  SAI_SWITCH: mlnx_sai_switch.c[3741]- event_thread_func: Port 12500 changed state to down
Jan  2 18:17:24.195526 r-ethernet-sw230 WARNING kernel: [ 1227.148093] sx_netdev_handle_pude_event: Called for logical port - 12500 status DOWN
Jan  2 18:17:24.196301 sonic INFO syncd#supervisord: syncd Jan 02 18:17:24 NOTICE  SAI_UTILS: mlnx_sai_utils.c[2336]- set_dispatch_attrib_handler: Set VLAN_TAG, key:host interface 8, val:STRIP
Jan  2 18:17:24.196301 sonic INFO syncd#supervisord: syncd Jan 02 18:17:24 NOTICE  SAI_BRIDGE: mlnx_sai_bridge.c[2984]- mlnx_remove_bridge_port: Remove bridge port idx 0
Jan  2 18:17:24.196846 sonic INFO syncd#supervisord: syncd Jan 02 18:17:24 NOTICE  SAI_VLAN: mlnx_sai_vlan.c[923]- mlnx_remove_vlan: Remove vlan 1002
Jan  2 18:17:24.200513 sonic NOTICE swss#orchagent: :- doTask: Get port state change notification id:10000000001f4 status:2
Jan  2 18:17:24.200513 sonic NOTICE swss#orchagent: :- updatePortOperStatus: Port Ethernet44 oper state set from up to down
Jan  2 18:17:24.201674 sonic NOTICE swss#orchagent: :- setHostIntfsOperStatus: Set operation status DOWN to host interface Ethernet44
Jan  2 18:17:24.202342 sonic NOTICE swss#orchagent: :- doTask: Get port state change notification id:10000000001d3 status:2
Jan  2 18:17:24.202342 sonic NOTICE swss#orchagent: :- updatePortOperStatus: Port Ethernet32 oper state set from up to down
Jan  2 18:17:24.202917 sonic INFO syncd#supervisord: syncd Jan 02 18:17:24 NOTICE  SAI_UTILS: mlnx_sai_utils.c[2336]- set_dispatch_attrib_handler: Set OPER_STATUS, key:host interface 11, val:false
Jan  2 18:17:24.203257 sonic NOTICE swss#orchagent: :- setHostIntfsOperStatus: Set operation status DOWN to host interface Ethernet32
Jan  2 18:17:24.204649 sonic INFO syncd#supervisord: syncd Jan 02 18:17:24 NOTICE  SAI_UTILS: mlnx_sai_utils.c[2336]- set_dispatch_attrib_handler: Set OPER_STATUS, key:host interface 8, val:false
Jan  2 18:17:25.163338 r-ethernet-sw230 INFO kernel: [ 1228.113221] Bridge: port 3(Ethernet44) entered disabled state
Jan  2 18:17:25.163370 r-ethernet-sw230 INFO kernel: [ 1228.113440] Bridge: port 2(Ethernet32) entered disabled state

Describe the results you expected

In case of deleting a particular Vlan is eligible there should not be any errors in syslog.
In case of deleting a particular Vlan is not eligible there should not be a validation in config vlan del command if deleted Vlan is assigned to ports.

Output of show version

SONiC Software Version: SONiC.HEAD.129-0c9040de
Distribution: Debian 9.11
Kernel: 4.9.0-9-2-amd64
Build commit: 0c9040de
Build date: Thu Nov 21 12:50:41 UTC 2019
Built by: johnar@jenkins-worker-4

Platform: x86_64-mlnx_msn2100-r0
HwSKU: ACS-MSN2100
ASIC: mellanox
Serial Number: MT1646X05314
Uptime: 18:20:14 up 23 min,  2 users,  load average: 3.27, 3.21, 2.69

Docker images:
REPOSITORY                 TAG                 IMAGE ID            SIZE
docker-syncd-mlnx          HEAD.129-0c9040de   4f3b126274c2        373MB
docker-syncd-mlnx          latest              4f3b126274c2        373MB
docker-fpm-frr             HEAD.129-0c9040de   7345e105bf26        321MB
docker-fpm-frr             latest              7345e105bf26        321MB
docker-sflow               HEAD.129-0c9040de   f240b81ea842        305MB
docker-sflow               latest              f240b81ea842        305MB
docker-lldp-sv2            HEAD.129-0c9040de   f1b94915bf13        299MB
docker-lldp-sv2            latest              f1b94915bf13        299MB
docker-dhcp-relay          HEAD.129-0c9040de   7ba3cee353b6        289MB
docker-dhcp-relay          latest              7ba3cee353b6        289MB
docker-database            HEAD.129-0c9040de   c5c92210277c        281MB
docker-database            latest              c5c92210277c        281MB
docker-snmp-sv2            HEAD.129-0c9040de   ad01f8a547b1        335MB
docker-snmp-sv2            latest              ad01f8a547b1        335MB
docker-orchagent           HEAD.129-0c9040de   7fc54899dc92        322MB
docker-orchagent           latest              7fc54899dc92        322MB
docker-teamd               HEAD.129-0c9040de   c0316e26bbbd        304MB
docker-teamd               latest              c0316e26bbbd        304MB
docker-sonic-telemetry     HEAD.129-0c9040de   43df42f49e91        304MB
docker-sonic-telemetry     latest              43df42f49e91        304MB
docker-router-advertiser   HEAD.129-0c9040de   b0aff9280842        281MB
docker-router-advertiser   latest              b0aff9280842        281MB
docker-platform-monitor    HEAD.129-0c9040de   10013f82e4d7        565MB
docker-platform-monitor    latest              10013f82e4d7        565MB

sonic_dump_r-ethernet-sw230_20200102_181730.tar.gz
@Hedgehog-Guru Hedgehog-Guru mentioned this issue Jan 31, 2021
Closed
@Hedgehog-Guru
Copy link
Author

Bug has been fixed.
Verified on

SONiC Software Version: SONiC.SONIC.202012.43-5263478_Internal
Distribution: Debian 10.8
Kernel: 4.19.0-12-2-amd64
Build commit: 52634787
Build date: Thu Mar 11 10:57:12 UTC 2021
Built by: sw-r2d2-bot@r-build-sonic-ci02

shi-su added a commit that referenced this issue Aug 25, 2021
@shi-su
[201911] [FRR] Upgrade FRR to frr-7.2.1-s4 tag (#8572)
09a1e90 
Why I did it
Update FRR 7.2.1 head. The following is a list of new commits.

5ae667a1f Merge pull request #9335 from FRRouting/mergify/bp/stable/7.2/pr-9214
eb679e8a1 zebra: bugfix of error quit of zebra, due to no nexthop ACTIVE
80d2eaa98 Merge pull request #8886 from FRRouting/mergify/bp/stable/7.2/pr-8876
1eeab2c1e lib: remove pure attribute from functions that modify memory
eb00dc4ec Merge pull request #6944 from LabNConsulting/working/lb/7.2/valgrind-supp-libyang
b9d6d05bf bgpd: suppress new libyang_1.0 related loss reports
8c26a71eb Merge pull request #6562 from ton31337/fix/configuration_for_labeled_unicast_in_place_7.2
386a1719c bgpd: Make sure network/aggregate-address commands lay down under labeled safi
b01c8bf28 Merge pull request #6526 from ton31337/fix/set_ipv6_ll_if_global_zero_7.2
c382833e8 bgpd: Use IPv6 LL address as nexthop if global was set to ::/LL
99509b835 Merge pull request #6395 from opensourcerouting/7.2/init-config-perms
7eef8f7b1 build: use configfile mode in init script
4cbe07705 Merge pull request #6360 from opensourcerouting/7.2/fix-warnings
84bb11785 nhrpd: clean up SA warning
aac726476 nhrpd: be more careful with linked lists
3a4b6d654 debian: Fix spelling error
756c67c6c Merge pull request #6284 from opensourcerouting/7.2/gcc-10
65a116a64 Merge pull request #6354 from ton31337/fix/communities_bgpd_crash_7.2
f7a00fd67 bgpd: Check to ensure community attributes exist before freeing them
a960f99c2 vrrpd: fix build on Fedora Rawhide
d4caff99f babeld: GCC complaining about no return in non-void function
a014c27ae babeld: fix build on Fedora Rawhide
79ff55b5b bgpd: remove unused variable
ff343e588 pimd: Make frr able to be built by gcc 10
9a3cf1ba2 ldpd: remove multiple definitions of thread_master
a19515bfe ldpd: fix another linking issue with GCC-10
b4c8de38c tests: fix build with GCC 10
4f27e8c85 ldpd: Fix linking error on Fedora Rawhide with GCC 10

How I did it
Update FRR 7.2 pointer and create a tag frr-7.2.1-s4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Hedgehog-Guru