[memory_monitoring] Enhance monitoring the memory usage of containers #10008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of containers. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
yozhao101
changed the title
`contianerd-shim` process. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
5 tasks
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run sonic-buildimage |
|
No pipelines are associated with this pull request. |
There was a problem hiding this comment.
There's conflicts exist on the PR, I update it into #19179 instead, will reply and address comments there as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yong Zhao yozhao@microsoft.com
Why I did it
Currently we have a PR (#10017) which will put a hard limitation on memory usage of telemetry container.
During testing the above PR, we found that the commands
docker stats,docker start,docker stopanddocker execwill be no response if memory usage of telemetry container reaches or exceeds the configured hard limitation. This behavior will fail the background scriptmemory_checkersince they depend on the command output ofdocker stats.How I did it
Instead of depending on the output of
docker stats, the background scriptmemory_checkerwill calculate the memory usage of a container based on values reading from the cgroup subsystem files/sys/fs/cgroup/memory/docker/<container_name>/memory.usage_in_bytesand/sys/fs/cgroup/memory/docker/<container_name>/memory.stats.I refer to this Docker official document (https://docs.docker.com/engine/reference/commandline/stats/#extended-description) to make sure the memory usage of a specific container reading from command output of
docker statsis equal to the value subtracting cache usage from the total memory usage.How to verify it
I manually tested this implementation on DuT
str-msn2700-20.Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)