Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sonic-utilities]: Build as Debian package once again (revert change to wheel) #1018

Merged
merged 1 commit into from
Oct 6, 2017
Merged

[sonic-utilities]: Build as Debian package once again (revert change to wheel) #1018

merged 1 commit into from
Oct 6, 2017

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Oct 6, 2017 •
edited

  • The swsssdk package is installed as a wheel. If we compile sonic-utilities as a wheel, it will locate the swsssdk package dependency. However, if we compile sonic-utilities as a Debian package, it will look for a swsssdk Debian package, fail to find it, and the installation will fail.

  • However, building as a wheel introduced a few unexpected changes, such as installing the scripts in /usr/local/bin vs. /usr/bin, as well as the lack of ability to copy files outside of python package directory (i.e., bash_completion files to /etc/bash_completion.d/).

  • For now, we remove this explicit dependency in order to revert back to building sonic-utilities as a Debian package until we find a better solution, as we should specify all dependencies to ensure proper builds in case something goes wrong with the swsssdk installation. Ultimately, it would be great if we could build Debian packages that depend on wheels and vice-versa.

@jleveque jleveque self-assigned this Oct 6, 2017
@jleveque jleveque requested a review from lguohan October 6, 2017 01:40
@stcheng
Copy link
Contributor

stcheng commented Oct 6, 2017

could you resolve the conflicts?

@jleveque
Copy link
Contributor Author

jleveque commented Oct 6, 2017

@stcheng: Done.

@jleveque jleveque merged commit 8a305ce into sonic-net:master Oct 6, 2017
@jleveque jleveque deleted the utilities_deb branch October 6, 2017 19:46
@jleveque jleveque mentioned this pull request Oct 6, 2017
Closed
@akokhan akokhan mentioned this pull request Aug 13, 2019
Merged
lguohan pushed a commit that referenced this pull request Aug 14, 2019
@akokhan @lguohan
[swss][sairedis] advance sub-modules (#3326)
a209c7f 
[sairedis]:

ARM32 bit fixes, for 64bit printf format specifier (#490)
fix wrong API type , add cmdline parse option , remove unuseful api call (#499)
Use pointer to member function to reduce the footprint of collectCounters() (#488)
[syncd] Add support for Innovium platform (#496)
[saisdkdump]: Fix dump generation crash (#493)

[swss]:

Add scope attribute to VNET table. (#954)
[portsyncd]: Fix portsyncd restart case (#1019)
[vnet]: Enable "vnet_orch_1" VS test case (#1020)
[vlan] Add pytest cases to validate the behavior about add LAG member to vlan. (#875)
[policerorch]: Add the capability to update policer rate/size (#1017)
[aclorch]: Add MIRRORv6 support for NPS platform (#1018)
[orchagent]: Avoid crash by setting g_syncMode flag before create_switch (#1014)
[orchagent] Add support for Innovium platform (#1005)
Provide broadcast IP while configuring interface ip address (#1007)
[VLAN] Add pytest cases to validate different use-case of tagging_mode. (#860)
[vstest]: Add test_port_config.py which include breakout port test. (#866)
[vstests]: change 'test_acl_egress_table.py' to UNIX format (#1010)
[vlan] Add pytest cases to verify data in app db and state db. (#895)
[vstest]: Add the CRM tests (#1013)
[warm-reboot]: add bgp eoiu support to speed up route reconcile (#856)
[fdborch] support mac update (#877)
[vxlanorch] Fix Logic of Vxlan tunnel removal (#995)
Fix VLAN error introduced with new 4.9 kernel behavior (#1001)
Config DB manual is being moved from Wiki to SWSS repo (#1002)
Trap DHCPv6 packets for supporting ZTP over in-band interfaces using … (#997)

Signed-off-by: Andriy Kokhan <akokhan@barefootnetworks.com>
zhenggen-xu pushed a commit to zhenggen-xu/sonic-buildimage that referenced this pull request Oct 17, 2019
@jleveque
[sonic-utilities]: Build as Debian package once again (revert change …
1c5f11b 
…to wheel) (sonic-net#1018)

RB=1127438
G=lnos-reviewers
R=ntrianta,rjonnadu,rmolina,sfardeen,zxu
A=
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
@JaredLius @stcheng
[aclorch]: Add MIRRORv6 support for NPS platform (sonic-net#1018)
273608c 
Signed-off-by: Jared.Liu <Jared.Liu@nephosinc.com>
stephenxs pushed a commit to stephenxs/sonic-buildimage that referenced this pull request Aug 14, 2020
[submodule] Advance submodule head for sonic-utilities
9d272ae 
    [db_migrator] Support migrating database regarding buffer configuration for all Mellanox switches (sonic-net#993)
    [show/vlan]: fix show vlan config (sonic-net#1050)
    [PFCWD] Fix issue with "pfcwd show stats" command during SONiC init (sonic-net#1018)
    [config] Eliminate port breakout-related globals (sonic-net#1045)
    [teamshow]: refactor teamshow to use state db information (sonic-net#1049)
    [watermarkstat] Import print_function from __future__ (sonic-net#1048)
    [show]: split show interfaces commands into separate file (sonic-net#1044)
    Python 3 compliance (sonic-net#1043)
    Update all references to new 'sonic-installer' file name (sonic-net#1033)
    [config/show]: split vlan into separate file (sonic-net#1038)
    [pytest/coverage]: add coverage for all scripts (sonic-net#1041)
    enable watchdog before running platform specific reboot plugin (sonic-net#1037)
    [tests]:add coverage for config/main/utilities_common module (sonic-net#1039)
    [cli/feature]: split feature command into a separate file (sonic-net#1034)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
lguohan pushed a commit that referenced this pull request Aug 14, 2020
@stephenxs
[submodule] Advance submodule head for sonic-utilities (#5184)
5c02078 
[db_migrator] Support migrating database regarding buffer configuration for all Mellanox switches (#993)
    [show/vlan]: fix show vlan config (#1050)
    [PFCWD] Fix issue with "pfcwd show stats" command during SONiC init (#1018)
    [config] Eliminate port breakout-related globals (#1045)
    [teamshow]: refactor teamshow to use state db information (#1049)
    [watermarkstat] Import print_function from __future__ (#1048)
    [show]: split show interfaces commands into separate file (#1044)
    Python 3 compliance (#1043)
    Update all references to new 'sonic-installer' file name (#1033)
    [config/show]: split vlan into separate file (#1038)
    [pytest/coverage]: add coverage for all scripts (#1041)
    enable watchdog before running platform specific reboot plugin (#1037)
    [tests]:add coverage for config/main/utilities_common module (#1039)
    [cli/feature]: split feature command into a separate file (#1034)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

Co-authored-by: Stephen Sun <stephens@mellanox.com>
abdosi added a commit that referenced this pull request Sep 3, 2020
@abdosi
[submodule update] sonic-util
c480db1 
Fix error when running 'show lldp table' or 'show lldp neighbor'
through SSH command. (#1067)
[201911]: Multi asic show interface support (#1070)
[counterpoll] Add new FC group for port buffer drop counters
(#1024)
[201911] show interface portchannel support for Multi ASIC
(#1071)
Fix a typo in mellanox_buffer_migrator (#1090)
Fix pfcwd stats crash with invalid queue name (#1077)
[PFCWD] Fix issue with "pfcwd show stats" command during SONiC init
(#1018)
enable watchdog before running platform specific reboot plugin
(#1037)
Add namespace of the process in the coredump filename. (#1091)
wangshengjun pushed a commit to wangshengjun/sonic-buildimage that referenced this pull request Nov 16, 2020
@akokhan @wangshengjun
[swss][sairedis] advance sub-modules (sonic-net#3326)
e78b7af 
[sairedis]:

ARM32 bit fixes, for 64bit printf format specifier (sonic-net#490)
fix wrong API type , add cmdline parse option , remove unuseful api call (sonic-net#499)
Use pointer to member function to reduce the footprint of collectCounters() (sonic-net#488)
[syncd] Add support for Innovium platform (sonic-net#496)
[saisdkdump]: Fix dump generation crash (sonic-net#493)

[swss]:

Add scope attribute to VNET table. (sonic-net#954)
[portsyncd]: Fix portsyncd restart case (sonic-net#1019)
[vnet]: Enable "vnet_orch_1" VS test case (sonic-net#1020)
[vlan] Add pytest cases to validate the behavior about add LAG member to vlan. (sonic-net#875)
[policerorch]: Add the capability to update policer rate/size (sonic-net#1017)
[aclorch]: Add MIRRORv6 support for NPS platform (sonic-net#1018)
[orchagent]: Avoid crash by setting g_syncMode flag before create_switch (sonic-net#1014)
[orchagent] Add support for Innovium platform (sonic-net#1005)
Provide broadcast IP while configuring interface ip address (sonic-net#1007)
[VLAN] Add pytest cases to validate different use-case of tagging_mode. (sonic-net#860)
[vstest]: Add test_port_config.py which include breakout port test. (sonic-net#866)
[vstests]: change 'test_acl_egress_table.py' to UNIX format (sonic-net#1010)
[vlan] Add pytest cases to verify data in app db and state db. (sonic-net#895)
[vstest]: Add the CRM tests (sonic-net#1013)
[warm-reboot]: add bgp eoiu support to speed up route reconcile (sonic-net#856)
[fdborch] support mac update (sonic-net#877)
[vxlanorch] Fix Logic of Vxlan tunnel removal (sonic-net#995)
Fix VLAN error introduced with new 4.9 kernel behavior (sonic-net#1001)
Config DB manual is being moved from Wiki to SWSS repo (sonic-net#1002)
Trap DHCPv6 packets for supporting ZTP over in-band interfaces using … (sonic-net#997)

Signed-off-by: Andriy Kokhan <akokhan@barefootnetworks.com>
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
@stephenxs @santhosh-kt
[submodule] Advance submodule head for sonic-utilities (sonic-net#5184)
02db790 
[db_migrator] Support migrating database regarding buffer configuration for all Mellanox switches (sonic-net#993)
    [show/vlan]: fix show vlan config (sonic-net#1050)
    [PFCWD] Fix issue with "pfcwd show stats" command during SONiC init (sonic-net#1018)
    [config] Eliminate port breakout-related globals (sonic-net#1045)
    [teamshow]: refactor teamshow to use state db information (sonic-net#1049)
    [watermarkstat] Import print_function from __future__ (sonic-net#1048)
    [show]: split show interfaces commands into separate file (sonic-net#1044)
    Python 3 compliance (sonic-net#1043)
    Update all references to new 'sonic-installer' file name (sonic-net#1033)
    [config/show]: split vlan into separate file (sonic-net#1038)
    [pytest/coverage]: add coverage for all scripts (sonic-net#1041)
    enable watchdog before running platform specific reboot plugin (sonic-net#1037)
    [tests]:add coverage for config/main/utilities_common module (sonic-net#1039)
    [cli/feature]: split feature command into a separate file (sonic-net#1034)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

Co-authored-by: Stephen Sun <stephens@mellanox.com>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
@volodymyrsamotiy
[PFCWD] Fix issue with "pfcwd show stats" command during SONiC init (s…
e741c7c 
…onic-net#1018)

- What I did
Fixed issue with pfcwd show stats command during SONiC init.
Traceback was returned if DB was not yet initialized which is incorrect. Correct behavior would to rather return empty line if something is not yet ready to be pulled and displayed.

- How I did it
Returned empty dictionary instead of None if data are still not present in DB. It is because in source code data expected to be as dictionary type but if there is no expected attributes in DB None was returned. Wich is incorrect and caused following exception: 'NoneType' object has no attribute 'keys'

Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stcheng stcheng stcheng approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees

@jleveque jleveque

Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jleveque @stcheng