[dockers] save extension dockers with an image tag #12829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
stepanblyschak
requested review from
qiluo-msft,
xumia and
lguohan
as code owners
volodymyrsamotiy
approved these changes
Nov 25, 2022
|
@saiarcot895 and @qiluo-msft could you please review and approve? |
saiarcot895
approved these changes
Nov 29, 2022
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 5, 2022
Fixes: sonic-net#11521 - Why I did it When build SONiC dockers, SONiC build system tags all of them with latest tag. This is Ok for all built-in dockers because we will also tag them with image version tag in sonic_debian_extension.j2 script. On the other hand, some of these dockers are SONiC packages and they are installed by sonic-package-manager which creates a only one tag whcih is recorded in the corresponding .gz file. This leads to having these dockers tagged only with latest tag. This change saves the tag as an image version string in .gz file, so that these dockers have version identification in their tag. - How I did it I modified slave.mk to save the version tag instead of latest tag. - How to verify it I verified this change by running show version Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
|
Cherry-pick PR to 202205: #12947 |
mssonicbld
added a commit
that referenced
this pull request
Dec 5, 2022
saiarcot895
added a commit
to saiarcot895/sonic-buildimage
that referenced
this pull request
Dec 6, 2022
PR sonic-net#12829 modified the docker tagging scheme such that optional docker containers would be tagged with the SONiC image version. However, the docker-image-load macro wasn't updated for these changes. Update it here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
8 tasks
lguohan
pushed a commit
that referenced
this pull request
Dec 7, 2022
PR #12829 modified the docker tagging scheme such that optional docker containers would be tagged with the SONiC image version. However, the docker-image-load macro wasn't updated for these changes. Update it here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
StormLiangMS
pushed a commit
to StormLiangMS/sonic-buildimage
that referenced
this pull request
Dec 8, 2022
Fixes: sonic-net#11521 - Why I did it When build SONiC dockers, SONiC build system tags all of them with latest tag. This is Ok for all built-in dockers because we will also tag them with image version tag in sonic_debian_extension.j2 script. On the other hand, some of these dockers are SONiC packages and they are installed by sonic-package-manager which creates a only one tag whcih is recorded in the corresponding .gz file. This leads to having these dockers tagged only with latest tag. This change saves the tag as an image version string in .gz file, so that these dockers have version identification in their tag. - How I did it I modified slave.mk to save the version tag instead of latest tag. - How to verify it I verified this change by running show version Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 8, 2022
…net#12959) PR sonic-net#12829 modified the docker tagging scheme such that optional docker containers would be tagged with the SONiC image version. However, the docker-image-load macro wasn't updated for these changes. Update it here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
mssonicbld
pushed a commit
that referenced
this pull request
Dec 9, 2022
PR #12829 modified the docker tagging scheme such that optional docker containers would be tagged with the SONiC image version. However, the docker-image-load macro wasn't updated for these changes. Update it here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
StormLiangMS
pushed a commit
that referenced
this pull request
Dec 10, 2022
Fixes: #11521 - Why I did it When build SONiC dockers, SONiC build system tags all of them with latest tag. This is Ok for all built-in dockers because we will also tag them with image version tag in sonic_debian_extension.j2 script. On the other hand, some of these dockers are SONiC packages and they are installed by sonic-package-manager which creates a only one tag whcih is recorded in the corresponding .gz file. This leads to having these dockers tagged only with latest tag. This change saves the tag as an image version string in .gz file, so that these dockers have version identification in their tag. - How I did it I modified slave.mk to save the version tag instead of latest tag. - How to verify it I verified this change by running show version Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 14, 2022
…net#12959) PR sonic-net#12829 modified the docker tagging scheme such that optional docker containers would be tagged with the SONiC image version. However, the docker-image-load macro wasn't updated for these changes. Update it here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
mssonicbld
pushed a commit
that referenced
this pull request
Dec 14, 2022
PR #12829 modified the docker tagging scheme such that optional docker containers would be tagged with the SONiC image version. However, the docker-image-load macro wasn't updated for these changes. Update it here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak stepanb@nvidia.com
Fixes: #11521
Why I did it
When build SONiC dockers, SONiC build system tags all of them with
latesttag. This is Ok for all built-in dockers because we will also tag them with image version tag insonic_debian_extension.j2script. On the other hand, some of these dockers are SONiC packages and they are installed bysonic-package-managerwhich creates a only one tag whcih is recorded in the corresponding .gz file. This leads to having these dockers tagged only withlatesttag. This change saves the tag as an image version string in .gz file, so that these dockers have version identification in their tag.How I did it
I modified slave.mk to save the version tag instead of latest tag.
How to verify it
I verified this change by running
show version:Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)