[installer]: support new onie machine.conf format #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Mar 7, 2018
installer/x86_64/install.sh
Outdated
| if [ -f /etc/machine-build.conf ]; then | ||
| # onie_ variable are generate at runtime. | ||
| # they are no longer hardcoded in /etc/machine.conf | ||
| set | grep onie_ > $demo_mnt/machine.conf |
There was a problem hiding this comment.
Why use 'set' instead of 'env'?
Suggest grep 'onie_' at the line beginning. Maybe
env | grep ^onie_
Not sure it is available in ONIE environment.
There was a problem hiding this comment.
since the variables are not exported, so they are not env
onie_* variable are generated at runtime in /etc/machine.conf. We can no longer copy the static machine.conf into sonic image.
Signed-off-by: Guohan Lu <gulv@microsoft.com>
|
/host/machine.conf is incorrent for other application. Please remove quote. |
abdosi
added a commit
that referenced
this pull request
Mar 7, 2021
9e740759c370645b4367acf22856aebcfb7fce45 (HEAD -> 201911, origin/201911) [201911][multi asic] show ip bgp summary changes for bgp mon (#1483) fa07245786df11e6df902c33fcd9c7115a7c5380 [CLI][techsupport] Merge 'show techsupport' changes from master (#1468) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onie_* variable are generated at runtime in /etc/machine.conf.
We can no longer copy the static machine.conf into sonic image.
- What I did
support new onie machine.conf format
- How I did it
export the onie_* varilable into sonic static machine.conf
- How to verify it
alphanetwork validated.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)