Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fstrim service files to systemd #1500

Merged
merged 2 commits into from
Mar 15, 2018
Merged

Add fstrim service files to systemd #1500

merged 2 commits into from
Mar 15, 2018

Conversation

padmanarayana
Copy link
Contributor

- What I did
Add the fstrim.service and fstrim.timer so platform modules may start fstrim service if needed.

- How I did it

Extract from util-linux

- How to verify it

Check that the files are present in /etc/systemd/system

- Description for the changelog

Some of the Dell units need SSD trim support.

- A picture of a cute animal (not mandatory but encouraged)

@lguohan
Copy link
Collaborator

lguohan commented Mar 15, 2018

@padmanarayana , build fails, can you check?

@padmanarayana
Copy link
Contributor Author

It's missing sudo. Build was successful in my local setup. Will upload changes shortly.

@stcheng stcheng merged commit 3bb24a9 into sonic-net:master Mar 15, 2018
dgsudharsan pushed a commit to dgsudharsan/sonic-buildimage that referenced this pull request Nov 13, 2020
Updating submodule pointers for sonic-swss and sonic-utilities
e72e27d 
sonic-swss:
[fea7ade] [orchagent][port] In case of successful port creation set log level to NOTICE instead of ERR (sonic-net#1500)
[7b76d2e] Copp Manager Changes (sonic-net#1333)
[bed7970] [orchagent] Arm 32-bit arch compilation warning Fixes (sonic-net#1488)
[b9084a7] Revert: swss: flush g_asicState after each event is done sonic-net#570 (sonic-net#1478)
[d6e15e9] [dvs] Clean-up conftest.py (sonic-net#1406)

sonic-utilities:
[3f15835] [sflow] Add mVRF support (sonic-net#1230)
[dadfc18] Copp Changes (sonic-net#1004)
[b226159] [CLI][PFCWD] Fix issue with specifying ports in pfcwd start on masic platforms (sonic-net#1203)
[40377d3] [chassis]: Configure and show for platform chassis_modules (sonic-net#1145)
[d5eb2f8] [consutil][connect] Remove root need from connect line command (sonic-net#1225)
[6cbec6b] [multi-ASIC] CRM show/config commands changes for multi-asic (sonic-net#1127)
@dgsudharsan dgsudharsan mentioned this pull request Nov 13, 2020
Merged
3 tasks
dgsudharsan pushed a commit to dgsudharsan/sonic-buildimage that referenced this pull request Nov 16, 2020
Updating submodule pointer for sonic-swss
1dbc830 
sonic-swss:
[fea7ade] [orchagent][port] In case of successful port creation set log
level to NOTICE instead of ERR (sonic-net#1500)
[7b76d2e] Copp Manager Changes (sonic-net#1333)
[bed7970] [orchagent] Arm 32-bit arch compilation warning Fixes (sonic-net#1488)
[b9084a7] Revert: swss: flush g_asicState after each event is done sonic-net#570
(sonic-net#1478)
[d6e15e9] [dvs] Clean-up conftest.py (sonic-net#1406)
@prsunny prsunny mentioned this pull request Mar 18, 2021
Merged
4 tasks
prsunny added a commit that referenced this pull request Mar 18, 2021
@prsunny
[Submodule update] - sonic-utilities (#7091)
28cb43c 
Updated with following commits:

19d4042 - 2021-03-16 : Add self timeout and crash if exceeded. (#1502) [Renuka Manavalan]
aa71231 - 2021-03-16 : [reboot]: Stop mux before reboot on dual ToR (#1500) [Lawrence Lee]
fbad274 - 2021-03-16 : Add 'show' and 'clear' command for PG drop (#1461) [Andriy Yurkiv]
0de99c3 - 2021-03-12 : [decode-syseeprom] When reading from DB, display CRC-32 and all Vendor Extensions (#1497) [Joe LeVeque]
569a079 - 2021-03-12 : [decode-syseeprom] When reading from DB, display CRC-32 and all Vendor Extensions (#1497) [Joe LeVeque]
47d1a14 - 2021-03-12 : [generate-dump] Remove Arista specific logic (#1482) [Samuel Angebault]
1260f90 - 2021-03-12 : [warm-reboot]: Check empty key before issuing redis hget (#1496) [Vaibhav Hemant Dixit]
daall added a commit to daall/sonic-buildimage that referenced this pull request Mar 19, 2021
@daall
[202012][submodule] Update sonic-swss and sonic-utilites submodules f…
a54c34b 
…or 202012

sonic-swss
* [nbrmgrd] added function to parse IP address from APP_DB (sonic-net#1672)
* [MUX/PFCWD] Use in_ports for acls instead of seperate ACL table (sonic-net#1670)
* [mux] VS test for neigh, route and fdb (sonic-net#1656)
* [Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (sonic-net#1652)
* spell check fixes (sonic-net#1630)

sonic-utilities
* [reboot]: Stop mux before reboot on dual ToR (sonic-net#1500)
* [config] Disable/enable container monitoring when stopping/starting services (sonic-net#1499)
* Add 'show' and 'clear' command for PG drop (sonic-net#1461)
* [CLI][techsupport] Add NOOP option for commands that did not have that option (sonic-net#1445)
* [202012][reload] Improve reload by using sonic.target (sonic-net#1509)

Signed-off-by: Danny Allen <daall@microsoft.com>
@daall daall mentioned this pull request Mar 19, 2021
Merged
4 tasks
daall added a commit that referenced this pull request Mar 24, 2021
@daall
[202012][submodule] Update sonic-swss and sonic-utilites submodules f…
1201ca6 
…or 202012 (#7105)

sonic-swss
* [nbrmgrd] added function to parse IP address from APP_DB (#1672)
* [MUX/PFCWD] Use in_ports for acls instead of seperate ACL table (#1670)
* [mux] VS test for neigh, route and fdb (#1656)
* [Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (#1652)
* spell check fixes (#1630)

sonic-utilities
* [reboot]: Stop mux before reboot on dual ToR (#1500)
* [config] Disable/enable container monitoring when stopping/starting services (#1499)
* Add 'show' and 'clear' command for PG drop (#1461)
* [CLI][techsupport] Add NOOP option for commands that did not have that option (#1445)
* [202012][reload] Improve reload by using sonic.target (#1509)

Signed-off-by: Danny Allen <daall@microsoft.com>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
@theasianpianist
[reboot]: Stop mux before reboot on dual ToR (sonic-net#1500)
aa71231 
If the script detects it is running on a dual ToR system, stop the mux container before shutting down syncd

This is necessary to prevent some links from flapping when the standby ToR is rebooted - when reboot stop syncd, the linkmgr will stop receiving heartbeats and will then tell the mux to switchover. However, since the device is rebooting, no heartbeats will be sent out. The peer ToR will see this absence of heartbeats and tell the mux to switch back to itself (the peer ToR), causing the flap.

By stopping the mux container before shutting down syncd, we prevent the rebooting ToR from switching the mux.

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
@prsunny @raphaelt-nvidia
[Submodule update] - sonic-utilities (sonic-net#7091)
7740248 
Updated with following commits:

19d4042 - 2021-03-16 : Add self timeout and crash if exceeded. (sonic-net#1502) [Renuka Manavalan]
aa71231 - 2021-03-16 : [reboot]: Stop mux before reboot on dual ToR (sonic-net#1500) [Lawrence Lee]
fbad274 - 2021-03-16 : Add 'show' and 'clear' command for PG drop (sonic-net#1461) [Andriy Yurkiv]
0de99c3 - 2021-03-12 : [decode-syseeprom] When reading from DB, display CRC-32 and all Vendor Extensions (sonic-net#1497) [Joe LeVeque]
569a079 - 2021-03-12 : [decode-syseeprom] When reading from DB, display CRC-32 and all Vendor Extensions (sonic-net#1497) [Joe LeVeque]
47d1a14 - 2021-03-12 : [generate-dump] Remove Arista specific logic (sonic-net#1482) [Samuel Angebault]
1260f90 - 2021-03-12 : [warm-reboot]: Check empty key before issuing redis hget (sonic-net#1496) [Vaibhav Hemant Dixit]
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@prsunny
[Submodule update] - sonic-utilities (sonic-net#7091)
f861d50 
Updated with following commits:

19d4042 - 2021-03-16 : Add self timeout and crash if exceeded. (sonic-net#1502) [Renuka Manavalan]
aa71231 - 2021-03-16 : [reboot]: Stop mux before reboot on dual ToR (sonic-net#1500) [Lawrence Lee]
fbad274 - 2021-03-16 : Add 'show' and 'clear' command for PG drop (sonic-net#1461) [Andriy Yurkiv]
0de99c3 - 2021-03-12 : [decode-syseeprom] When reading from DB, display CRC-32 and all Vendor Extensions (sonic-net#1497) [Joe LeVeque]
569a079 - 2021-03-12 : [decode-syseeprom] When reading from DB, display CRC-32 and all Vendor Extensions (sonic-net#1497) [Joe LeVeque]
47d1a14 - 2021-03-12 : [generate-dump] Remove Arista specific logic (sonic-net#1482) [Samuel Angebault]
1260f90 - 2021-03-12 : [warm-reboot]: Check empty key before issuing redis hget (sonic-net#1496) [Vaibhav Hemant Dixit]
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
@smaheshm
[orchagent][port] In case of successful port creation set log level t…
fea7ade 
…o INFO (sonic-net#1500)

* [orchagent][port] In case of successful port creation set log level to NOTICE instead of ERR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stcheng stcheng stcheng approved these changes

Assignees
No one assigned
Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@padmanarayana @lguohan @stcheng