Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chassis] removed dependency between bgp and swss for chassis supervisor #15734

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

arlakshm
Copy link
Contributor

@arlakshm arlakshm commented Jul 6, 2023

Why I did it

Fixes #15667 and #13293

Work item tracking
  • Microsoft ADO 24472854:

How I did it

On chassis supervisor bgp feature is disabled in hostcfgd. The dependency between swss and bgp causes the bgp containers to start even though the feature is disabled.

How to verify it

Tests on chassis supervisor and LC

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@prsunny
Copy link
Contributor

prsunny commented Jul 7, 2023

lgtm, @Ndancejic for viz

@rlhui rlhui added the P0 Priority of the issue label Jul 12, 2023
@arlakshm
Copy link
Contributor Author

@lguohan, can you help merge this PR

@lguohan lguohan merged commit 4681703 into sonic-net:master Aug 7, 2023
23 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Aug 10, 2023
…sonic-net#15734)

Fixes sonic-net#15667 and sonic-net#13293

Work item tracking
Microsoft ADO 24472854:

How I did it
On chassis supervisor bgp feature is disabled in hostcfgd. The dependency between swss and bgp causes the bgp containers to start even though the feature is disabled.

How to verify it
Tests on chassis supervisor and LC
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #16099

yxieca pushed a commit that referenced this pull request Aug 11, 2023
…#15734) (#16099)

Fixes #15667 and #13293

Work item tracking
Microsoft ADO 24472854:

How I did it
On chassis supervisor bgp feature is disabled in hostcfgd. The dependency between swss and bgp causes the bgp containers to start even though the feature is disabled.

How to verify it
Tests on chassis supervisor and LC

Co-authored-by: Arvindsrinivasan Lakshmi Narasimhan <55814491+arlakshm@users.noreply.github.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #16135

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Aug 14, 2023
…sonic-net#15734)

Fixes sonic-net#15667 and sonic-net#13293

Work item tracking
Microsoft ADO 24472854:

How I did it
On chassis supervisor bgp feature is disabled in hostcfgd. The dependency between swss and bgp causes the bgp containers to start even though the feature is disabled.

How to verify it
Tests on chassis supervisor and LC
StormLiangMS pushed a commit that referenced this pull request Aug 14, 2023
…#15734) (#16135)

Fixes #15667 and #13293

Work item tracking
Microsoft ADO 24472854:

How I did it
On chassis supervisor bgp feature is disabled in hostcfgd. The dependency between swss and bgp causes the bgp containers to start even though the feature is disabled.

How to verify it
Tests on chassis supervisor and LC

Co-authored-by: Arvindsrinivasan Lakshmi Narasimhan <55814491+arlakshm@users.noreply.github.com>
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
…sonic-net#15734)

Fixes sonic-net#15667 and sonic-net#13293

Work item tracking
Microsoft ADO 24472854:

How I did it
On chassis supervisor bgp feature is disabled in hostcfgd. The dependency between swss and bgp causes the bgp containers to start even though the feature is disabled.

How to verify it
Tests on chassis supervisor and LC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
9 participants