Revert "[yang][dhcp_server] Add dhcp_server_ipv4 yang model" #16322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaqiangz
approved these changes
Aug 29, 2023
dgsudharsan
approved these changes
Aug 29, 2023
|
Do we need to take it to 202305? if so, please add label |
@liat-grozovik This is not required since the original PR was not cherry-picked to 202305 |
qiluo-msft
approved these changes
Aug 29, 2023
11 tasks
yxieca
pushed a commit
that referenced
this pull request
Aug 31, 2023
Why I did it #15955 import sonic-vlan in yang model, which would cause YANG backlink issue. So #15955 was reverted by #16322. This PR is re-submitted of #15955 without import sonic-vlan. Add yang model for IPv4 DHCP Server. How I did it Add yang model for IPv4 DHCP Server. Add four new tables: DHCP_SERVER_IPV4, DHCP_SERVER_IPV4_CUSTOMIZED_OPTIONS, DHCP_SERVER_IPV4_RANGE, DHCP_SERVER_IPV4_PORT. Add related unit test. HLD: https://github.com/yaqiangz/SONiC/blob/master_dhcp_server_hld/doc/dhcp_server/port_based_dhcp_server_high_level_design.md#rev-01 How to verify it Build sonic_yang_models packages.
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
…t#15955)" (sonic-net#16322) This reverts commit 44d52db.
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
Why I did it sonic-net#15955 import sonic-vlan in yang model, which would cause YANG backlink issue. So sonic-net#15955 was reverted by sonic-net#16322. This PR is re-submitted of sonic-net#15955 without import sonic-vlan. Add yang model for IPv4 DHCP Server. How I did it Add yang model for IPv4 DHCP Server. Add four new tables: DHCP_SERVER_IPV4, DHCP_SERVER_IPV4_CUSTOMIZED_OPTIONS, DHCP_SERVER_IPV4_RANGE, DHCP_SERVER_IPV4_PORT. Add related unit test. HLD: https://github.com/yaqiangz/SONiC/blob/master_dhcp_server_hld/doc/dhcp_server/port_based_dhcp_server_high_level_design.md#rev-01 How to verify it Build sonic_yang_models packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #15955
There is an issue tracking it: https://github.com/sonic-net/sonic-buildimage/issues/9312
We should avoid import sonic-vlan which will cause YANG backlink issue.