Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hash] Add ECMP/LAG Hash Algorithm YANG model #17079

Merged
merged 2 commits into from
Nov 20, 2023
Merged

[hash] Add ECMP/LAG Hash Algorithm YANG model #17079

merged 2 commits into from
Nov 20, 2023

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented Nov 2, 2023 •
edited by liat-grozovik
Loading

HLD: sonic-net/SONiC#1501

Why I did it

  • Added YANG model as part of Generic Hash feature development
Work item tracking
  • N/A

How I did it

  • Added YANG model

How to verify it

  1. Add UT
  2. Verified manually with the feature qualification

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

  • master

Description for the changelog

  • Added hashing algorithm configuration

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

      .---.        .-----------
     /     \  __  /    ------
    / /     \(  )/    -----
   //////   ' \/ `   ---
  //// / // :    : ---
 // /   /  /`    '--
//          //..\\
       ====UU====UU====
           '//||\\`
             ''``

@nazariig
[hash]: Add ECMP/LAG Hash Algorithm YANG model.
2868c0b 
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig
[hash]: Handle review comments.
2d4617d 
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig nazariig mentioned this pull request Nov 2, 2023
Merged
@liat-grozovik
Copy link
Collaborator

@dgsudharsan can you please help to review this one as well? based on your approval and Stepan i will merge this PR

@dgsudharsan dgsudharsan added the YANG YANG model related changes label Nov 20, 2023
@liat-grozovik liat-grozovik merged commit c99ec1f into sonic-net:master Nov 20, 2023
19 checks passed
@liat-grozovik liat-grozovik changed the title [hash]: Add ECMP/LAG Hash Algorithm YANG model [hash] Add ECMP/LAG Hash Algorithm YANG model Nov 20, 2023
@mssonicbld
Copy link
Collaborator

@nazariig PR conflicts with 202311 branch

@yxieca
Copy link
Contributor

yxieca commented Mar 21, 2024

@nazariig can you help create PR for 202311 branch?

@nazariig
Copy link
Collaborator Author

@yxieca already part of 202311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgsudharsan dgsudharsan dgsudharsan approved these changes

@stepanblyschak stepanblyschak stepanblyschak approved these changes

@liat-grozovik liat-grozovik liat-grozovik approved these changes

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft qiluo-msft is a code owner

@volodymyrsamotiy volodymyrsamotiy Awaiting requested review from volodymyrsamotiy

@bingwang-ms bingwang-ms Awaiting requested review from bingwang-ms

@prsunny prsunny Awaiting requested review from prsunny

Assignees
No one assigned
Labels
Approved for 202311 Branch Included in 202311 Branch Request for 202311 Branch YANG YANG model related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nazariig @liat-grozovik @mssonicbld @yxieca @dgsudharsan @stepanblyschak