Fix a bug that default graph might be missing when generating minimal config #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
approved these changes
May 29, 2018
|
do you know why the default minigraph is not there? |
lguohan
approved these changes
May 29, 2018
|
Because it was never copied - see line 71. |
renukamanavalan
added a commit
to renukamanavalan/sonic-buildimage
that referenced
this pull request
Aug 24, 2021
* e12c1c8 (origin/master, origin/HEAD) disk_check: Script updated (sonic-net#1747) * 27502f0 [dhcp_relay] Update CLI reference document and add a new API for ip address type (sonic-net#1717) * cd3ee78 [Config] Update config command of kdump (sonic-net#1700) * 4cb3b72 [Show] Update the subcommands of Kdump. (sonic-net#1682) * c03342f [sfputil] Gracefully handle improper 'specification_compliance' field (sonic-net#1741) * 103de86 [CLI][MPLS][Show] Fixed show and config mpls cli bug where invalid interfaces would pasâsonic-net#1770) * 04cc047 [route_check] Filter out VNET routes (sonic-net#1612) * 9395ebd [show][platform] Revise chassis info fallback to only fall back on pmon crash (sonic-net#1751)
5 tasks
lguohan
pushed a commit
that referenced
this pull request
Aug 25, 2021
* e12c1c8 (origin/master, origin/HEAD) disk_check: Script updated (#1747) * 27502f0 [dhcp_relay] Update CLI reference document and add a new API for ip address type (#1717) * cd3ee78 [Config] Update config command of kdump (#1700) * 4cb3b72 [Show] Update the subcommands of Kdump. (#1682) * c03342f [sfputil] Gracefully handle improper 'specification_compliance' field (#1741) * 103de86 [CLI][MPLS][Show] Fixed show and config mpls cli bug where invalid interfaces would pasâ#1770) * 04cc047 [route_check] Filter out VNET routes (#1612) * 9395ebd [show][platform] Revise chassis info fallback to only fall back on pmon crash (#1751)
vivekrnv
added a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Nov 8, 2021
48035d75 [202012] [techsupport] Techsupport Error Reporting pending fixes (sonic-net#1854) 8b2ec09a Fix log_ssd_health hang issue (sonic-net#1904) ac9c4254 Fix the option missing in kernel config issue (sonic-net#1888) 5cc9417a disk_check: Script updated to run good in 201811 & 201911 (sonic-net#1747) Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
qiluo-msft
pushed a commit
that referenced
this pull request
Nov 9, 2021
Submodule update for sonic-utilties ``` 48035d75 [202012] [techsupport] Techsupport Error Reporting pending fixes (#1854) 8b2ec09a Fix log_ssd_health hang issue (#1904) ac9c4254 Fix the option missing in kernel config issue (#1888) 5cc9417a disk_check: Script updated to run good in 201811 & 201911 (#1747) ```
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
…LAG (sonic-net#1747) * [sonic-swss:TPID CONFIG]Added Orchagent TPID config support for Port/LAG Signed-off-by: Gen-Hwa Chiang <gechiang@microsoft.com> * Changed per review comment to move TPID capability query under switchorch class
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
…1747) What I did Have independent subdirs for each mounted dir to avoid any collisions of files/dirs by same name. Adopt for older version of python3 How I did it Changes: Individual subdirs for each dir to be mounted subprocess args made compatible with older version of python3 (tested in version 3.5.3) How to verify it Simulate read-only state Run this script Test ssh via new tacacs user (who had not logged in earlier)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
When "N/A" is received from DHCP response, updategraph service will try to generate a minimal configuration which contains only HWSKU and other device metadata. However this process will fail when there is no minigraph in /etc/sonic/ folder. This PR fix the bug.
- How I did it
Copy default minigraph when there is no minigraph in /etc/sonic/ before generating minimal configuration.