Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC] test cherry-pick Fix when set TACACS to "tacacs+, local" user can run blocked command with local permission issue. #17754

Draft
wants to merge 2 commits into
base: 202205
Choose a base branch
from
+2 −1
Draft

[POC] test cherry-pick Fix when set TACACS to "tacacs+, local" user can run blocked command with local permission issue. #17754

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d22b42
Fix command reject by tacacs server but still can run with local perm…
liuh-80 Jan 11, 2024
df59c4c
Revert unecessary change
liuh-80 Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/tacacs/bash_tacplus/bash_tacplus.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,8 +471,9 @@ int on_shell_execve (char *user, int shell_level, char *cmd, char **argv)
fprintf(stdout, "%s not authorized by TACACS+ with given arguments, not executing\n", cmd);
break;
default:
// when command reject by server, authorization will failed immediately
fprintf(stdout, "%s authorize failed by TACACS+ with given arguments, not executing\n", cmd);
break;
return ret;
}

if ((tacacs_ctrl & AUTHORIZATION_FLAG_LOCAL) == 0) {
Expand Down