Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:17043] [staticroutebfd] fix an error in error logging (#17043) #17985

Merged
merged 1 commit into from
Feb 2, 2024

Commits on Feb 2, 2024

  1. [staticroutebfd] fix an error in error logging (sonic-net#17043)

    Why I did it
    Fix an error in the log_err call.
    this error can be triggered by an invalid static route key. usually the code cannot go here with normal config file. but hit this issue with an invalid key by manual testing with redis-cli directly. the file is scanned by Python lint to prevent such errors.
    
    Work item tracking
    Microsoft ADO ():26250268
    
    How I did it
    fix the format error.
    
    How to verify it
    1, ran pylint to check the design, make sure no such error in the design file.
    2, wrote a separate python program to verify the log call.
    In the current logging related testing, usually use patch/mock for logging. for this specific error, could not trigger it if we call mock function instead the real function in the design. so need to do lint checking for code change.
    baorliu authored and mssonicbld committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    0f9febd View commit details
    Browse the repository at this point in the history