Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sonic-cli] add a new cli to host environment. #1819

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[sonic-cli] add a new cli to host environment. #1819

wants to merge 1 commit into from

Conversation

yongcanwang00
Copy link

  • What I did
    Add a new cli to host environment.
  • How I did it
    Add related cmake processing.
    Make a shared path between host and Quagga. CLI uses this path to connect vtysh server of quagga.
  • How to verify it
    Type cli on linux.

@yongcanwang00 yongcanwang00 mentioned this pull request Jun 27, 2018
Open
@yongcanwang00
Copy link
Author

Shuotian, How to retest it?

@jleveque
Copy link
Contributor

jleveque commented Aug 20, 2018 •
edited

@yongcanwang00: "Retest this please" is a special comment which causes our Jenkins build system to start a new set of check builds. It was not intended as a request for you.

@haile21
Copy link

haile21 commented Dec 21, 2019

Hi yongcanwang!
where can I get the source code,please??

@yongcanwang00
Copy link
Author

yongcanwang00 commented Dec 23, 2019 via email

@haile21
Copy link

haile21 commented Dec 23, 2019 via email

@yongcanwang00
Copy link
Author

yongcanwang00 commented Dec 23, 2019 via email

@haile21
Copy link

haile21 commented Dec 23, 2019 via email

@haile21
Copy link

haile21 commented Dec 24, 2019 via email

@haile21
Copy link

haile21 commented Dec 24, 2019 via email

@haile21
Copy link

haile21 commented Dec 25, 2019 via email

@yongcanwang00
Copy link
Author

yongcanwang00 commented Dec 25, 2019 via email

@haile21
Copy link

haile21 commented Feb 19, 2020

https://github.com/yongcanwang00/sonic-utilities/tree/sonic_cli is returning 404!!

@haile21
Copy link

haile21 commented Feb 19, 2020

what happened with the following link please?
https://github.com/yongcanwang00/sonic-utilities/tree/sonic_cli

@haile21
Copy link

haile21 commented Feb 21, 2020

hi Yong can!!
can I know why the link below is not available,please? returning 404
https://github.com/yongcanwang00/sonic-utilities/tree/sonic_cli
thank you!!

@haile21
Copy link

haile21 commented Mar 13, 2020

OptiPlex-790# configure terminal

OptiPlex-790(config)# username sonicuser secret md5 ***** role admin
sudo: sw: command not found

stephenxs added a commit to stephenxs/sonic-buildimage that referenced this pull request Jul 29, 2021
@stephenxs
[sonic-swss][202012] Update submodule
43e057d 
f54b7d0b [Dynamic Buffer Calc][202012]Bug fix: Don't create lossless buffer profile for active ports without speed configured (sonic-net#1820)
ac7f5cff Td2: Reclaim buffer from unused ports (sonic-net#1830)
04105a4b [debugcounterorch] check if counter type is supported before querying (sonic-net#1789)
a67d8af6 [202012][portsorch] fix errors when moving port from one lag to another. (sonic-net#1819)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
stepanblyschak added a commit to stepanblyschak/sonic-buildimage that referenced this pull request Nov 1, 2021
@stepanblyschak
[sonic-utilities] update submodule
4be5904 
```
ca728b8 [config] fix interface IPv6 address removal. (sonic-net#1819)
0665d6f VxLAN Tunnel Counters and Rates implementation (sonic-net#1748)
80a10dc Fix log_ssd_health hang issue (sonic-net#1904)
ea4a730 [config][cbf] Added config commands for CBF (sonic-net#1799)
02ce8d6 [sonic-package-manager] update FEATURE entries on upgrade (sonic-net#1803)
9f123c0 [generate_dump] remove secrets from dump files (sonic-net#1886)
3a8ab73 [fwutil] Add `fwutil update all` to support the automatic platform component fw updates (sonic-net#1242)
776fddf [sonic-package-manager] code style fixes and enhancements (sonic-net#1802)
f53baac [watermarkstat] Fix for error in processing empty array from couters db (sonic-net#1810)
0b2536b Generic_upater: Apply JSON change (sonic-net#1856)
```

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
liat-grozovik pushed a commit that referenced this pull request Nov 2, 2021
@stepanblyschak
[sonic-utilities] update submodule (#9137)
9a143ae 
```
ca728b8 [config] fix interface IPv6 address removal. (#1819)
0665d6f VxLAN Tunnel Counters and Rates implementation (#1748)
80a10dc Fix log_ssd_health hang issue (#1904)
ea4a730 [config][cbf] Added config commands for CBF (#1799)
02ce8d6 [sonic-package-manager] update FEATURE entries on upgrade (#1803)
9f123c0 [generate_dump] remove secrets from dump files (#1886)
3a8ab73 [fwutil] Add `fwutil update all` to support the automatic platform component fw updates (#1242)
776fddf [sonic-package-manager] code style fixes and enhancements (#1802)
f53baac [watermarkstat] Fix for error in processing empty array from couters db (#1810)
0b2536b Generic_upater: Apply JSON change (#1856)
```

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
judyjoseph added a commit that referenced this pull request Nov 3, 2021
@judyjoseph
Update sonic-utilities submodule
5f2d926 
57de13b [config] fix interface IPv6 address removal. (#1819) (#1909)
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022
@stepanblyschak
[config] fix interface IPv6 address removal. (sonic-net#1819)
ca728b8 
Current code takes an input from the user, converts the IPv6 string to lower letters and removes lower case IPv6 string from CONFIG DB. This is a bug since, according to the schema CONFIG DB is case insensitive for IPv6 address.

- What I did
Fixed CLI for removing IPv6 address.
Issue is that below command does not work if IP address is written in upper case in CONFIG DB, like this: FC00::1/64.
'config interface ip remove Ethernet0 FC00::1/64'

- How I did it
Make it case insensitive
Relaxed the validation of IP address, a built-in validation from ipaddress package in python is used.
Refactored interface_ipaddr_dependent_on_interface -> get_interface_ipaddresses
Separated some functions (has_static_routes_attached, flush_ip_neigh_in_kernel, can_remove_router_interface, remove_router_interface_ip_address, remove_router_interface, is_management_interface)

- How to verify it
Run UT. Try to reproduce the scenario described above.

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft qiluo-msft is a code owner

@xumia xumia Awaiting requested review from xumia xumia is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yongcanwang00 @jleveque @haile21 @stcheng