Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[device/dx010] configuration port index start from 1 #1927

Merged
merged 6 commits into from Aug 16, 2018
Merged

[device/dx010] configuration port index start from 1 #1927

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5bf5985
update sfputil, port indext start from 1
pphuchar Aug 10, 2018
f77edc7
DX010 update SKUs port config index
pphuchar Aug 10, 2018
8f165e5
Update dx010 sfputil plugin
pphuchar Aug 10, 2018
6c4e282
Remove new line at the end of port_config.ini
pphuchar Aug 14, 2018
79838d5
Add get_transceiver_change_event method
pphuchar Aug 14, 2018
5db2123
Fix unintended line breaks
pphuchar Aug 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion device/celestica/x86_64-cel_seastone-r0/plugins/sfputil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ def __init__(self):

for x in range(self.PORT_START, self.PORT_END + 1):
if self.port_start == 1:
self.port_to_eeprom_mapping[x] = eeprom_path.format((x - 1) + 26)
self.port_to_eeprom_mapping[
x] = eeprom_path.format((x - 1) + 26)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line break looks like an accident to me. Can you fix it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 5db2123

else:
self.port_to_eeprom_mapping[x] = eeprom_path.format(x + 26)
SfpUtilBase.__init__(self)
Expand Down Expand Up @@ -203,3 +204,6 @@ def reset(self, port_num):
reg_file.close()

return True

def get_transceiver_change_event(self, timeout=0):
raise NotImplementedError