Add get_graph service to fetch minigraph automatically #288

taoyl-ms · 2017-02-10T04:45:22Z

Add a functionality to get SNMP community from DHCP (option 224)
Add a functionality to get minigraph from http service instead of using default minigraph
- The url for graph service is passed through DHCP option 225
- This feature is by default disabled. Modify rule/config to enable it on build time, or modify /etc/sonic/graph_service_url on run time.
Fix a bug that getting hostname from DHCP is not working correctly

svc-acs · 2017-02-10T09:47:01Z

No test results found.
#Closed

lguohan · 2017-02-10T15:47:41Z

files/image_config/get_graph/get_graph

+fi
+
+HOSTNAME=`hostname -s`
+GRAPH_URL=`sed "s/{{\s*hostname\s*}}/$HOSTNAME/g" /etc/sonic/graph_service_url`


can you use jinji2 template to instead of sed? #Resolved

We don't have j2 installed in base image now. Do you want to install it?

In reply to: 100561378 [](ancestors = 100561378)

lguohan · 2017-02-10T15:58:11Z

can you add description for this commit to explain the purpose of this commit? #Resolved

lguohan · 2017-02-10T15:59:18Z

files/image_config/interfaces/init_interfaces

+#
+# The management network interface
+auto eth0
+iface eth0 inet dhcp


isn't this the default debian behavior? do we need to override? #WontFix

Not quite sure whether this is the default behavior. Why not override it explicitly to make things clearer though?

In reply to: 100564200 [](ancestors = 100564200)

lguohan · 2017-02-10T16:04:17Z

files/image_config/get_graph/get_graph

+while [ ! -f /etc/sonic/graph_service_url ]; do
+    echo "No graph service url speficied, waiting for DHCP response..."
+    sleep 1
+done


where is the graph service configuration file to enable/disable graph downloading? #Resolved

/etc/sonic/graph_service_url. A non-existing file means dhcp, and an exisiting file writing "disabled" means disabled.

In reply to: 100565302 [](ancestors = 100565302)

lguohan · 2017-02-10T16:04:56Z

files/image_config/get_graph/get_graph

+if [ -f /etc/sonic/minigraph.xml ]; then
+    echo "Renaming minigraph.xml to minigraph.old"
+    rm -rf /etc/sonic/minigraph.old
+    mv /etc/sonic/minigraph.xml /etc/sonic/minigraph.old


mv /etc/sonic/minigraph.xml /etc/sonic/minigraph.old [](start = 4, length = 52)

this will replace the old, no need to rm -rf #Resolved

lguohan · 2017-02-10T16:12:55Z

files/image_config/get_graph/get_graph

+echo "Getting minigraph from $GRAPH_URL"
+
+while true; do
+    wget -T 15 -c $GRAPH_URL -O /etc/sonic/minigraph.xml && break


wget [](start = 4, length = 4)

I think we should use curl here, the package is much smaller. #Resolved

lguohan · 2017-02-10T16:16:13Z

files/image_config/get_graph/get_graph

+#!/bin/bash
+
+while [ ! -f /etc/sonic/graph_service_url ]; do
+    echo "No graph service url speficied, waiting for DHCP response..."


echo "No graph service url speficied, waiting for DHCP response..." [](start = 4, length = 67)

I am not sure where I am able to see the message? is it in syslog? #ByDesign

Yes, syslog.

In reply to: 100567923 [](ancestors = 100567923)

lguohan · 2017-02-10T16:16:28Z

files/image_config/get_graph/get_graph

+echo "Getting minigraph from $GRAPH_URL"
+
+while true; do
+    wget -T 15 -c $GRAPH_URL -O /etc/sonic/minigraph.xml && break


wget -T 15 -c $GRAPH_URL -O /etc/sonic/minigraph.xml && break [](start = 4, length = 61)

print message for each try. #WontFix

wget itself will print messages.

In reply to: 100567987 [](ancestors = 100567987)

lguohan · 2017-02-10T16:23:25Z

files/image_config/get_graph/get_graph.service

@@ -0,0 +1,12 @@
+[Unit]
+Description=get minigraph


get minigraph [](start = 12, length = 13)

Download minigraph from graph service #Resolved

lguohan · 2017-02-10T16:23:37Z

files/image_config/get_graph/get_graph.service

+
+[Service]
+Type=oneshot
+ExecStart=/usr/bin/get_graph


get_graph [](start = 19, length = 9)

updategraph #Resolved

lguohan · 2017-02-10T16:24:39Z

files/dhcp/sethostname

    hostname -F /etc/hostname
+    sed -i "/\s$current_host_name$/d" /etc/hosts
+    echo "127.0.0.1 $new_host_name" >> /etc/hosts
 fi


why are we changing this file at all? #ByDesign

From observation this bash will be called twice in a row sometimes, "oldhostname" -> "" and "" -> "newhostname". Old implementation is not working correctly under these cases.

In reply to: 100569696 [](ancestors = 100569696)

lguohan · 2017-02-12T21:47:30Z

rules/config

+# If set to y SONiC will get the minigraph from graph service. Graph service URL need to be 
+# passed through DHCP option 225.
+# If not set (default behavior) the default minigraph built into the image will be used.
+# ENABLE_DHCP_GRAPH_SERVICE = y


make the default behavior to n. #WontFix

all our other configs are using y vs commented. I guess we'd better make them consistent?

In reply to: 100705528 [](ancestors = 100705528)

lguohan · 2017-02-13T01:11:33Z

files/image_config/get_graph/get_graph.service

+ExecStart=/usr/bin/updategraph
+
+[Install]
+WantedBy=multi-user.target


can you also change the get_graph.service name to updategraph.service? #Resolved

lguohan · 2017-02-13T01:13:34Z

files/image_config/get_graph/updategraph

+fi
+
+HOSTNAME=`hostname -s`
+GRAPH_URL=`sed "s/{{\s*hostname\s*}}/$HOSTNAME/g" /etc/sonic/graph_service_url`


you can use config-engine to do that #Resolved

lguohan · 2017-02-13T01:16:57Z

files/dhcp/sethostname

+            echo $new_host_name > /etc/hostname
+            hostname -F /etc/hostname
+            sed -i "/\s$current_host_name$/d" /etc/hosts
+        echo "127.0.0.1 $new_host_name" >> /etc/hosts


echo "127.0.0.1 $new_host_name" >> /etc/hosts [](start = 8, length = 45)

this will likely introduce duplicate entry for 127.0.0.1 if there is already one with current host name.

The previous line will replace with new_host_name, and this line will add a new one. #ByDesign

please make make sure the indent is matching other lines.

In reply to: 100711735 [](ancestors = 100711735)

No the previous line is deleting the old entry instead of replace one.
I'm using delete+add instead of replacement to handle the case that previous hostname is not in the hosts file

In reply to: 100711735 [](ancestors = 100711735)

lguohan · 2017-02-13T01:23:37Z

files/dhcp/graphserviceurl

+        elif [ -n "$new_minigraph_service_url" ]; then
+            echo $new_minigraph_service_url > /etc/sonic/graph_service_url
+        else
+            echo "disabled" > /etc/sonic/graph_service_url


graph_service_url [](start = 41, length = 17)

rename to updategraph.conf since it is the configuration file for the upgradegraph srevice.

also the conf file format needs to defined. usually something like below

whether to enable/disable update graph service

enable=true|false

url

url = xxx xxx xxx

it is possible that the dhcp provide you multiple url to download. #Resolved

lguohan · 2017-02-13T01:30:00Z

files/dhcp/dhclient.conf

+
+option rfc3442-classless-static-routes code 121 = array of unsigned integer 8;
+option snmp-community code 224 = text;
+option minigraph-service-url code 225 = text;


minigraph-service-url [](start = 7, length = 21)

to simplify the name, we can use minigraph-url #Resolved

… in previous commit

lguohan · 2017-02-17T07:10:07Z

files/image_config/updategraph/updategraph

+    echo "enabled=false" >/etc/sonic/updategraph.conf
+fi
+
+. <(grep "=" /etc/sonic/updategraph.conf)


no need grep #Resolved

lguohan

comments

Use systemctl utility instead of service utility in config

912797e Support get_port_or_cage_type (sonic-net#288) d8abf47 Microsoft mandatory file (sonic-net#284) Signed-off-by: Stephen Sun <stephens@nvidia.com>

912797e Support get_port_or_cage_type (#288) d8abf47 Microsoft mandatory file (#284) Signed-off-by: Stephen Sun <stephens@nvidia.com>

…rm-common] advance submodule head linkmgrd: * e0fe1d4 2022-07-27 | TSA enhancement (sonic-net#98) (HEAD -> 202205) [Jing Zhang] utilities: * 7d7e15e 2022-07-18 | [vnet_route_check] Align DB data parse logic with format used by swsscommon API (sonic-net#2268) (HEAD -> 202205) [Volodymyr Samotiy] * b3d5d18 2022-07-20 | [MultiAsic] sudo reboot command doesn't gracefully stop Asic syncd# on multiasic platform (sonic-net#2258) [Marty Y. Lok] * 504ebe6 2022-07-08 | Add 'traffic_shift_away' option to config load_minigraph (sonic-net#2240) [tjchadaga] * 4079e4a 2022-06-20 | Gives cisco-8000 more flexibility to easily add subcommnads under show platform (sonic-net#2213) [Nathan Cohen] * 46443c6 2022-07-27 | Update db_migrator to support `PORT_QOS_MAP|global` (sonic-net#2205) [bingwang-ms] * d7fbdd6 2022-05-26 | fix for non-coherent cmis modules (sonic-net#2163) [qinchuanares] * 79b4439 2022-06-24 | [sfpshow/sfputil] Enhance sfpshow and sfputil to behavior correctly on RJ45 ports (sonic-net#2111) [Kebo Liu] swss: * 275f311 2022-07-26 | [DualToR] Handle race condition between tunnel_decap and mux orchestrator (sonic-net#2397) (HEAD -> 202205) [Devesh Pathak] * 47586e8 2022-07-22 | [EVPN]Fix missing Vlan member update notification in P2MP scenario (sonic-net#2388) [Sudharsan Dhamal Gopalarathnam] * 7d5c73f 2022-07-19 | [macsecmgr]: Fix cleanup macsec objs if container stop (sonic-net#2376) [Ze Gan] * c03996f 2022-07-17 | [orchagent]: Enhance initSaiPhyApi (sonic-net#2367) [andywongarista] * 57890d7 2022-07-27 | Fix for remote system interface not getting created (sonic-net#2364) [skeesara-nokia] * 1a93ec9 2022-07-13 | Orchagent changes for synchronizing npu/phy device Tx in the data path before enabling transceiver<CMIS compliant> Tx. (sonic-net#2277) [jaganbal-a] sairedis: * a4903be 2022-07-20 | Update PN with XPN support (sonic-net#1081) (HEAD -> 202205, github/202205) [Ze Gan] * 2cb5671 2022-07-27 | Add SAI_OBJECT_TYPE_TUNNEL object to break-before-make list (sonic-net#1075) [Vaibhav Hemant Dixit] platform-daemon: * 901c6a1 2022-06-28 | [CMIS]Improved 400G link bring up sequence (sonic-net#254) (HEAD -> 202205) [Prince George] platform-common: * f223b3f 2022-07-09 | Support get_port_or_cage_type (sonic-net#288) (HEAD -> 202205) [Stephen Sun] Signed-off-by: Ying Xie <ying.xie@microsoft.com>

…rm-common] advance submodule head (#11578) linkmgrd: * e0fe1d4 2022-07-27 | TSA enhancement (#98) (HEAD -> 202205) [Jing Zhang] utilities: * 7d7e15e 2022-07-18 | [vnet_route_check] Align DB data parse logic with format used by swsscommon API (#2268) (HEAD -> 202205) [Volodymyr Samotiy] * b3d5d18 2022-07-20 | [MultiAsic] sudo reboot command doesn't gracefully stop Asic syncd# on multiasic platform (#2258) [Marty Y. Lok] * 504ebe6 2022-07-08 | Add 'traffic_shift_away' option to config load_minigraph (#2240) [tjchadaga] * 4079e4a 2022-06-20 | Gives cisco-8000 more flexibility to easily add subcommnads under show platform (#2213) [Nathan Cohen] * 46443c6 2022-07-27 | Update db_migrator to support `PORT_QOS_MAP|global` (#2205) [bingwang-ms] * d7fbdd6 2022-05-26 | fix for non-coherent cmis modules (#2163) [qinchuanares] * 79b4439 2022-06-24 | [sfpshow/sfputil] Enhance sfpshow and sfputil to behavior correctly on RJ45 ports (#2111) [Kebo Liu] swss: * 275f311 2022-07-26 | [DualToR] Handle race condition between tunnel_decap and mux orchestrator (#2397) (HEAD -> 202205) [Devesh Pathak] * 47586e8 2022-07-22 | [EVPN]Fix missing Vlan member update notification in P2MP scenario (#2388) [Sudharsan Dhamal Gopalarathnam] * 7d5c73f 2022-07-19 | [macsecmgr]: Fix cleanup macsec objs if container stop (#2376) [Ze Gan] * c03996f 2022-07-17 | [orchagent]: Enhance initSaiPhyApi (#2367) [andywongarista] * 57890d7 2022-07-27 | Fix for remote system interface not getting created (#2364) [skeesara-nokia] * 1a93ec9 2022-07-13 | Orchagent changes for synchronizing npu/phy device Tx in the data path before enabling transceiver<CMIS compliant> Tx. (#2277) [jaganbal-a] sairedis: * a4903be 2022-07-20 | Update PN with XPN support (#1081) (HEAD -> 202205, github/202205) [Ze Gan] * 2cb5671 2022-07-27 | Add SAI_OBJECT_TYPE_TUNNEL object to break-before-make list (#1075) [Vaibhav Hemant Dixit] platform-daemon: * 901c6a1 2022-06-28 | [CMIS]Improved 400G link bring up sequence (#254) (HEAD -> 202205) [Prince George] platform-common: * f223b3f 2022-07-09 | Support get_port_or_cage_type (#288) (HEAD -> 202205) [Stephen Sun] Signed-off-by: Ying Xie <ying.xie@microsoft.com>

…rm-common] advance submodule head (sonic-net#11578) linkmgrd: * e0fe1d4 2022-07-27 | TSA enhancement (sonic-net#98) (HEAD -> 202205) [Jing Zhang] utilities: * 7d7e15e 2022-07-18 | [vnet_route_check] Align DB data parse logic with format used by swsscommon API (sonic-net#2268) (HEAD -> 202205) [Volodymyr Samotiy] * b3d5d18 2022-07-20 | [MultiAsic] sudo reboot command doesn't gracefully stop Asic syncd# on multiasic platform (sonic-net#2258) [Marty Y. Lok] * 504ebe6 2022-07-08 | Add 'traffic_shift_away' option to config load_minigraph (sonic-net#2240) [tjchadaga] * 4079e4a 2022-06-20 | Gives cisco-8000 more flexibility to easily add subcommnads under show platform (sonic-net#2213) [Nathan Cohen] * 46443c6 2022-07-27 | Update db_migrator to support `PORT_QOS_MAP|global` (sonic-net#2205) [bingwang-ms] * d7fbdd6 2022-05-26 | fix for non-coherent cmis modules (sonic-net#2163) [qinchuanares] * 79b4439 2022-06-24 | [sfpshow/sfputil] Enhance sfpshow and sfputil to behavior correctly on RJ45 ports (sonic-net#2111) [Kebo Liu] swss: * 275f311 2022-07-26 | [DualToR] Handle race condition between tunnel_decap and mux orchestrator (sonic-net#2397) (HEAD -> 202205) [Devesh Pathak] * 47586e8 2022-07-22 | [EVPN]Fix missing Vlan member update notification in P2MP scenario (sonic-net#2388) [Sudharsan Dhamal Gopalarathnam] * 7d5c73f 2022-07-19 | [macsecmgr]: Fix cleanup macsec objs if container stop (sonic-net#2376) [Ze Gan] * c03996f 2022-07-17 | [orchagent]: Enhance initSaiPhyApi (sonic-net#2367) [andywongarista] * 57890d7 2022-07-27 | Fix for remote system interface not getting created (sonic-net#2364) [skeesara-nokia] * 1a93ec9 2022-07-13 | Orchagent changes for synchronizing npu/phy device Tx in the data path before enabling transceiver<CMIS compliant> Tx. (sonic-net#2277) [jaganbal-a] sairedis: * a4903be 2022-07-20 | Update PN with XPN support (sonic-net#1081) (HEAD -> 202205, github/202205) [Ze Gan] * 2cb5671 2022-07-27 | Add SAI_OBJECT_TYPE_TUNNEL object to break-before-make list (sonic-net#1075) [Vaibhav Hemant Dixit] platform-daemon: * 901c6a1 2022-06-28 | [CMIS]Improved 400G link bring up sequence (sonic-net#254) (HEAD -> 202205) [Prince George] platform-common: * f223b3f 2022-07-09 | Support get_port_or_cage_type (sonic-net#288) (HEAD -> 202205) [Stephen Sun] Signed-off-by: Ying Xie <ying.xie@microsoft.com>

Related work items: sonic-net#284, sonic-net#288, sonic-net#624, sonic-net#630, sonic-net#640, sonic-net#2164, sonic-net#2206, sonic-net#2207, sonic-net#2233, sonic-net#2234, sonic-net#2238, sonic-net#8857, sonic-net#10034, sonic-net#10519, sonic-net#10685, sonic-net#10711, sonic-net#10987, sonic-net#10990, sonic-net#11047, sonic-net#11070, sonic-net#11117, sonic-net#11186, sonic-net#11207, sonic-net#11213, sonic-net#11215, sonic-net#11220, sonic-net#11221, sonic-net#11257, sonic-net#11291, sonic-net#11298, sonic-net#11301, sonic-net#11326, sonic-net#11333, sonic-net#11335, sonic-net#11341, sonic-net#11344, sonic-net#11347, sonic-net#11359, sonic-net#11366, sonic-net#11368, sonic-net#11370, sonic-net#11372, sonic-net#11375, sonic-net#11385, sonic-net#11386, sonic-net#11394, sonic-net#11397, sonic-net#11401, sonic-net#11402, sonic-net#11403, sonic-net#11405, sonic-net#11414

ed818f8 [PSU daemon] Support PSU power threshold checking (sonic-net#288) 707a720 [chassisd] update chassisd to write fabric and lc asics on sep erate table (sonic-net#311) e8c5657 [ycabled] fix exception-handling logic for ycabled (sonic-net#306) 905874d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (sonic-net#303) 510d330 Fix typo in xcvrd (sonic-net#313) 9ae551f [ycabled] add support for detach mode in 'active-active' topology (sonic-net#309) 82fc7a6 Added filtering logic to send filtered fields from DB event (sonic-net#307) 8a2dad9 [ycabled] fix no port/state returned by grpc server (sonic-net#308) 4ea12cf Fix xcvrd to support 400G ZR optic (sonic-net#293) 23b6970 [ycabled] fix naming error for error condition for CLI handling (sonic-net#302) 501abb2 [ycabled] add some exception catching logic to some vendor specific API's (sonic-net#301) 534f839 [ycabled] add support for getting grpc secerts via shared file (sonic-net#298) 3622aac Remove shell=True (sonic-net#300) 143422b add support to execute new ycable API's, add datetime field to mux_info (sonic-net#297) 6522c46 [ycabled] add notification for gRPC connection state transitions to IDLE/TRANSIENT_FAILURE (sonic-net#295) 4b3b238 Install libyang to azure pipeline (sonic-net#292) 8ff5f37 Use get() to fetch default value from dictionary for port admin_status sonic-net#286 b03cc74 [Xcvrd] Soak duplicate events and process only updated interested events (sonic-net#285) 3acb171 [ycable] cleanup logic for creating grpc future ready (sonic-net#289) ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (sonic-net#287) Signed-off-by: Stephen Sun <stephens@nvidia.com>

#12791) * Update submodule sonic-utilities 72b9cf9 [psushow & psuutil] Support PSU power threshold checking (#2326) dfdc92e Revert "Support the bandit check by GitHub Action (#2358)" (#2509) 85638b2 YANG Validation for ConfigDB Updates: DEVICE_METADATA, SNMP, SNMP_COMMUNITY tables (#2481) da44d71 YANG Validation for ConfigDB Updates: PORT_STORM_CONTROL, PORT_QOS_MAP, BUFFER_PROFILE, BUFFER_PG, BUFFER_QUEUE, BUFFER_POOL, FEATURE, DEFAULT_LOSSLESS_BUFFER_PARAMETER tables (# ba9b628 [sfp] Fix issue: Application Advertisement is not well formatted (#2491) Signed-off-by: Stephen Sun <stephens@nvidia.com> * Update submodule sonic-platform-daemons ed818f8 [PSU daemon] Support PSU power threshold checking (#288) 707a720 [chassisd] update chassisd to write fabric and lc asics on sep erate table (#311) e8c5657 [ycabled] fix exception-handling logic for ycabled (#306) 905874d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (#303) 510d330 Fix typo in xcvrd (#313) 9ae551f [ycabled] add support for detach mode in 'active-active' topology (#309) 82fc7a6 Added filtering logic to send filtered fields from DB event (#307) 8a2dad9 [ycabled] fix no port/state returned by grpc server (#308) 4ea12cf Fix xcvrd to support 400G ZR optic (#293) 23b6970 [ycabled] fix naming error for error condition for CLI handling (#302) 501abb2 [ycabled] add some exception catching logic to some vendor specific API's (#301) 534f839 [ycabled] add support for getting grpc secerts via shared file (#298) 3622aac Remove shell=True (#300) 143422b add support to execute new ycable API's, add datetime field to mux_info (#297) 6522c46 [ycabled] add notification for gRPC connection state transitions to IDLE/TRANSIENT_FAILURE (#295) 4b3b238 Install libyang to azure pipeline (#292) 8ff5f37 Use get() to fetch default value from dictionary for port admin_status #286 b03cc74 [Xcvrd] Soak duplicate events and process only updated interested events (#285) 3acb171 [ycable] cleanup logic for creating grpc future ready (#289) ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (#287) Signed-off-by: Stephen Sun <stephens@nvidia.com> * Update submodule sonic-platform-common 7c48be2 Add warning/critical thresholds for PSU power (#304) f5ba0d0 Add missing PM and VDM related EEPROM read (#326) 02dd597 implement CMIS set_laser_freq to support 100GHz grid space (#294) Signed-off-by: Stephen Sun <stephens@nvidia.com> * Revert "Update submodule sonic-platform-daemons" This reverts commit aea648b. Signed-off-by: Stephen Sun <stephens@nvidia.com>

Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com e474335 (HEAD -> master, origin/master, origin/HEAD) [ycabled] fix minor appl_db retrieving logic for update (#319) 9b84b58 Use github code scanning instead of LGTM (#316) f784ad7 Pass grid parameter while calling set_laser_freq (#317) ed818f8 [PSU daemon] Support PSU power threshold checking (#288) 707a720 (origin/202211) [chassisd] update chassisd to write fabric and lc asics on sep erate table (#311) e8c5657 [ycabled] fix exception-handling logic for ycabled (#306) 905874d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (#303) 510d330 Fix typo in xcvrd (#313) 9ae551f [ycabled] add support for detach mode in 'active-active' topology (#309) The above commits are added to sonic-platform-daemons

sonic-net#12791) * Update submodule sonic-utilities 72b9cf9 [psushow & psuutil] Support PSU power threshold checking (sonic-net#2326) dfdc92e Revert "Support the bandit check by GitHub Action (sonic-net#2358)" (sonic-net#2509) 85638b2 YANG Validation for ConfigDB Updates: DEVICE_METADATA, SNMP, SNMP_COMMUNITY tables (sonic-net#2481) da44d71 YANG Validation for ConfigDB Updates: PORT_STORM_CONTROL, PORT_QOS_MAP, BUFFER_PROFILE, BUFFER_PG, BUFFER_QUEUE, BUFFER_POOL, FEATURE, DEFAULT_LOSSLESS_BUFFER_PARAMETER tables (# ba9b628 [sfp] Fix issue: Application Advertisement is not well formatted (sonic-net#2491) Signed-off-by: Stephen Sun <stephens@nvidia.com> * Update submodule sonic-platform-daemons ed818f8 [PSU daemon] Support PSU power threshold checking (sonic-net#288) 707a720 [chassisd] update chassisd to write fabric and lc asics on sep erate table (sonic-net#311) e8c5657 [ycabled] fix exception-handling logic for ycabled (sonic-net#306) 905874d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (sonic-net#303) 510d330 Fix typo in xcvrd (sonic-net#313) 9ae551f [ycabled] add support for detach mode in 'active-active' topology (sonic-net#309) 82fc7a6 Added filtering logic to send filtered fields from DB event (sonic-net#307) 8a2dad9 [ycabled] fix no port/state returned by grpc server (sonic-net#308) 4ea12cf Fix xcvrd to support 400G ZR optic (sonic-net#293) 23b6970 [ycabled] fix naming error for error condition for CLI handling (sonic-net#302) 501abb2 [ycabled] add some exception catching logic to some vendor specific API's (sonic-net#301) 534f839 [ycabled] add support for getting grpc secerts via shared file (sonic-net#298) 3622aac Remove shell=True (sonic-net#300) 143422b add support to execute new ycable API's, add datetime field to mux_info (sonic-net#297) 6522c46 [ycabled] add notification for gRPC connection state transitions to IDLE/TRANSIENT_FAILURE (sonic-net#295) 4b3b238 Install libyang to azure pipeline (sonic-net#292) 8ff5f37 Use get() to fetch default value from dictionary for port admin_status sonic-net#286 b03cc74 [Xcvrd] Soak duplicate events and process only updated interested events (sonic-net#285) 3acb171 [ycable] cleanup logic for creating grpc future ready (sonic-net#289) ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (sonic-net#287) Signed-off-by: Stephen Sun <stephens@nvidia.com> * Update submodule sonic-platform-common 7c48be2 Add warning/critical thresholds for PSU power (sonic-net#304) f5ba0d0 Add missing PM and VDM related EEPROM read (sonic-net#326) 02dd597 implement CMIS set_laser_freq to support 100GHz grid space (sonic-net#294) Signed-off-by: Stephen Sun <stephens@nvidia.com> * Revert "Update submodule sonic-platform-daemons" This reverts commit aea648b. Signed-off-by: Stephen Sun <stephens@nvidia.com>

#12791) * Update submodule sonic-utilities 72b9cf9 [psushow & psuutil] Support PSU power threshold checking (#2326) dfdc92e Revert "Support the bandit check by GitHub Action (#2358)" (#2509) 85638b2 YANG Validation for ConfigDB Updates: DEVICE_METADATA, SNMP, SNMP_COMMUNITY tables (#2481) da44d71 YANG Validation for ConfigDB Updates: PORT_STORM_CONTROL, PORT_QOS_MAP, BUFFER_PROFILE, BUFFER_PG, BUFFER_QUEUE, BUFFER_POOL, FEATURE, DEFAULT_LOSSLESS_BUFFER_PARAMETER tables (# ba9b628 [sfp] Fix issue: Application Advertisement is not well formatted (#2491) Signed-off-by: Stephen Sun <stephens@nvidia.com> * Update submodule sonic-platform-daemons ed818f8 [PSU daemon] Support PSU power threshold checking (#288) 707a720 [chassisd] update chassisd to write fabric and lc asics on sep erate table (#311) e8c5657 [ycabled] fix exception-handling logic for ycabled (#306) 905874d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (#303) 510d330 Fix typo in xcvrd (#313) 9ae551f [ycabled] add support for detach mode in 'active-active' topology (#309) 82fc7a6 Added filtering logic to send filtered fields from DB event (#307) 8a2dad9 [ycabled] fix no port/state returned by grpc server (#308) 4ea12cf Fix xcvrd to support 400G ZR optic (#293) 23b6970 [ycabled] fix naming error for error condition for CLI handling (#302) 501abb2 [ycabled] add some exception catching logic to some vendor specific API's (#301) 534f839 [ycabled] add support for getting grpc secerts via shared file (#298) 3622aac Remove shell=True (#300) 143422b add support to execute new ycable API's, add datetime field to mux_info (#297) 6522c46 [ycabled] add notification for gRPC connection state transitions to IDLE/TRANSIENT_FAILURE (#295) 4b3b238 Install libyang to azure pipeline (#292) 8ff5f37 Use get() to fetch default value from dictionary for port admin_status #286 b03cc74 [Xcvrd] Soak duplicate events and process only updated interested events (#285) 3acb171 [ycable] cleanup logic for creating grpc future ready (#289) ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (#287) Signed-off-by: Stephen Sun <stephens@nvidia.com> * Update submodule sonic-platform-common 7c48be2 Add warning/critical thresholds for PSU power (#304) f5ba0d0 Add missing PM and VDM related EEPROM read (#326) 02dd597 implement CMIS set_laser_freq to support 100GHz grid space (#294) Signed-off-by: Stephen Sun <stephens@nvidia.com> * Revert "Update submodule sonic-platform-daemons" This reverts commit aea648b. Signed-off-by: Stephen Sun <stephens@nvidia.com>

…11 branch (#13203) Why I did it advance sonic-platform-daemons submodule for 202211 branch a35b57d - (HEAD, origin/202211) Remove TODO comments which are no longer needed (Support centec platform #325) (3 days ago) [Junchao-Mellanox] 3a3726b - [thermalctld] fix some redundant removal of state DB tables (configurations are re-generated across reboots #315) (3 days ago) [vdahiya12] c5afac0 - Add new fields to status/dom_sensor/pm tables in STATE_DB for CMIS/C-CMIS (Combine alias_map.json with port_config.ini #304) (3 days ago) [longhuan-cisco] 1a338d4 - Create TRANSCEIVER_DOM_THRESHOLD table in state DB (Fix the reference in docker-snmp-sv2 to deprecated alias_map.json #320) (3 days ago) [mihirpat1] 7c77907 - Remove the argument that is causing the xcvrd to crash (ingrasys-s9100: Add ingrasys switch s9100 #318) (3 days ago) [Vivek] 5a70e7f - [ycabled] fix minor appl_db retrieving logic for update (dockers/docker-snmp-sv2/config.sh still references deprecated alias_map.json file #319) (3 days ago) [vdahiya12] b669533 - Use github code scanning instead of LGTM (Consolidate device-specific files; install as a Debian package #316) (3 days ago) [Liu Shilong] d3c6739 - Pass grid parameter while calling set_laser_freq ([swss]: update sonic-swss to fix buffer configuration on mlnx platform #317) (3 days ago) [mihirpat1] 778f843 - [PSU daemon] Support PSU power threshold checking (Add get_graph service to fetch minigraph automatically #288) (9 days ago) [Stephen Sun] 707a720 - [chassisd] update chassisd to write fabric and lc asics on sep erate table (ingrasys-s9100: Add ingrasys switch s9100 #311) (8 weeks ago) [arlakshm] e8c5657 - [ycabled] fix exception-handling logic for ycabled (Move sysDescription to /etc/snmp #306) (8 weeks ago) [vdahiya12] 905874d - [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (Disable BCM54616S MII isolate mode #303) (9 weeks ago) [vdahiya12] 510d330 - Fix typo in xcvrd ([platform] Add support configurations files for DCS-7060CX-32S #313) (9 weeks ago) [Junchao-Mellanox] 9ae551f - [ycabled] add support for detach mode in 'active-active' topology (minigraph.py crashed when no png is in the minigraph #309) (2 months ago) [vdahiya12] How I did it How to verify it

* Support get_port_or_cage_type The API returns the masks of all types of port or cage that can be supported on the port All the types are defined in sfp_base.SfpBase Signed-off-by: Stephen Sun <stephens@nvidia.com> * Add comments to explain the types Signed-off-by: Stephen Sun <stephens@nvidia.com>

taoyl-ms added 2 commits February 10, 2017 01:28

Add a service to fetch minigraph automatically

128d31a

Fix typo

9678062

lguohan reviewed Feb 10, 2017

View reviewed changes

taoyl-ms added 5 commits February 10, 2017 22:52

Add config option to disable DHCP graph service

71dfb98

Modify get_graph service according to CR

64942c8

Merge branch 'master' into taoyl/getgraph

dd8a3ff

Use curl instead of wget

4c4b8e7

Ignore DHCP message when graph_service_url file already exists

e79ea20

lguohan reviewed Feb 12, 2017

View reviewed changes

lguohan reviewed Feb 13, 2017

View reviewed changes

taoyl-ms added 4 commits February 15, 2017 03:36

Update according to CR comments

aad5f39

Use config-engine instead of sed for graph url render

3a972f6

Rename graph_service_url to updategraph.conf and fix a bug introduced…

02d8676

… in previous commit

Change updategraph.conf schema for extensibility

33277c4

lguohan reviewed Feb 17, 2017

View reviewed changes

lguohan requested changes Feb 17, 2017

View reviewed changes

Modification according to PR comments

fb0c25c

lguohan approved these changes Feb 17, 2017

View reviewed changes

taoyl-ms merged commit ea372cc into sonic-net:master Feb 17, 2017

sihuihan88 mentioned this pull request Jul 25, 2018

[sonic-utilities]: update submodule #1871

Merged

Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019

Merge pull request sonic-net#288 from pavel-shirshov/pavelsh/systemd

7311bff

Use systemctl utility instead of service utility in config

madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020

Fix port speed validation (sonic-net#288)

eaccf67

dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020

Add support for fdb flush in sairedis (sonic-net#288)

f8b9385

liat-grozovik pushed a commit that referenced this pull request Jul 11, 2022

[submodule] Advance sonic-platform-common pointer (#11401)

e1f2516

912797e Support get_port_or_cage_type (#288) d8abf47 Microsoft mandatory file (#284) Signed-off-by: Stephen Sun <stephens@nvidia.com>

yxieca mentioned this pull request Jul 28, 2022

[202205][linkmgrd][utilities][swss][sairedis][platform-daemon][platform-common] advance submodule head #11578

Merged

vdahiya12 mentioned this pull request Nov 30, 2022

[sonic-platform-daemons] submodule update #12841

Merged

7 tasks

StormLiangMS mentioned this pull request Dec 30, 2022

[submodule advance] advance sonic-platform-daemons submodule for 202211 branch #13203

Merged

8 tasks

mihirpat1 pushed a commit to mihirpat1/sonic-buildimage that referenced this pull request Feb 21, 2023

[PSU daemon] Support PSU power threshold checking (sonic-net#288)

ed818f8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add get_graph service to fetch minigraph automatically #288

Add get_graph service to fetch minigraph automatically #288

taoyl-ms commented Feb 10, 2017 •

edited

Loading

svc-acs commented Feb 10, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 10, 2017 •

edited by taoyl-ms

Loading

taoyl-ms Feb 10, 2017

lguohan commented Feb 10, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 10, 2017 •

edited by taoyl-ms

Loading

taoyl-ms Feb 10, 2017

lguohan Feb 10, 2017 •

edited by taoyl-ms

Loading

taoyl-ms Feb 10, 2017

lguohan Feb 10, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 10, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 10, 2017 •

edited by taoyl-ms

Loading

taoyl-ms Feb 10, 2017

lguohan Feb 10, 2017 •

edited by taoyl-ms

Loading

taoyl-ms Feb 10, 2017

lguohan Feb 10, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 10, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 10, 2017 •

edited by taoyl-ms

Loading

taoyl-ms Feb 10, 2017

lguohan Feb 12, 2017 •

edited by taoyl-ms

Loading

taoyl-ms Feb 13, 2017

lguohan Feb 13, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 13, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 13, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 13, 2017

taoyl-ms Feb 13, 2017

lguohan Feb 13, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 13, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 17, 2017 •

edited by taoyl-ms

Loading

lguohan left a comment

Add get_graph service to fetch minigraph automatically #288

Add get_graph service to fetch minigraph automatically #288

Conversation

taoyl-ms commented Feb 10, 2017 • edited Loading

svc-acs commented Feb 10, 2017 • edited by taoyl-ms Loading

lguohan Feb 10, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan commented Feb 10, 2017 • edited by taoyl-ms Loading

lguohan Feb 10, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan Feb 10, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan Feb 10, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

lguohan Feb 10, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

lguohan Feb 10, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan Feb 10, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan Feb 10, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

lguohan Feb 10, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

lguohan Feb 10, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan Feb 12, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan Feb 13, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

lguohan Feb 13, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

lguohan Feb 13, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan Feb 13, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

whether to enable/disable update graph service

url

lguohan Feb 13, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

lguohan Feb 17, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

lguohan left a comment

Choose a reason for hiding this comment

taoyl-ms commented Feb 10, 2017 •

edited

Loading

svc-acs commented Feb 10, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 10, 2017 •

edited by taoyl-ms

Loading

lguohan commented Feb 10, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 10, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 10, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 10, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 10, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 10, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 10, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 10, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 10, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 10, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 12, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 13, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 13, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 13, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 13, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 13, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 17, 2017 •

edited by taoyl-ms

Loading