[Accton] Correct port index and offer the default speed. #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verified with index from 1. Add qsfp_event() for command "show interaface trancerver". Signed-off-by: roy_lee <roy_lee@accton.com>
Add default port speed. Verified with index from 1. Signed-off-by: roy_lee <roy_lee@accton.com>
Add default port speed. Verified with index from 1. Signed-off-by: roy_lee <roy_lee@accton.com>
Add default port speed. Verified with index from 1. Signed-off-by: roy_lee <roy_lee@accton.com>
Add default port speed. Verified with index from 1. Signed-off-by: roy_lee <roy_lee@accton.com>
Update port-config with 1-based index. Signed-off-by: roy_lee <roy_lee@accton.com>
Somehow the service may block, use type=simple to work-around. Add syslog function for monitor. Signed-off-by: roy_lee <roy_lee@accton.com>
Update port-config with 1-based index. Signed-off-by: roy_lee <roy_lee@accton.com>
Update port-config with 1-based index. Implement sfputil change_event. Signed-off-by: roy_lee <roy_lee@accton.com>
…onic-buildimage into add_port_speed_index
Update port-config with 1-based index. Implement sfputil change_event. Signed-off-by: roy_lee <roy_lee@accton.com>
Signed-off-by: roy_lee <roy_lee@accton.com>
Update port-config with 1-based index and default port speed. Signed-off-by: roy_lee <roy_lee@accton.com>
lguohan
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update port config for index from 1 and give default port speed.
But following model are not updated:
as7116_54x: with nephos MAC.
as7212_54x: with marvell MAC.
as4630_54pe: will be handled later.
as7716_32xb: No production.
minipack: Due to hot-swappable port modules.
Note, this may conflict to #2923.
- What I did
- How I did it
Update port_config and sfputil with the index changed.
Generate new config_db with new port_config, and reload that new config.
- How to verify it
sfputil show presence
sfputil show eeprom
show interfaces transciever (but not for all platform)
- Description for the changelog
With port index changed, it has to update sfputil.py for new mapping.