Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform 2.0 Infra and Reboot Reason support for Dell Platforms #3307

Closed
wants to merge 7 commits into from
Closed

Platform 2.0 Infra and Reboot Reason support for Dell Platforms #3307

wants to merge 7 commits into from

Conversation

sridhar-ravindran
Copy link
Contributor

- What I did
Ported Platform 2.0 Infra and Dell S6100,Z9100,S6000 Changes from master to 201904 branch
- How I did it
git cherry-pick and resolve conflicts
It has 3 porting
a) Platform 2.0 base infra + Z9100,S6100 Reboot Reason
b) S6000 Directory clean up
c) S6000 Reboot Reason support
- How to verify it
Currently unable to verify because linux-kernel build is failing due to http timeout
- Description for the changelog

Platform 2.0 Infra and Reboot Reason support for Dell Platforms

- A picture of a cute animal (not mandatory but encouraged)

sridhar-ravindran and others added 3 commits August 5, 2019 01:46
@sridhar-ravindran
[devices]: Porting DELL Platform 2.0 API Infra and Reboot Reason supp…
e9ce93a 
…ort to 201904
@gengankarthik @sridhar-ravindran
Porting S6000 Directory Move PR to 201911
4eef2d2
@sridhar-ravindran
[DELLEMC][S6000] Platform 2.0 Reboot Reason Fix in S6000
2f4a509 
Added Reboot Reason for S6000 in platform 2.0
Fixed issue in process-reboot-cause
Added package uninstall code in platform de-init code for z9100, s6100
- How I did it
-> Added support for S6000 Reboot Reason
-> Added platform.py for all platforms
-> Verified show reboot-cause command with the code changes. Added UT logs with show reboot-cause
-> Modified process-reboot-cause service to start after pmon.service. In S6000, we have to wait for nvram to be loaded.
-> If reboot-cause service starts before pmon.service, show reboot-cause is showing incorrect reason.
-> Bug fix in process-reboot-cause file
- import sonic_platform
+ import sonic_platform.platform
@jleveque
Copy link
Contributor

jleveque commented Aug 8, 2019

Retest this please

2 similar comments
@jleveque
Copy link
Contributor

jleveque commented Aug 8, 2019

Retest this please

@jleveque
Copy link
Contributor

Retest this please

@sridhar-ravindran
Copy link
Contributor Author

Unable to compile build because of following error:-

4.9.168-1+deb9u3_all.deb /sonic/target/debs/stretch/
--2019-09-03 10:14:21-- http://security.debian.org/debian-security/pool/updates/main/l/linux/linux_4.9.168-1+deb9u3.dsc
Resolving security.debian.org (security.debian.org)... 128.61.240.73, 128.31.0.63, 128.101.240.215, ...
Connecting to security.debian.org (security.debian.org)|128.61.240.73|:80... connected.
HTTP request sent, awaiting response... 302 Found
Location: http://security-cdn.debian.org/debian-security/pool/updates/main/l/linux/linux_4.9.168-1+deb9u3.dsc [following]
--2019-09-03 10:14:21-- http://security-cdn.debian.org/debian-security/pool/updates/main/l/linux/linux_4.9.168-1+deb9u3.dsc
Resolving security-cdn.debian.org (security-cdn.debian.org)... 151.101.40.204, 2a04:4e42:a::204
Connecting to security-cdn.debian.org (security-cdn.debian.org)|151.101.40.204|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2019-09-03 10:14:21 ERROR 404: Not Found.

@jleveque
Copy link
Contributor

jleveque commented Sep 5, 2019

Retest this please

@sridhar-ravindran
Copy link
Contributor Author

Hi,
We have raised #3767 to support this feature in master.
Once approved, will raise a new PR for this branch. Request you to review the same.

@sridhar-ravindran sridhar-ravindran deleted the s6000_reboot_reason branch November 22, 2019 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jleveque jleveque

Labels
Enhancement ➕ Platform: DellEMC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sridhar-ravindran @jleveque @gengankarthik