Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[submodule update] update sonic-snmpagent pointer #3496

Closed
wants to merge 1 commit into from

Conversation

mykolaf
Copy link
Collaborator

@mykolaf mykolaf commented Sep 20, 2019

Signed-off-by: Mykola Faryma mykolaf@mellanox.com

- What I did
update sonic-snmpagent pointer
- How I did it

- How to verify it

- Description for the changelog

[sonic-snmpagent]

- A picture of a cute animal (not mandatory but encouraged)

@jleveque
Copy link
Contributor

Retest this please

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
@lguohan
Copy link
Collaborator

lguohan commented Oct 8, 2019

retest this please

1 similar comment
@lguohan
Copy link
Collaborator

lguohan commented Oct 10, 2019

retest this please

@lguohan
Copy link
Collaborator

lguohan commented Oct 10, 2019

@qiluo-msft , do we need this in 201811 branch?

qiluo-msft
qiluo-msft previously approved these changes Oct 10, 2019
@qiluo-msft
Copy link
Collaborator

@qiluo-msft , do we need this in 201811 branch?

We don't need.

@lguohan
Copy link
Collaborator

lguohan commented Oct 10, 2019

then, why is the PR is created against 201811 branch?

@qiluo-msft qiluo-msft dismissed their stale review October 10, 2019 04:03

why is the PR is created against 201811 branch?

@mykolaf
Copy link
Collaborator Author

mykolaf commented Oct 10, 2019

There are a few bugfixes, but I guess it's not mandatory to pull them to such old release.

@mykolaf mykolaf closed this Oct 10, 2019
@mykolaf mykolaf deleted the submodule_update11 branch February 18, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants