Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNMP/LLDP Containers: Sonic V2 Support #41

Merged
merged 1 commit into from
Oct 28, 2016
Merged

SNMP/LLDP Containers: Sonic V2 Support #41

merged 1 commit into from
Oct 28, 2016

Conversation

tombo315
Copy link

  • Adding support for V2 in SNMP/LLDP (-sv2 postfix)
  • Fixes for V1 containers: logging
  • Fixes for V1 LLDP: limit LLDP to Front-panel or MGMT interfaces.

stcheng
stcheng reviewed Oct 26, 2016
View reviewed changes
dockers/docker-lldp/Dockerfile
apt-get remove -y python-pip && \
apt-get purge -y && apt-get autoclean -y && apt-get autoremove -y && \
rm -rf /deps
rm -rf /deps ~/.cache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

align the ''

stcheng
stcheng reviewed Oct 26, 2016
View reviewed changes
dockers/docker-snmp-sv2/Dockerfile
dpkg_apt /deps/libsnmp-base_*.deb && \
dpkg_apt /deps/libsnmp30_*.deb && \
dpkg_apt /deps/snmp_*.deb && \
dpkg_apt /deps/snmpd_*.deb && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use space instead of tab

qiluo-msft
qiluo-msft reviewed Oct 26, 2016
View reviewed changes
dockers/docker-lldp/Dockerfile
COPY deps/*py2*.whl deps/lldpsyncd_*.deb deps/lldpd_*.deb /deps/
COPY deps/sswsdk*.whl deps/lldpsyncd_*.deb deps/lldpd_*.deb /deps/

RUN apt-get update
Copy link
Collaborator

@qiluo-msft qiluo-msft Oct 26, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RUN [](start = 0, length = 3)

RUN [](start = 0, length = 3)

combine 2 RUN commands into one? #Closed

qiluo-msft
qiluo-msft reviewed Oct 26, 2016
View reviewed changes
dockers/docker-lldp-sv2/Dockerfile

COPY deps/sswsdk*.whl deps/sonic_d*.whl deps/lldpsyncd_*.deb deps/lldpd_*.deb /deps/

RUN apt-get update
Copy link
Collaborator

@qiluo-msft qiluo-msft Oct 26, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RUN [](start = 0, length = 3)

RUN [](start = 0, length = 3)

The same. #Closed

qiluo-msft
qiluo-msft reviewed Oct 26, 2016
View reviewed changes
dockers/docker-snmp/Dockerfile
@@ -6,6 +6,8 @@ COPY deps/python3/*.whl /python3/
# enable -O for all Python calls
ENV PYTHONOPTIMIZE 1

RUN apt-get update
Copy link
Collaborator

@qiluo-msft qiluo-msft Oct 26, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RUN [](start = 0, length = 3)

RUN [](start = 0, length = 3)

The same. #Closed

qiluo-msft
qiluo-msft reviewed Oct 26, 2016
View reviewed changes
dockers/docker-snmp-sv2/Dockerfile
rm -rf /usr/lib/python3.5/tkinter && \
rm -rf /usr/lib/python3.5/idlelib && \
rm -rf /usr/lib/python3.5/email && \
rm -rf /usr/lib/python3.5/test && \
Copy link
Collaborator

@qiluo-msft qiluo-msft Oct 26, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge all 'rm' into one command: rm -rf /usr/lib/python3.5/{unittest,lib2to3,...} #Closed

qiluo-msft
qiluo-msft requested changes Oct 26, 2016
View reviewed changes
Copy link
Collaborator

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as comments.

SNMP/LLDP Containers: Sonic V2 Support
95c1636 
* Adding support for V2 in SNMP/LLDP (-sv2 postfix)
* Fixes for V1 containers: logging
* Fixes for V1 LLDP: limit LLDP to Front-panel or MGMT interfaces.
@tombo315
Copy link
Author

All comments addressed.

@tombo315 tombo315 merged commit 2d6627f into sonic-net:master Oct 28, 2016
@stcheng
Copy link
Contributor

stcheng commented Oct 28, 2016

please don't do merge. use squash merge instead.

stcheng pushed a commit that referenced this pull request Oct 28, 2016
SNMP/LLDP Containers: Sonic V2 Support (#41)
135ba23 
* Adding support for V2 in SNMP/LLDP (-sv2 postfix)
* Fixes for V1 containers: logging
* Fixes for V1 LLDP: limit LLDP to Front-panel or MGMT interfaces.
stcheng pushed a commit that referenced this pull request Mar 22, 2017
@qiluo-msft
SNMP/LLDP Containers: Sonic V2 Support (#41)
c052a8a 
* Adding support for V2 in SNMP/LLDP (-sv2 postfix)
* Fixes for V1 containers: logging
* Fixes for V1 LLDP: limit LLDP to Front-panel or MGMT interfaces.
stcheng pushed a commit that referenced this pull request Mar 22, 2017
@qiluo-msft
PR 92604: Sync repo: Github/master -> master
b9ca7e2 
 - SNMP/LLDP Containers: Sonic V2 Support (#41)
 - start.sh: Remove rsyslogd.pid file on mlnx syncd docker (#35)
 - check the existence of platforms/ before including it (#37)
 - build mft-kernel binary debian package (#36)
 - Apply swss configuration in a deterministic way (#39)
 - Dockerfile: Add libsaimetadata dependency (#42)
 - Dockerfile: Add bridge-utils to p4 docker (#43)
 - Add docker configuration for saiserver-brcm   (#44)
 - Modification to saiserver-brcm/Dockerfile (#45)
 - Update get_docker-base.sh
...
lguohan pushed a commit that referenced this pull request Aug 12, 2018
@lguohan
[mellanox]: Update SDK pointer (#41)
678d4d4 
Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
seiferteric pushed a commit to project-arlo/sonic-buildimage that referenced this pull request Nov 25, 2019
@anand-kumar-subramanian
Update git submodules
2e950a7 
* Update src/sonic-telemetry from branch 'broadcom_sonic'
  to 31c54a162e0707830cefcad5cf99451c293095f4
  - [JIRA SONIC-10470]merge sonic-telemetry dell_sonic --> broadcom_sonic 11112019
    
    Change-Id: I2ae9fe6f9a60937ad178c3a930308ea046cad51e
    
  - Merge pull request sonic-net#43 from project-arlo/gnoi_ConfigManagement
    
    Add config mgmt gNOI RPCs, rename sonic gNOI proto file
  - Merge pull request sonic-net#42 from project-arlo/gnoi_techsupport
    
    Gnoi techsupport
  - Add config mgmt gNOI RPCs, rename sonic gNOI proto file
    
  - Merge remote-tracking branch 'github/master' into gnoi_techsupport
    
  - Merge pull request sonic-net#41 from project-arlo/gnmi_set_prefix
    
    Add prefix support to gnmi_set
  - Merge pull request sonic-net#40 from project-arlo/updates_only
    
    Updates only
  - Merge pull request sonic-net#39 from project-arlo/username_password_support
    
    Username password support
  - Make same changes for show-techsupport proto
    
  - Add sonic-tests:sum rpc for example
    
  - wip
    
  - Initial support for showTechSupport rpc
    
  - Add prefix support to gnmi_set
    
  - Finish updates_only for poll and once
    
  - Move line inside block
    
  - Implement updates_only for stream subscriptions
    
  - Add authentication to gNOI. Return gRPC erros from PAMAuthenAndAuthor for better error codes
    
  - verify username/password is actually sent
    
  - Remove file added by accident
    
  - Add cmd line arg to enable user/passwd auth
    
  - Initial username/password auth support
    
  - Merge pull request #36 from project-arlo/gNOI
    
    Initial gNOI Support
  - Merge pull request #37 from project-arlo/jsonSchemaTests
    
    Json schema tests
  - remove debug code
    
  - Fix bug with muliple operations reusing path var
    
  - Add target option to gNOI client
    
  - Get schema for tests from compiled output
    
  - Add flag module to gNOI client to support morre rpcs in the future
    
  - Remove commented out code
    
  - Initial checkin for gNOI, with example System Time rpc
    
  - Merge pull request #34 from project-arlo/jsonSchemaTests
    
    Json schema tests
  - Merge pull request #35 from project-arlo/brcm_poc
    
    Brcm poc
  - Merge remote-tracking branch 'broadcom/broadcom_sonic' into brcm_poc
    
  - Add cleanup to test cases
    
  - Migrate interface ipv4 test to new format
    
  - Fix Makefile schema path, ad models, change test format
    
  - Fix formatting of json in README
    
  - Merge pull request #33 from project-arlo/master
    
    Syncing project-arlo/sonic-telmetry master to brcm_poc
  - typo
    
  - Add readme for json schema tests
    
  - More changes for Json Schema based tests
    
  - Use json schema for get tests as well. Use get test in set to verify results
    
  - Go back to local gNMI server
    
  - Initial validation support using json schema
    
  - Load tests from files and get info from file name
    
  - Merge pull request #30 from project-arlo/fix-check-testcase
    
    Fix check testcase to check individual attributes in a platform-independent way.
  - Merge pull request #31 from project-arlo/gnmi_cli_fixes
    
    Add check that heartbeat_interval is only valid on streaming query type
  - Merge remote-tracking branch 'project-arlo-telemetry/brcm_poc' into broadcom_sonic
    
    Change-Id: Ia772a55a893c2bee3c9e974700e4821f2f8d7af6
    
  - Add check that heartbeat_interval is only valid on streaming query type
    
  - Merge branch 'master' of https://github.com/project-arlo/sonic-telemetry into fix-check-testcase
    
    Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
    
  - Merge pull request #29 from project-arlo/master
    
    Dell fixes on telemetry repo - 13th Sep
  - Merge pull request #28 from project-arlo/tests
    
    Disable platform specific test for now
  - Disable platform specific test for now
    
  - Merge pull request #27 from project-arlo/update_tls_config
    
    Remove duplicate ciphers
  - Remove duplicate ciphers
    
  - fix the check if value set testcase
    
    Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
    
  - Merge pull request #26 from project-arlo/update_tls_config
    
    Update tls config
  - Update cipher suite list again
    
  - Fix spaces to tabs
    
  - Set Min TLS Version and cipher suites
    
  - Merge remote-tracking branch 'project-arlo-telemetry/brcm_poc' into broadcom_sonic
    
    Change-Id: Iae02e417fe8c8ea378a0e85d2354cda10f833b1b
    
  - Merge pull request #25 from project-arlo/master
    
    merge gnmi_cli code into telemetry repo
  - Merge pull request #23 from project-arlo/gnmi_cli_fixes
    
    Gnmi cli fixes
  - Merge pull request #24 from project-arlo/brcm_poc
    
    Fix low code coverage issue by enabling the gnmi_server test code listening on port 8081
  - Fix streaming_type in tests
    
  - Merge remote-tracking branch 'project-arlo-telemetry/brcm_poc' into broadcom_sonic
    
    Change-Id: I14fb29ab4016f390fab9c930a0af69f9a20eba85
    
  - Merge remote-tracking branch 'sshorigin/master' into gnmi_cli_fixes
    
  - Add full code for gnmi_cli with our changes so it can be built from scratch like gnmi_set/get. Update Makefile. Add fixes to gnmi_cli to use seconds as units everywhere instead of nanoseconds, and accept string for -streaming_type
    
  - Merge pull request #22 from project-arlo/brcm_poc
    
    BRCM changes for Telemetry UT
  - Merge remote-tracking branch 'project-arlo-telemetry/brcm_poc' into broadcom_sonic
    
    Change-Id: I4a0804425a4e0a396870004d717f192354dd19c8
    
  - Merge remote-tracking branch 'project-arlo-telemetry/brcm_poc' into broadcom_sonic
    
    Change-Id: Id9f1bef203c4a017d53ce0a854072732656e69ee
    
  - Merge remote-tracking branch 'project-arlo-telemetry/brcm_poc' into broadcom_sonic
    
    Change-Id: Id9f1bef203c4a017d53ce0a854072732656e69ee
    
  - Merge pull request #21 from project-arlo/master
    
    bring brcm_poc in par with master
  - Merge pull request #20 from project-arlo/gnmi-test-after-set
    
    Add code to check values set
  - Add code to check values set
    
    Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
    
  - Merge pull request #19 from project-arlo/gnmi-add-delete-test
    
    Minor fix in Delete OC Interface IP testcase
  - Minor fix in Delete OC Interface IP testcase
    
    Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
    
  - Merge pull request #18 from project-arlo/gnmi-add-delete-test
    
    Add delete test case
  - Add delete testcase
    
    Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
    
  - Merge pull request #17 from project-arlo/gnmi_test_sys_pfm
    
    Gnmi Server test for system platform and interfaces
  - Add json file for ip config
    
    Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
    
  -  Working gnmi server test for sys,pfm,interfaces
    
  - Add test to set ip address
    
    Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
    
  - Code cleanup in server_test.go
    
    Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
    
  - Fix paths
    
  - fix
    
  - Fix some issues with test infra
    
  - Changes for testing get/set operations on OC interfaces
    
    Signed-off-by: Tejaswi Goel <Tejaswi_Goel@Dell.com>
    
  - working gnmi sys and pfm test without clearing bad logs
    
  - Merge pull request #16 from project-arlo/tests
    
    Disable old tests that fail due to new fields being added. Add basic …
  - Disable old tests that fail due to new fields being added. Add basic interface get test and capabilities test. Change package name and add symlink to cvl schema
    
  - Merge pull request #15 from project-arlo/tests
    
    Add test directory
  - Add test directory
    
  - Merge pull request #14 from project-arlo/translib-stream-subscribe
    
    Implement updates_only for ON_CHANGE streaming mode
  - Implement updates_only for ON_CHANGE streaming mode
    
  - Merge pull request #13 from project-arlo/translib-stream-subscribe
    
    Check error response before adding to on_change list
  - Check error response before adding to on_change list
    
  - Merge pull request #12 from project-arlo/capabilities-models
    
    Return models based on translib GetModels API
  - Return models based on translib GetModels API
    
  - Merge pull request #11 from project-arlo/translib-stream-subscribe
    
    Translib stream subscribe
  - Fix bug with sync messages
    
  - Implement suppress_redundant, fix ticker_map format, remove some debug prints, fix heartbeats
    
  - Close channel on error, check if timer if HB
    
  - Update IsSupported to IsOnChangeSupported, add heartbeat_interval support to gnmi_cli, remove debug code
    
  - Fix issue with when sync message is sent. Add heartbeat support. Add valueCache for suppress_redundant (wip)
    
  - convert subscribeResponse to gnmi subscribeResponse and return
    
  - wip
    
  - Merge pull request #10 from project-arlo/fix-if-replace-update
    
    Fix issue with updates and replace with interfaces
  - Fix issue with updates and replace with interfaces
    
  - Merge pull request #9 from project-arlo/sample-subscribe
    
    Sample subscribe
  - Fixes, also include binary for gnmi_cli for now
    
  - Add some dummy code for future subscribe api
    
  - cleanup
    
  - Use ticker_info struct
    
  - cleanup
    
  - Add paths to existing timer group if interval is the same
    
  - Initial support for sample based streaming subscribe
    
  - Merge pull request #8 from project-arlo/subscribe-support
    
    Ad once channel cleanup
  - Ad once channel cleanup
    
  - Merge pull request #7 from project-arlo/subscribe-support
    
    Subscribe support
  - Add gnmi_cli for subscribe client, update Makefile to build it, add .gitignore
    
  - Implement ONCE subscribe mode for translib
    
  - Port polling subscriptions code for translib
    
  - Merge pull request #6 from project-arlo/buildimage-refactor
    
    Fix build issue
  - Fix build issue
    
  - Merge pull request #5 from project-arlo/buildimage-refactor
    
    trigger building ocbinds file in translib, add gnmi_clients
  - trigger building ocbinds file in translib, forgot to add gnmi_clients in last commit
    
  - Merge pull request #4 from project-arlo/buildimage-refactor
    
    Add gnmi set and get client to build
  - Add gnmi set and get client to build
    
  - Merge pull request #3 from project-arlo/buildimage-refactor
    
    Add back install and other targets to fix deb package
  - Add back install and other targets to fix deb package
    
  - Merge pull request #2 from project-arlo/buildimage-refactor
    
    Buildimage refactor
  - Install CVL deps and update gopath
    
  - More Makefile changes
    
  - Move source files into src, change import paths, fixing Makefile
    
  - Merge pull request #1 from project-arlo/brcm_poc
    
    Merge PoC changes to master
  - Ignore test results for gnmi_server
    
    The Debian files attempt to run make check for the gNMI server, however,
    it fails on a build machine, because it expects the Redis server to be
    available and listening on localhost port 6379.
    
    For now, the result of the test is ignored, and we have to find a way to
    fix this so that the tests work even on a build machine.
    
  - GNMI PoC changes
samaity pushed a commit to samaity/sonic-buildimage that referenced this pull request Feb 14, 2020
@zhenggen-xu
[docker-frr] Fix the start.sh where it fails in case no WARM_RESTART …
c884f26 
…in configDB (sonic-net#41)

Signed-off-by: Zhenggen Xu <zxu@linkedin.com>
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
@scsmncao
doc: Adding TUNNEL_DECAP schema (sonic-net#41)
6b10f95
@dzhangalibaba dzhangalibaba mentioned this pull request May 7, 2020
Merged
xumia referenced this pull request in xumia/sonic-buildimage-1 Feb 16, 2021
@stcheng
[sairedis]: Make Jenkinsfile DRY (#41)
5094fee 
* [sairedis]: Make Jenkinsfile DRY
* Add color support

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
@Pterosaur Pterosaur mentioned this pull request Nov 29, 2021
Merged
lguohan pushed a commit that referenced this pull request Jan 13, 2022
@Pterosaur
[submodule]: update sonic-wpa-supplicant (#9388)
5cdfffe 
457e94d51 [macsec_linux]: Fixbug cannot dump the PN due to type error (#42)
f7c073323 Disable P2P module (#41)
7b3b777e2 [ci]: use native arm64 and armhf build pool (#40)
d4e91d66c [sonic_operator]: Increase wait timeout (#39)
43611ef88e [sonic_operators]: Add log in sonic operators (#43)

Signed-off-by: Ze Gan <ganze718@gmail.com>
@xumia xumia mentioned this pull request Jan 18, 2022
Merged
5 tasks
SuvarnaMeenakshi pushed a commit to SuvarnaMeenakshi/sonic-buildimage that referenced this pull request Mar 16, 2022
[mibs]: Fix bug module has no attribute 'get_index_from_str' (sonic-n…
bc4becf 
…et#41)

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
@zjswhhh zjswhhh mentioned this pull request Mar 17, 2022
Merged
6 tasks
lguohan pushed a commit that referenced this pull request Mar 18, 2022
@zjswhhh
[sonic-linkmgrd][master] submodule update (#10271)
64822d8 
f00efef Longxiang Lyu Wed Mar 16 09:12:46 2022 +0800 Add a command line option to store logs into a separate file (#41)
ff2e67d Longxiang Lyu Tue Mar 15 09:10:59 2022 +0800 Add default port cable type (#39)
ebbb4d8 Jing Zhang Mon Mar 14 15:41:11 2022 -0700 Prevent switching MUX to "Unknown" (#36)
c779b8f Longxiang Lyu Thu Mar 10 21:35:11 2022 +0800 [nonfunctional] Use LinkProberStateMachineBase (#38)
b9fedd0 Longxiang Lyu Wed Mar 9 13:03:58 2022 +0800 [NONFUNCTIONAL] Add LinkProberStateMachineBase (#37)
bedd42b Longxiang Lyu Wed Mar 9 10:03:00 2022 +0800 Add .clang-format file to format code (#28)
9fe4fc6 Guohan Lu Thu Mar 3 17:51:43 2022 -0800 [doc]: add lgtm badge in README.md
c1249d9 Longxiang Lyu Wed Mar 2 18:05:18 2022 +0800 Enable lgtm (#33)
b8514c6 Longxiang Lyu Wed Mar 2 13:34:39 2022 +0800 Collect port cable type to use corresponding state machine (#31)
9b59ef9 Longxiang Lyu Wed Mar 2 07:19:33 2022 +0800 Improve make clean (#32)
sg893052 pushed a commit to sg893052/sonic-buildimage that referenced this pull request Apr 25, 2022
@dks19
Merge pull request sonic-net#41 from sathishshiva/master
9e0ce54 
IGMP Klish/OCYang HLD
Gokulnath-Raja pushed a commit to Gokulnath-Raja/sonic-buildimage-work that referenced this pull request May 22, 2023
@liushilongbuaa
[CI] Set up CI&PR with Azure Pipelines (sonic-net#41)
5615e5c 
[skip ci]

Signed-off-by: Shilong Liu <shilongliu@microsoft.com>
GouthamBanala added a commit to GouthamBanala/sonic-buildimage that referenced this pull request Aug 23, 2023
@GouthamBanala
Merge pull request sonic-net#41 from GouthamBanala/upgrade
9ecd674 
Bringing changes from sonic-build image main and supervisord change to correct device health container name
shanshri pushed a commit to shanshri/sonic-buildimage-sonic-net that referenced this pull request Oct 24, 2023
@donboll @lguohan
drivers/misc/eeprom: Add support for optoe driver (sonic-net#41)
3525f35 
* drivers/misc/eeprom:  Add support for optoe driver

* Add the optoe driver, copied from github.com/opencomputeproject/oom
* Update Makefile to build optoe
* Update Kconfig to configure optoe

Signed-off-by: Don Bollinger <don@thebollingers.org>
mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024
@gechiang
Merge pull request sonic-net#41 from gechiang/202205
11b3ec6 
[Submodule Update] Update to latest head of sonic-utilities.msft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stcheng stcheng stcheng left review comments

@qiluo-msft qiluo-msft qiluo-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tombo315 @stcheng @qiluo-msft