Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[interface-config] Fix a loopback addr config bug #437

Merged
merged 1 commit into from
Mar 25, 2017
Merged

[interface-config] Fix a loopback addr config bug #437

merged 1 commit into from
Mar 25, 2017

Conversation

taoyl-ms
Copy link
Contributor

@taoyl-ms taoyl-ms commented Mar 25, 2017 •
edited
Loading

Fix a bug introduced in PR #430 that addresses on lo are not configured correctly.

It turns out that service networking restart won’t reconfigure lo.
What we need is service networking restart AND ifdown lo && ifup lo.

@taoyl-ms
[interface-config] Fix a loopback addr config bug
a40d54e 
Fix a bug introduced in PR 430 that addresses on lo are not configured correctly.
@taoyl-ms taoyl-ms requested a review from stcheng March 25, 2017 00:56
@stcheng
Copy link
Contributor

stcheng commented Mar 25, 2017

there are --exclude=lo in /etc/init.d/networking file. seems to be some reasons. not sure why.

@taoyl-ms taoyl-ms merged commit 9e8df96 into master Mar 25, 2017
@stcheng stcheng deleted the taoyl/lo_config branch March 25, 2017 01:13
@mykolaf mykolaf mentioned this pull request Feb 4, 2019
Merged
lguohan pushed a commit that referenced this pull request Feb 4, 2019
@mykolaf @lguohan
[submodule] update utilities pointer (#2523)
3d0d007 
- [config/main.py]Fixed - added a validation such that delete portchannel or portchannel members only when it is configured (#277) (#445)
- Revert "[config/main.py]Fixed - added a validation such that delete portchannel or portchannel members only when it is configured (#277) (#445)" (#452)
- [intfutil] add Asymmetric PFC status to 'show interface status' (#437)

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
yxieca pushed a commit that referenced this pull request Feb 7, 2019
@mykolaf @yxieca
[submodule] update utilities pointer (#2523)
a98fe06 
- [config/main.py]Fixed - added a validation such that delete portchannel or portchannel members only when it is configured (#277) (#445)
- Revert "[config/main.py]Fixed - added a validation such that delete portchannel or portchannel members only when it is configured (#277) (#445)" (#452)
- [intfutil] add Asymmetric PFC status to 'show interface status' (#437)

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Apr 1, 2019
@yxieca
[201811][sairedis][swss] advance sub module head of sairedis and swss
9fab03a 
Submodule src/sonic-sairedis 8182916..483c89e:
  > Notify OA about exception and process only restart query events (sonic-net#437)

Submodule src/sonic-swss 91171b6..d22b2de:
  > Allow ACL entry creation without ACL counter (sonic-net#818)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca mentioned this pull request Apr 1, 2019
Merged
yxieca added a commit that referenced this pull request Apr 1, 2019
@yxieca
[201811][sairedis][swss] advance sub module head of sairedis and swss (…
502ddb0 
…#2728)

Submodule src/sonic-sairedis 8182916..483c89e:
  > Notify OA about exception and process only restart query events (#437)

Submodule src/sonic-swss 91171b6..d22b2de:
  > Allow ACL entry creation without ACL counter (#818)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@wendani wendani mentioned this pull request Apr 9, 2019
Merged
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
@yxieca @tiantianlv
[201811][sairedis][swss] advance sub module head of sairedis and swss (…
fc9ce68 
…sonic-net#2728)

Submodule src/sonic-sairedis 8182916..483c89e:
  > Notify OA about exception and process only restart query events (sonic-net#437)

Submodule src/sonic-swss 91171b6..d22b2de:
  > Allow ACL entry creation without ACL counter (sonic-net#818)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
@yxieca @tiantianlv
[201811][sairedis][swss] advance sub module head of sairedis and swss (…
304e42a 
…sonic-net#2728)

Submodule src/sonic-sairedis 8182916..483c89e:
  > Notify OA about exception and process only restart query events (sonic-net#437)

Submodule src/sonic-swss 91171b6..d22b2de:
  > Allow ACL entry creation without ACL counter (sonic-net#818)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
@yxieca @tiantianlv
[201811][sairedis][swss] advance sub module head of sairedis and swss (…
0b0eb1c 
…sonic-net#2728)

Submodule src/sonic-sairedis 8182916..483c89e:
  > Notify OA about exception and process only restart query events (sonic-net#437)

Submodule src/sonic-swss 91171b6..d22b2de:
  > Allow ACL entry creation without ACL counter (sonic-net#818)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
lguohan pushed a commit that referenced this pull request Apr 12, 2019
@wendani @lguohan
[submodule]: submodule update for PFC watchdog warm reboot commits (#…
9b6a2fb 
…2755)

sonic-sairedis:
e8cb879 Make object list deterministic when iterating (#438)
5486f97 Ignore ACL_COUNTER bytes and packets during comparison logic (#443)
b138ff9 Notify OA about exception and process only restart query events (#437)
0974a43 Set MTU value on created tap device for virtual switch (#436)
e2f50e8 Increase eth buffer size to 16k for virtual switch (#435)
79fb388 [bfn] Ged rid of ld_preload. Link against libsai only (#429)
2e47b78 Remove MAC alignment WA for Mellanox platforms. (#430)
e1354fe Add pre match to comparison logic and unittests (#423)
18a5ebb Drop FDB notifications if they contain invalid OIDs (#428)

sonic-swss-common:
8af58ad sonic-swss-common: Add vxlan macros to schema (#269)
76837bf Make class Select support batch read from selectables (#270)
4cf643e Add multiple fields hdel support (#267)
a710529 Update PFC_WD table name in CONFIG_DB (#266)
3c452c1 Update README.md (#268)

sonic-swss:
e329dbd Survive pfc watchdog storm action across warm-reboot (#794)

sonic-utilities:
6ee0aea (HEAD, origin/master, origin/HEAD) [config]: Change the order of interface commands (#504)
5ae30d2 [show vlan brief] Support 'alias' interface naming mode (#497)
bafebf9 Update neighbor advertiser (#498)
fa90083 [clear/main.py]: clear ndp command. (#450)
65f69e4 [show interface neighbor expected] Support 'alias' interface naming mode (#495)
aae39e7 updated show ipv6 interface for alias mode (#493)
170fed9 [warm-reboot] initialize warm reboot state table before warm rebooting (#492)
06cd99f Allow config shutdown and startup operations on valid PortChannel interface names (#474)
98cdebb [show ip interface] Add support for 'alias' interface naming mode (#486)
5f1de81 [show] Add serial numbers/uptime/hwinfo to 'show version' output (#488)
e78a866 [route_check] Move scripts under scripts/ directory, add to setup.py (#489)
d347527 Change PFC watchdog CONFIG_DB table name from PFC_WD_TABLE to PFC_WD (#475)

Signed-off-by: Wenda Ni <wenni@microsoft.com>
Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019
@mykolaf @lguohan
[intfutil] add Asymmetric PFC status to 'show interface status' (soni…
c6666e2 
…c-net#437)

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020
@kcudnik @yxieca
Notify OA about exception and process only restart query events (soni…
b138ff9 
…c-net#437)
qiluo-msft added a commit to qiluo-msft/sonic-buildimage that referenced this pull request Jan 7, 2021
@qiluo-msft
[sonic-swss-common] Update submodule
2ad522c 
Includes sonic-swss-common commits:
```
71dc350 2021-01-07 | Lower the log level for outdated key for SubscriberStateTable notification (sonic-net#441) [Qi Luo]
7e40582 2021-01-08 | Add boost dependencies (sonic-net#442) [Ze Gan]
30a8ddf 2021-01-05 | Change DBConnector::hgetall return type from map to unordered_map (sonic-net#440) [Qi Luo]
021108d 2021-01-02 | MCLAG Enhancements per HLD sonic-net/SONiC#596 (sonic-net#405) [Praveen-Brcm]
54996fc 2021-01-02 | Implement ConfigDBConnector and ConfigDBPipeConnector in C++ (sonic-net#437) [Qi Luo]
8286525 2020-12-27 | Simply refactor DBConnector hgetall() [Qi Luo]
6d1d33b 2020-12-27 | Fix RedisTransactioner: handle empty deque [Qi Luo]
624e0b8 2020-12-26 | Move complex class constructor as explicit, and fix several mistaken copy constructor usage [Qi Luo]
3b983f9 2020-12-30 | [ci]: add timeout to 180 minutes for arm build (sonic-net#439) [lguohan]
f2e4210 2020-12-29 | Add utility for string and redis (sonic-net#434) [Ze Gan]
7a885fd 2020-12-29 | [build]: add build check for arm64 and armhf (sonic-net#436) [lguohan]
47bccc4 2020-12-24 | Add missed vector header to rediscommand.h (sonic-net#435) [Ze Gan]
```
qiluo-msft added a commit that referenced this pull request Jan 8, 2021
@qiluo-msft
[sonic-swss-common] Update submodule (#6382)
5b7f88a 
Includes sonic-swss-common commits:
```
71dc350 2021-01-07 | Lower the log level for outdated key for SubscriberStateTable notification (#441) [Qi Luo]
7e40582 2021-01-08 | Add boost dependencies (#442) [Ze Gan]
30a8ddf 2021-01-05 | Change DBConnector::hgetall return type from map to unordered_map (#440) [Qi Luo]
021108d 2021-01-02 | MCLAG Enhancements per HLD sonic-net/SONiC#596 (#405) [Praveen-Brcm]
54996fc 2021-01-02 | Implement ConfigDBConnector and ConfigDBPipeConnector in C++ (#437) [Qi Luo]
8286525 2020-12-27 | Simply refactor DBConnector hgetall() [Qi Luo]
6d1d33b 2020-12-27 | Fix RedisTransactioner: handle empty deque [Qi Luo]
624e0b8 2020-12-26 | Move complex class constructor as explicit, and fix several mistaken copy constructor usage [Qi Luo]
3b983f9 2020-12-30 | [ci]: add timeout to 180 minutes for arm build (#439) [lguohan]
f2e4210 2020-12-29 | Add utility for string and redis (#434) [Ze Gan]
7a885fd 2020-12-29 | [build]: add build check for arm64 and armhf (#436) [lguohan]
47bccc4 2020-12-24 | Add missed vector header to rediscommand.h (#435) [Ze Gan]
```
lguohan pushed a commit that referenced this pull request Jan 9, 2021
@qiluo-msft @lguohan
[sonic-swss-common] Update submodule (#6382)
88ace50 
Includes sonic-swss-common commits:
```
71dc350 2021-01-07 | Lower the log level for outdated key for SubscriberStateTable notification (#441) [Qi Luo]
7e40582 2021-01-08 | Add boost dependencies (#442) [Ze Gan]
30a8ddf 2021-01-05 | Change DBConnector::hgetall return type from map to unordered_map (#440) [Qi Luo]
021108d 2021-01-02 | MCLAG Enhancements per HLD sonic-net/SONiC#596 (#405) [Praveen-Brcm]
54996fc 2021-01-02 | Implement ConfigDBConnector and ConfigDBPipeConnector in C++ (#437) [Qi Luo]
8286525 2020-12-27 | Simply refactor DBConnector hgetall() [Qi Luo]
6d1d33b 2020-12-27 | Fix RedisTransactioner: handle empty deque [Qi Luo]
624e0b8 2020-12-26 | Move complex class constructor as explicit, and fix several mistaken copy constructor usage [Qi Luo]
3b983f9 2020-12-30 | [ci]: add timeout to 180 minutes for arm build (#439) [lguohan]
f2e4210 2020-12-29 | Add utility for string and redis (#434) [Ze Gan]
7a885fd 2020-12-29 | [build]: add build check for arm64 and armhf (#436) [lguohan]
47bccc4 2020-12-24 | Add missed vector header to rediscommand.h (#435) [Ze Gan]
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stcheng stcheng stcheng approved these changes

Assignees
No one assigned
Labels
Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taoyl-ms @stcheng