[201811][mlnx] add option to build sdk from sources #4378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepanblyschak
force-pushed
the
1811mlxsdkbuild
branch
2 times, most recently
from
24a28e1
to
25b46fe
Compare
qiluo-msft
reviewed
Apr 7, 2020
| @@ -116,6 +116,7 @@ RUN apt-get update && apt-get install -y \ | |||
| libdb-dev \ | |||
| iptables-dev \ | |||
| swig \ | |||
| ctags \ | |||
There was a problem hiding this comment.
On line L106, these packages are for mellanox sdk build. ctags is build dependency for python-sdk-api package
There was a problem hiding this comment.
Everyone has no access to MLNX_SDK_SOURCE_BASE_URL, but need one extra package in sonic-slave. It is weird for a package to depend on ctags during build time. Could you check if you can remove this dependency internally?
In reply to: 404943374 [](ancestors = 404943374)
stepanblyschak
added
Request for 201811 Branch 
and removed
Included in 201811 Branch
Request for 201811 Branch
labels
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
stepanblyschak
force-pushed
the
1811mlxsdkbuild
branch
from
25b46fe
to
9318ee9
Compare
|
retest broadcom please |
yxieca
reviewed
Apr 8, 2020
yxieca
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak stepanb@mellanox.com
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)